Skip to content

Commit 4963305

Browse files
committed
refactor: modify C implementation to accept double value
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 59f0fbb commit 4963305

File tree

7 files changed

+32
-30
lines changed

7 files changed

+32
-30
lines changed

lib/node_modules/@stdlib/math/base/special/negalucas/README.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -191,19 +191,19 @@ for ( i = 0; i > -77; i-- ) {
191191
Computes the nth [negaLucas number][lucas-number].
192192

193193
```c
194-
double out = stdlib_base_negalucas( 0 );
195-
// returns 0
194+
double out = stdlib_base_negalucas( 0.0 );
195+
// returns 0.0
196196

197-
out = stdlib_base_negalucas( -1 );
198-
// returns -1
197+
out = stdlib_base_negalucas( -1.0 );
198+
// returns -1.0
199199
```
200200

201201
The function accepts the following arguments:
202202

203-
- **n**: `[in] int32_t` input value.
203+
- **n**: `[in] double` input value.
204204

205205
```c
206-
double stdlib_base_negalucas( const int32_t n );
206+
double stdlib_base_negalucas( const double n );
207207
```
208208
209209
</section>
@@ -227,15 +227,14 @@ double stdlib_base_negalucas( const int32_t n );
227227
```c
228228
#include "stdlib/math/base/special/negalucas.h"
229229
#include <stdio.h>
230-
#include <stdint.h>
231230
232231
int main( void ) {
233-
int32_t i;
232+
double i;
234233
double v;
235234
236-
for ( i = 0; i > -77; i-- ) {
235+
for ( i = 0.0; i > -77.0; i-- ) {
237236
v = stdlib_base_negalucas( i );
238-
printf( "negalucas(%d) = %lf\n", i, v );
237+
printf( "negalucas(%lf) = %lf\n", i, v );
239238
}
240239
}
241240
```

lib/node_modules/@stdlib/math/base/special/negalucas/benchmark/c/native/benchmark.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,13 @@ static double rand_double( void ) {
9191
*/
9292
static double benchmark( void ) {
9393
double elapsed;
94-
int32_t x[ 100 ];
94+
double x[ 100 ];
9595
double t;
9696
double y;
9797
int i;
9898

9999
for ( i = 0; i < 100; i++ ) {
100-
x[ i ] = (int32_t)( 77.0*rand_double() );
100+
x[ i ] = ( 77.0*rand_double() );
101101
}
102102

103103
t = tic();

lib/node_modules/@stdlib/math/base/special/negalucas/examples/c/example.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,13 @@
1818

1919
#include "stdlib/math/base/special/negalucas.h"
2020
#include <stdio.h>
21-
#include <stdint.h>
2221

2322
int main( void ) {
24-
int32_t i;
23+
double i;
2524
double v;
2625

27-
for ( i = 0; i > -77; i-- ) {
26+
for ( i = 0.0; i > -77.0; i-- ) {
2827
v = stdlib_base_negalucas( i );
29-
printf( "negalucas(%d) = %lf\n", i, v );
28+
printf( "negalucas(%lf) = %lf\n", i, v );
3029
}
3130
}

lib/node_modules/@stdlib/math/base/special/negalucas/include/stdlib/math/base/special/negalucas.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
#ifndef STDLIB_MATH_BASE_SPECIAL_NEGALUCAS_H
2020
#define STDLIB_MATH_BASE_SPECIAL_NEGALUCAS_H
2121

22-
#include <stdint.h>
23-
2422
/*
2523
* If C++, prevent name mangling so that the compiler emits a binary file having undecorated names, thus mirroring the behavior of a C compiler.
2624
*/
@@ -31,7 +29,7 @@ extern "C" {
3129
/**
3230
* Computes the nth negaLucas number.
3331
*/
34-
double stdlib_base_negalucas( const int32_t n );
32+
double stdlib_base_negalucas( const double n );
3533

3634
#ifdef __cplusplus
3735
}

lib/node_modules/@stdlib/math/base/special/negalucas/manifest.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@
3838
"dependencies": [
3939
"@stdlib/math/base/napi/unary",
4040
"@stdlib/math/base/special/labs",
41-
"@stdlib/constants/float64/max-safe-nth-lucas"
41+
"@stdlib/constants/float64/max-safe-nth-lucas",
42+
"@stdlib/math/base/assert/is-integer"
4243
]
4344
},
4445
{
@@ -53,7 +54,8 @@
5354
"libpath": [],
5455
"dependencies": [
5556
"@stdlib/math/base/special/labs",
56-
"@stdlib/constants/float64/max-safe-nth-lucas"
57+
"@stdlib/constants/float64/max-safe-nth-lucas",
58+
"@stdlib/math/base/assert/is-integer"
5759
]
5860
},
5961
{
@@ -68,7 +70,8 @@
6870
"libpath": [],
6971
"dependencies": [
7072
"@stdlib/math/base/special/labs",
71-
"@stdlib/constants/float64/max-safe-nth-lucas"
73+
"@stdlib/constants/float64/max-safe-nth-lucas",
74+
"@stdlib/math/base/assert/is-integer"
7275
]
7376
}
7477
]

lib/node_modules/@stdlib/math/base/special/negalucas/src/addon.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@
1919
#include "stdlib/math/base/special/negalucas.h"
2020
#include "stdlib/math/base/napi/unary.h"
2121

22-
STDLIB_MATH_BASE_NAPI_MODULE_I_D( stdlib_base_negalucas )
22+
STDLIB_MATH_BASE_NAPI_MODULE_D_D( stdlib_base_negalucas )

lib/node_modules/@stdlib/math/base/special/negalucas/src/main.c

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,11 @@
1717
*/
1818

1919
#include "stdlib/math/base/special/negalucas.h"
20+
#include "stdlib/math/base/assert/is_integer.h"
2021
#include "stdlib/math/base/special/labs.h"
2122
#include "stdlib/constants/float64/max_safe_nth_lucas.h"
23+
#include <stdint.h>
24+
#include <stdlib.h>
2225

2326
static const int64_t negalucas_value[ 77 ] = {
2427
2,
@@ -107,17 +110,17 @@ static const int64_t negalucas_value[ 77 ] = {
107110
* @return output value
108111
*
109112
* @example
110-
* double out = stdlib_base_negalucas( -1 );
111-
* // returns -1
113+
* double out = stdlib_base_negalucas( -1.0 );
114+
* // returns -1.0
112115
*
113116
* @example
114-
* double out = stdlib_base_negalucas( 1 );
117+
* double out = stdlib_base_negalucas( 1.0 );
115118
* // returns NaN
116119
*/
117-
double stdlib_base_negalucas( const int32_t n ) {
118-
int32_t an = stdlib_base_labs( n );
119-
if ( n > 0 || an > STDLIB_CONSTANT_FLOAT64_MAX_SAFE_NTH_LUCAS ) {
120+
double stdlib_base_negalucas( const double n ) {
121+
double an = stdlib_base_labs( n );
122+
if ( !stdlib_base_is_integer( n ) || n > 0 || an > STDLIB_CONSTANT_FLOAT64_MAX_SAFE_NTH_LUCAS ) {
120123
return 0.0 / 0.0; // NaN
121124
}
122-
return negalucas_value[ an ];
125+
return negalucas_value[ (size_t)an ];
123126
}

0 commit comments

Comments
 (0)