Skip to content

Commit 4e65259

Browse files
committed
test: update test messages and use ulpdiff for comparison
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 0832f27 commit 4e65259

File tree

2 files changed

+8
-22
lines changed

2 files changed

+8
-22
lines changed

lib/node_modules/@stdlib/math/base/special/sinpi/test/test.js

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,10 @@ var tape = require( 'tape' );
2424
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2525
var PINF = require( '@stdlib/constants/float64/pinf' );
2626
var NINF = require( '@stdlib/constants/float64/ninf' );
27-
var EPS = require( '@stdlib/constants/float64/eps' );
28-
var abs = require( '@stdlib/math/base/special/abs' );
2927
var isNegativeZero = require( '@stdlib/assert/is-negative-zero' );
3028
var isPositiveZero = require( '@stdlib/assert/is-positive-zero' );
3129
var isSameValue = require( '@stdlib/assert/is-same-value' );
30+
var ulpdiff = require( '@stdlib/number/float64/base/ulp-difference' );
3231
var sinpi = require( './../lib/' );
3332

3433

@@ -82,7 +81,7 @@ tape( 'if provided an integer, the function returns `+-0`', function test( t ) {
8281
expected = integers.expected;
8382
for ( i = 0; i < x.length; i++ ) {
8483
y = sinpi( x[i] );
85-
t.strictEqual( isSameValue( y, expected[ i ] ), true, 'returns '+expected[ i ] );
84+
t.strictEqual( isSameValue( y, expected[ i ] ), true, 'returns expected value' );
8685
}
8786
t.end();
8887
});
@@ -97,14 +96,13 @@ tape( 'the function is odd', function test( t ) {
9796
for ( i = 0; i < x.length; i++ ) {
9897
y = sinpi( -x[i] );
9998
expected = -sinpi( x[i] );
100-
t.strictEqual( y, expected, 'returns '+expected );
99+
t.strictEqual( y, expected, 'returns expected value' );
101100
}
102101
t.end();
103102
});
104103

105104
tape( 'the function computes `sin(πx)`', function test( t ) {
106105
var expected;
107-
var delta;
108106
var x;
109107
var y;
110108
var i;
@@ -113,12 +111,7 @@ tape( 'the function computes `sin(πx)`', function test( t ) {
113111
expected = decimals.expected;
114112
for ( i = 0; i < x.length; i++ ) {
115113
y = sinpi( x[i] );
116-
if ( y === expected[ i ] ) {
117-
t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] );
118-
} else {
119-
delta = abs( y - expected[i] );
120-
t.ok( delta <= EPS, 'within tolerance. x: '+x[i]+'. Value: '+y+'. Expected: '+expected[i]+'. Tolerance: '+EPS+'.' );
121-
}
114+
t.strictEqual( ulpdiff( y, expected[ i ] ) <= 1, true, 'returns expected value within 1 ulp' );
122115
}
123116
t.end();
124117
});

lib/node_modules/@stdlib/math/base/special/sinpi/test/test.native.js

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,10 @@ var tape = require( 'tape' );
2525
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2626
var PINF = require( '@stdlib/constants/float64/pinf' );
2727
var NINF = require( '@stdlib/constants/float64/ninf' );
28-
var EPS = require( '@stdlib/constants/float64/eps' );
29-
var abs = require( '@stdlib/math/base/special/abs' );
3028
var isNegativeZero = require( '@stdlib/assert/is-negative-zero' );
3129
var isPositiveZero = require( '@stdlib/assert/is-positive-zero' );
3230
var isSameValue = require( '@stdlib/assert/is-same-value' );
31+
var ulpdiff = require( '@stdlib/number/float64/base/ulp-difference' );
3332
var tryRequire = require( '@stdlib/utils/try-require' );
3433

3534

@@ -91,7 +90,7 @@ tape( 'if provided an integer, the function returns `+-0`', opts, function test(
9190
expected = integers.expected;
9291
for ( i = 0; i < x.length; i++ ) {
9392
y = sinpi( x[i] );
94-
t.strictEqual( isSameValue( y, expected[ i ] ), true, 'returns '+expected[ i ] );
93+
t.strictEqual( isSameValue( y, expected[ i ] ), true, 'returns expected value' );
9594
}
9695
t.end();
9796
});
@@ -106,14 +105,13 @@ tape( 'the function is odd', opts, function test( t ) {
106105
for ( i = 0; i < x.length; i++ ) {
107106
y = sinpi( -x[i] );
108107
expected = -sinpi( x[i] );
109-
t.strictEqual( y, expected, 'returns '+expected );
108+
t.strictEqual( y, expected, 'returns expected value' );
110109
}
111110
t.end();
112111
});
113112

114113
tape( 'the function computes `sin(πx)`', opts, function test( t ) {
115114
var expected;
116-
var delta;
117115
var x;
118116
var y;
119117
var i;
@@ -122,12 +120,7 @@ tape( 'the function computes `sin(πx)`', opts, function test( t ) {
122120
expected = decimals.expected;
123121
for ( i = 0; i < x.length; i++ ) {
124122
y = sinpi( x[i] );
125-
if ( y === expected[ i ] ) {
126-
t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. Expected: '+expected[i] );
127-
} else {
128-
delta = abs( y - expected[i] );
129-
t.ok( delta <= EPS, 'within tolerance. x: '+x[i]+'. Value: '+y+'. Expected: '+expected[i]+'. Tolerance: '+EPS+'.' );
130-
}
123+
t.strictEqual( ulpdiff( y, expected[ i ] ) <= 1, true, 'returns expected value within 1 ulp' );
131124
}
132125
t.end();
133126
});

0 commit comments

Comments
 (0)