Skip to content

Commit 576bd4b

Browse files
bench: revert uniform implementation and remove unnecessary loop
PR-URL: #5314 Closes: #5228 Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Neeraj Pathak <[email protected]> Reviewed-by: Karan Anand <[email protected]> Reviewed-by: Saurabh Singh <[email protected]>Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
1 parent 7c6d2b7 commit 576bd4b

File tree

2 files changed

+6
-18
lines changed

2 files changed

+6
-18
lines changed

lib/node_modules/@stdlib/stats/base/dists/planck/median/benchmark/benchmark.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var Float64Array = require( '@stdlib/array/float64' );
25-
var uniform = require( '@stdlib/random/base/uniform' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2625
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2726
var pkg = require( './../package.json' ).name;
2827
var median = require( './../lib' );
@@ -32,19 +31,14 @@ var median = require( './../lib' );
3231

3332
bench( pkg, function benchmark( b ) {
3433
var lambda;
35-
var len;
3634
var y;
3735
var i;
3836

39-
len =100;
40-
lambda = new Float64Array( len );
41-
for ( i = 0; i < len; i++ ) {
42-
lambda[ i ] = uniform( 1.0, 10.0);
43-
}
37+
lambda = uniform( 100, 0.1, 10.0 );
4438

4539
b.tic();
4640
for ( i = 0; i < b.iterations; i++ ) {
47-
y = median( lambda[ i % len ] );
41+
y = median( lambda[ i % lambda.length ] );
4842
if ( isnan( y ) ) {
4943
b.fail( 'should not return NaN' );
5044
}

lib/node_modules/@stdlib/stats/base/dists/planck/median/benchmark/benchmark.native.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var Float64Array = require( '@stdlib/array/float64' );
26-
var uniform = require( '@stdlib/random/base/uniform' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2726
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2827
var tryRequire = require( '@stdlib/utils/try-require' );
2928
var pkg = require( './../package.json' ).name;
@@ -41,19 +40,14 @@ var opts = {
4140

4241
bench( pkg+'::native', opts, function benchmark( b ) {
4342
var lambda;
44-
var len;
4543
var y;
4644
var i;
4745

48-
len = 100;
49-
lambda = new Float64Array( len );
50-
for ( i = 0; i < len; i++ ) {
51-
lambda[ i ] = uniform( 1.0, 10.0 );
52-
}
46+
lambda = uniform( 100, 0.1, 10.0 );
5347

5448
b.tic();
5549
for ( i = 0; i < b.iterations; i++ ) {
56-
y = median( lambda[ i % len ] );
50+
y = median( lambda[ i % lambda.length ] );
5751
if ( isnan( y ) ) {
5852
b.fail( 'should not return NaN' );
5953
}

0 commit comments

Comments
 (0)