refactor: update sort logic and insertion place

Author: ahmad-kashkoush

lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js

@@ -581,60 +581,6 @@ function factory( dtype ) { // eslint-disable-line max-lines-per-function, stdli
 		}
 		return true;
 	});
-	/**
-	* Sorts an array in-place.
-	*
-	* @private
-	* @name sort
-	* @memberof TypedArray.prototype
-	* @type {Function}
-	* @param {Function} compareFcn - comparison function
-	* @throws {TypeError} `this` must be a typed array
-	* @throws {TypeError} first argument must be a function
-	* @returns {TypedArray} sorted array
-	*/
-	setReadOnly( TypedArray.prototype, 'sort', function sort( compareFcn ) {
-		var minIdx;
-		var minVal;
-		var val;
-		var buf;
-		var i;
-		var j;
-
-		if ( !isTypedArray( this ) ) {
-			throw new TypeError( format( 'invalid invocation. `this` is not %s %s.', CHAR2ARTICLE[ dtype[0] ], CTOR_NAME ) );
-		}
-		if ( arguments.length === 0 ) {
-			compareFcn = function defaultCompareFcn( a, b ) {
-				if ( a > b ) {
-					return 1;
-				}
-				if ( a < b ) {
-					return -1;
-				}
-				return 0;
-			};
-		} else if ( !isFunction( compareFcn ) ) {
-			throw new TypeError( format( 'invalid argument. First argument must be a function. Value: `%s`.', compareFcn ) );
-		}
-		buf = this._buffer;
-		for ( i = 0; i < this._length-1; i++ ) {
-			minIdx = i;
-			minVal = buf[ GETTER ]( i * BYTES_PER_ELEMENT, this._isLE );
-			for ( j = i+1; j < this._length; j++ ) {
-				val = buf[ GETTER ]( j * BYTES_PER_ELEMENT, this._isLE );
-				if ( compareFcn( minVal, val ) > 0 ) {
-					minIdx = j;
-					minVal = val;
-				}
-			}
-			if ( i !== minIdx ) {
-				buf[ SETTER ]( minIdx * BYTES_PER_ELEMENT, buf[ GETTER ]( i * BYTES_PER_ELEMENT, this._isLE ), this._isLE );
-				buf[ SETTER ]( i * BYTES_PER_ELEMENT, minVal, this._isLE );
-			}
-		}
-		return this;
-	});
 
 	/**
 	* Returns a new array containing the elements of an array which pass a test implemented by a predicate function.
@@ -1101,6 +1047,53 @@ function factory( dtype ) { // eslint-disable-line max-lines-per-function, stdli
 		return false;
 	});
 
+	/**
+	* Sorts an array in-place.
+	*
+	* @private
+	* @name sort
+	* @memberof TypedArray.prototype
+	* @type {Function}
+	* @param {Function} [compareFcn] - comparison function
+	* @throws {TypeError} `this` must be a typed array
+	* @throws {TypeError} first argument must be a function
+	* @returns {TypedArray} sorted array
+	*/
+	setReadOnly( TypedArray.prototype, 'sort', function sort( compareFcn ) {
+		var tmp;
+		var buf;
+		var len;
+		var i;
+
+		if ( !isTypedArray( this ) ) {
+			throw new TypeError( format( 'invalid invocation. `this` is not %s %s.', CHAR2ARTICLE[ dtype[0] ], CTOR_NAME ) );
+		}
+		tmp = [];
+		len = this._length;
+		buf = this._buffer;
+		for ( i = 0; i < len; i++ ) {
+			tmp.push( buf[ GETTER ]( i * BYTES_PER_ELEMENT, this._isLE ) );
+		}
+		// If compare function is not provided
+		if ( arguments.length === 0 ) {
+			tmp.sort();
+			for ( i = 0; i < len; i++ ) {
+				buf[ SETTER ]( i * BYTES_PER_ELEMENT, tmp[ i ], this._isLE );
+			}
+			return this;
+		}
+		if ( !isFunction( compareFcn ) ) {
+			throw new TypeError( format( 'invalid argument. First argument must be a function. Value: `%s`.', compareFcn ) );
+		}
+
+		tmp.sort( compareFcn );
+		for ( i = 0; i < len; i++ ) {
+			buf[ SETTER ]( i * BYTES_PER_ELEMENT, tmp[ i ], this._isLE );
+		}
+
+		return this;
+	});
+
 	/**
 	* Serializes an array as a string.
 	*