chore: stuff from code review

aayush0325 · aayush0325 · commit 603897bb2784 · 2024-11-17T07:37:35.000+05:30
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/README.md b/lib/node_modules/@stdlib/math/base/special/cinvf/README.md
@@ -60,10 +60,10 @@ var v = cinvf( new Complex64( 2.0, 4.0 ) );
 // returns <Complex64>
 
 var re = real( v );
-// returns 0.10000000149011612
+// returns ~0.1
 
 var im = imag( v );
-// returns -0.20000000298023224
+// returns ~-0.2
 ```
 
 </section>
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/benchmark/benchmark.js b/lib/node_modules/@stdlib/math/base/special/cinvf/benchmark/benchmark.js
@@ -24,8 +24,8 @@ var bench = require( '@stdlib/bench' );
 var uniform = require( '@stdlib/random/base/uniform' );
 var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
 var Complex64 = require( '@stdlib/complex/float32/ctor' );
-var real = require( '@stdlib/complex/float64/real' );
-var imag = require( '@stdlib/complex/float64/imag' );
+var real = require( '@stdlib/complex/float32/real' );
+var imag = require( '@stdlib/complex/float32/imag' );
 var pkg = require( './../package.json' ).name;
 var cinvf = require( './../lib' );
 
@@ -44,7 +44,7 @@ bench( pkg, function benchmark( b ) {
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		y = cinvf( values[ i%values.length ] );
+		y = cinvf( values[ i % values.length ] );
 		if ( isnanf( real( y ) ) ) {
 			b.fail( 'should not return NaN' );
 		}
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/benchmark/benchmark.native.js b/lib/node_modules/@stdlib/math/base/special/cinvf/benchmark/benchmark.native.js
@@ -53,7 +53,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		y = cinvf( values[ i%values.length ] );
+		y = cinvf( values[ i % values.length ] );
 		if ( isnanf( real( y ) ) ) {
 			b.fail( 'should not return NaN' );
 		}
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/benchmark/julia/REQUIRE b/lib/node_modules/@stdlib/math/base/special/cinvf/benchmark/julia/REQUIRE
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/benchmark/julia/benchmark.jl b/lib/node_modules/@stdlib/math/base/special/cinvf/benchmark/julia/benchmark.jl
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/examples/index.js b/lib/node_modules/@stdlib/math/base/special/cinvf/examples/index.js
@@ -29,6 +29,5 @@ var i;
 for ( i = 0; i < 100; i++ ) {
 	z1 = new Complex64( uniform( -50.0, 50.0 ), uniform( -50.0, 50.0 ) );
 	z2 = cinvf( z1 );
-
 	console.log( '1.0 / (%s) = %s', z1.toString(), z2.toString() );
 }
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/lib/index.js b/lib/node_modules/@stdlib/math/base/special/cinvf/lib/index.js
@@ -33,10 +33,10 @@
 * // returns <Complex64>
 *
 * var re = real( v );
-* // returns 0.10000000149011612
+* // returns ~0.1
 *
 * var im = imag( v );
-* // returns -0.20000000298023224
+* // returns ~-0.2
 */
 
 // MODULES //
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/lib/main.js b/lib/node_modules/@stdlib/math/base/special/cinvf/lib/main.js
@@ -58,10 +58,10 @@ var RECIP_EPS_SQR = 2.0 / ( EPS * EPS );
 * // returns <Complex64>
 *
 * var re = real( v );
-* // returns 0.10000000149011612
+* // returns ~0.1
 *
 * var im = imag( v );
-* // returns -0.20000000298023224
+* // returns ~-0.2
 */
 function cinvf( z ) {
 	var ab;
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/lib/native.js b/lib/node_modules/@stdlib/math/base/special/cinvf/lib/native.js
@@ -42,10 +42,10 @@ var addon = require( './../src/addon.node' );
 * // returns <Complex64>
 *
 * var re = real( v );
-* // returns 0.10000000149011612
+* // returns ~0.1
 *
 * var im = imag( v );
-* // returns -0.20000000298023224
+* // returns ~-0.2
 */
 function cinvf( z ) {
 	var v = addon( z );
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/src/main.c b/lib/node_modules/@stdlib/math/base/special/cinvf/src/main.c
@@ -24,7 +24,6 @@
 #include "stdlib/constants/float32/smallest_normal.h"
 #include "stdlib/complex/float32/ctor.h"
 #include "stdlib/complex/float32/reim.h"
-#include <math.h>
 
 
 // VARIABLES //
@@ -37,7 +36,7 @@ static const float RECIP_EPS_SQR = 2.0f / ( STDLIB_CONSTANT_FLOAT32_EPS * STDLIB
 // MAIN //
 
 /**
-Computes the inverse of a single-precision complex floating-point number.
+* Computes the inverse of a single-precision complex floating-point number.
 *
 * ## References
 *
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/test/test.js b/lib/node_modules/@stdlib/math/base/special/cinvf/test/test.js
@@ -27,6 +27,8 @@ var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
 var absf = require( '@stdlib/math/base/special/absf' );
 var EPS = require( '@stdlib/constants/float32/eps' );
 var FLOAT32_SMALLEST_NORMAL = require( '@stdlib/constants/float32/smallest-normal' );
+var HUGE = 1e37;
+var TINY = -1e37;
 var Complex64 = require( '@stdlib/complex/float32/ctor' );
 var real = require( '@stdlib/complex/float32/real' );
 var imag = require( '@stdlib/complex/float32/imag' );
@@ -388,40 +390,38 @@ tape( 'the function computes a complex inverse (tiny positive real components)',
 });
 
 tape( 'the function may produce very large values for very small inputs', function test( t ) {
-	var huge = 1e37;
-	var tiny = -1e37;
 	var v;
 
 	v = cinvf( new Complex64( FLOAT32_SMALLEST_NORMAL, FLOAT32_SMALLEST_NORMAL ) ); // eslint-disable-line max-len
-	t.ok( real( v ) > huge, 'returns expected value.' );
-	t.ok( imag( v ) < tiny, 'returns expected value.' );
+	t.ok( real( v ) > HUGE, 'returns expected value.' );
+	t.ok( imag( v ) < TINY, 'returns expected value.' );
 
 	v = cinvf( new Complex64( -FLOAT32_SMALLEST_NORMAL, FLOAT32_SMALLEST_NORMAL ) ); // eslint-disable-line max-len
-	t.ok( real( v ) < tiny, 'returns expected value.' );
-	t.ok( imag( v ) < tiny, 'returns expected value.' );
+	t.ok( real( v ) < TINY, 'returns expected value.' );
+	t.ok( imag( v ) < TINY, 'returns expected value.' );
 
 	v = cinvf( new Complex64( -FLOAT32_SMALLEST_NORMAL, -FLOAT32_SMALLEST_NORMAL ) ); // eslint-disable-line max-len
-	t.ok( real( v ) < tiny, 'returns expected value.' );
-	t.ok( imag( v ) > huge, 'returns expected value.' );
+	t.ok( real( v ) < TINY, 'returns expected value.' );
+	t.ok( imag( v ) > HUGE, 'returns expected value.' );
 
 	v = cinvf( new Complex64( FLOAT32_SMALLEST_NORMAL, -FLOAT32_SMALLEST_NORMAL ) ); // eslint-disable-line max-len
-	t.ok( real( v ) > huge, 'returns expected value.' );
-	t.ok( imag( v ) > huge, 'returns expected value.' );
+	t.ok( real( v ) > HUGE, 'returns expected value.' );
+	t.ok( imag( v ) > HUGE, 'returns expected value.' );
 
 	v = cinvf( new Complex64( 0.0, FLOAT32_SMALLEST_NORMAL ) );
 	t.strictEqual( real( v ), 0.0, 'returns expected value.' );
-	t.ok( imag( v ) < tiny, 'returns expected value.' );
+	t.ok( imag( v ) < TINY, 'returns expected value.' );
 
 	v = cinvf( new Complex64( 0.0, -FLOAT32_SMALLEST_NORMAL ) );
 	t.strictEqual( real( v ), 0.0, 'returns expected value.' );
-	t.ok( imag( v ) > huge, 'returns expected value.' );
+	t.ok( imag( v ) > HUGE, 'returns expected value.' );
 
 	v = cinvf( new Complex64( FLOAT32_SMALLEST_NORMAL, 0.0 ) );
-	t.ok( real( v ) > huge, 'returns expected value.' );
+	t.ok( real( v ) > HUGE, 'returns expected value.' );
 	t.strictEqual( imag( v ), 0.0, 'returns expected value.' );
 
 	v = cinvf( new Complex64( -FLOAT32_SMALLEST_NORMAL, 0.0 ) );
-	t.ok( real( v ) < tiny, 'returns expected value.' );
+	t.ok( real( v ) < TINY, 'returns expected value.' );
 	t.strictEqual( imag( v ), 0.0, 'returns expected value.' );
 
 	t.end();
diff --git a/lib/node_modules/@stdlib/math/base/special/cinvf/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/cinvf/test/test.native.js
@@ -27,6 +27,8 @@ var tape = require( 'tape' );
 var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
 var absf = require( '@stdlib/math/base/special/absf' );
 var EPS = require( '@stdlib/constants/float32/eps' );
+var HUGE = 1e37;
+var TINY = -1e37;
 var FLOAT32_SMALLEST_NORMAL = require( '@stdlib/constants/float32/smallest-normal' );
 var Complex64 = require( '@stdlib/complex/float32/ctor' );
 var real = require( '@stdlib/complex/float32/real' );
@@ -397,40 +399,38 @@ tape( 'the function computes a complex inverse (tiny positive real components)',
 });
 
 tape( 'the function may produce very large values for very small inputs', opts, function test( t ) {
-	var huge = 1e37;
-	var tiny = -1e37;
 	var v;
 
 	v = cinvf( new Complex64( FLOAT32_SMALLEST_NORMAL, FLOAT32_SMALLEST_NORMAL ) ); // eslint-disable-line max-len
-	t.ok( real( v ) > huge, 'returns expected value.' );
-	t.ok( imag( v ) < tiny, 'returns expected value.' );
+	t.ok( real( v ) > HUGE, 'returns expected value.' );
+	t.ok( imag( v ) < TINY, 'returns expected value.' );
 
 	v = cinvf( new Complex64( -FLOAT32_SMALLEST_NORMAL, FLOAT32_SMALLEST_NORMAL ) ); // eslint-disable-line max-len
-	t.ok( real( v ) < tiny, 'returns expected value.' );
-	t.ok( imag( v ) < tiny, 'returns expected value.' );
+	t.ok( real( v ) < TINY, 'returns expected value.' );
+	t.ok( imag( v ) < TINY, 'returns expected value.' );
 
 	v = cinvf( new Complex64( -FLOAT32_SMALLEST_NORMAL, -FLOAT32_SMALLEST_NORMAL ) ); // eslint-disable-line max-len
-	t.ok( real( v ) < tiny, 'returns expected value.' );
-	t.ok( imag( v ) > huge, 'returns expected value.' );
+	t.ok( real( v ) < TINY, 'returns expected value.' );
+	t.ok( imag( v ) > HUGE, 'returns expected value.' );
 
 	v = cinvf( new Complex64( FLOAT32_SMALLEST_NORMAL, -FLOAT32_SMALLEST_NORMAL ) ); // eslint-disable-line max-len
-	t.ok( real( v ) > huge, 'returns expected value.' );
-	t.ok( imag( v ) > huge, 'returns expected value.' );
+	t.ok( real( v ) > HUGE, 'returns expected value.' );
+	t.ok( imag( v ) > HUGE, 'returns expected value.' );
 
 	v = cinvf( new Complex64( 0.0, FLOAT32_SMALLEST_NORMAL ) );
 	t.strictEqual( real( v ), 0.0, 'returns expected value.' );
-	t.ok( imag( v ) < tiny, 'returns expected value.' );
+	t.ok( imag( v ) < TINY, 'returns expected value.' );
 
 	v = cinvf( new Complex64( 0.0, -FLOAT32_SMALLEST_NORMAL ) );
 	t.strictEqual( real( v ), 0.0, 'returns expected value.' );
-	t.ok( imag( v ) > huge, 'returns expected value.' );
+	t.ok( imag( v ) > HUGE, 'returns expected value.' );
 
 	v = cinvf( new Complex64( FLOAT32_SMALLEST_NORMAL, 0.0 ) );
-	t.ok( real( v ) > huge, 'returns expected value.' );
+	t.ok( real( v ) > HUGE, 'returns expected value.' );
 	t.strictEqual( imag( v ), 0.0, 'returns expected value.' );
 
 	v = cinvf( new Complex64( -FLOAT32_SMALLEST_NORMAL, 0.0 ) );
-	t.ok( real( v ) < tiny, 'returns expected value.' );
+	t.ok( real( v ) < TINY, 'returns expected value.' );
 	t.strictEqual( imag( v ), 0.0, 'returns expected value.' );
 
 	t.end();

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {`
`53`	`53`
`54`	`54`	`b.tic();`
`55`	`55`	`for ( i = 0; i < b.iterations; i++ ) {`
`56`		`- y = cinvf( values[ i%values.length ] );`
	`56`	`+ y = cinvf( values[ i % values.length ] );`
`57`	`57`	`if ( isnanf( real( y ) ) ) {`
`58`	`58`	`b.fail( 'should not return NaN' );`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,5 @@ var i;`
`29`	`29`	`for ( i = 0; i < 100; i++ ) {`
`30`	`30`	`z1 = new Complex64( uniform( -50.0, 50.0 ), uniform( -50.0, 50.0 ) );`
`31`	`31`	`z2 = cinvf( z1 );`
`32`		`-`
`33`	`32`	`console.log( '1.0 / (%s) = %s', z1.toString(), z2.toString() );`
`34`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,10 +33,10 @@`
`33`	`33`	`* // returns <Complex64>`
`34`	`34`	`*`
`35`	`35`	`* var re = real( v );`
`36`		`-* // returns 0.10000000149011612`
	`36`	`+* // returns ~0.1`
`37`	`37`	`*`
`38`	`38`	`* var im = imag( v );`
`39`		`-* // returns -0.20000000298023224`
	`39`	`+* // returns ~-0.2`
`40`	`40`	`*/`
`41`	`41`
`42`	`42`	`// MODULES //`
Original file line number	Diff line number	Diff line change
`@@ -58,10 +58,10 @@ var RECIP_EPS_SQR = 2.0 / ( EPS * EPS );`
`58`	`58`	`* // returns <Complex64>`
`59`	`59`	`*`
`60`	`60`	`* var re = real( v );`
`61`		`-* // returns 0.10000000149011612`
	`61`	`+* // returns ~0.1`
`62`	`62`	`*`
`63`	`63`	`* var im = imag( v );`
`64`		`-* // returns -0.20000000298023224`
	`64`	`+* // returns ~-0.2`
`65`	`65`	`*/`
`66`	`66`	`function cinvf( z ) {`
`67`	`67`	`var ab;`
Original file line number	Diff line number	Diff line change
`@@ -42,10 +42,10 @@ var addon = require( './../src/addon.node' );`
`42`	`42`	`* // returns <Complex64>`
`43`	`43`	`*`
`44`	`44`	`* var re = real( v );`
`45`		`-* // returns 0.10000000149011612`
	`45`	`+* // returns ~0.1`
`46`	`46`	`*`
`47`	`47`	`* var im = imag( v );`
`48`		`-* // returns -0.20000000298023224`
	`48`	`+* // returns ~-0.2`
`49`	`49`	`*/`
`50`	`50`	`function cinvf( z ) {`
`51`	`51`	`var v = addon( z );`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@`
`24`	`24`	`#include "stdlib/constants/float32/smallest_normal.h"`
`25`	`25`	`#include "stdlib/complex/float32/ctor.h"`
`26`	`26`	`#include "stdlib/complex/float32/reim.h"`
`27`		`-#include <math.h>`
`28`	`27`
`29`	`28`
`30`	`29`	`// VARIABLES //`
`@@ -37,7 +36,7 @@ static const float RECIP_EPS_SQR = 2.0f / ( STDLIB_CONSTANT_FLOAT32_EPS * STDLIB`
`37`	`36`	`// MAIN //`
`38`	`37`
`39`	`38`	`/**`
`40`		`-Computes the inverse of a single-precision complex floating-point number.`
	`39`	`+* Computes the inverse of a single-precision complex floating-point number.`
`41`	`40`	`*`
`42`	`41`	`* ## References`
`43`	`42`	`*`