Skip to content

Commit 79f6ac4

Browse files
committed
fix: accumulate in the default real-valued floating-point dtype
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent e4a213e commit 79f6ac4

File tree

2 files changed

+13
-9
lines changed
  • lib/node_modules/@stdlib/ndarray/base/unary-output-dtype

2 files changed

+13
-9
lines changed

lib/node_modules/@stdlib/ndarray/base/unary-output-dtype/lib/main.js

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,15 @@
1616
* limitations under the License.
1717
*/
1818

19+
/* eslint-disable id-length */
20+
1921
'use strict';
2022

2123
// MODULES //
2224

2325
var isFloatingPointDataType = require( '@stdlib/ndarray/base/assert/is-floating-point-data-type' );
24-
var isRealFloatingPointDataType = require( '@stdlib/ndarray/base/assert/is-real-floating-point-data-type' ); // eslint-disable-line id-length
25-
var isComplexFloatingPointDataType = require( '@stdlib/ndarray/base/assert/is-complex-floating-point-data-type' ); // eslint-disable-line id-length
26+
var isRealFloatingPointDataType = require( '@stdlib/ndarray/base/assert/is-real-floating-point-data-type' );
27+
var isComplexFloatingPointDataType = require( '@stdlib/ndarray/base/assert/is-complex-floating-point-data-type' );
2628
var isIntegerDataType = require( '@stdlib/ndarray/base/assert/is-integer-data-type' );
2729
var isSignedIntegerDataType = require( '@stdlib/ndarray/base/assert/is-signed-integer-data-type' );
2830
var isUnsignedIntegerDataType = require( '@stdlib/ndarray/base/assert/is-unsigned-integer-data-type' );
@@ -42,8 +44,9 @@ var format = require( '@stdlib/string/format' );
4244

4345
var DEFAULT_DTYPE = defaults.get( 'dtypes.default' );
4446
var DEFAULT_INDEX_DTYPE = defaults.get( 'dtypes.default_index' );
45-
var DEFAULT_SIGNED_INTEGER_DTYPE = defaults.get( 'dtypes.signed_integer' ); // eslint-disable-line id-length
46-
var DEFAULT_UNSIGNED_INTEGER_DTYPE = defaults.get( 'dtypes.unsigned_integer' ); // eslint-disable-line id-length
47+
var DEFAULT_SIGNED_INTEGER_DTYPE = defaults.get( 'dtypes.signed_integer' );
48+
var DEFAULT_UNSIGNED_INTEGER_DTYPE = defaults.get( 'dtypes.unsigned_integer' );
49+
var DEFAULT_REAL_FLOATING_POINT_DTYPE = defaults.get( 'dtypes.real_floating_point' );
4750

4851
var POLICY_TABLE = {
4952
'floating_point': [
@@ -56,11 +59,11 @@ var POLICY_TABLE = {
5659
],
5760
'real_floating_point': [
5861
isRealFloatingPointDataType,
59-
defaults.get( 'dtypes.real_floating_point' )
62+
DEFAULT_REAL_FLOATING_POINT_DTYPE
6063
],
6164
'real_floating_point_and_generic': [
6265
wrap( isRealFloatingPointDataType ),
63-
defaults.get( 'dtypes.real_floating_point' )
66+
DEFAULT_REAL_FLOATING_POINT_DTYPE
6467
],
6568
'complex_floating_point': [
6669
isComplexFloatingPointDataType,
@@ -215,8 +218,8 @@ function resolve( dtype, policy ) {
215218
if ( isSignedIntegerDataType( dtype ) ) {
216219
return promotionRules( dtype, DEFAULT_SIGNED_INTEGER_DTYPE );
217220
}
218-
// For all other input data types, accumulate in the default signed integer data type...
219-
return DEFAULT_SIGNED_INTEGER_DTYPE;
221+
// For all other input data types, accumulate in the default real-valued floating-point data type...
222+
return DEFAULT_REAL_FLOATING_POINT_DTYPE;
220223
}
221224
p = POLICY_TABLE[ policy ];
222225
if ( p === void 0 ) {

lib/node_modules/@stdlib/ndarray/base/unary-output-dtype/test/test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -939,6 +939,7 @@ tape( 'the function resolves an output data type (policy=accumulation)', functio
939939
'bool'
940940
];
941941

942+
dt = defaults.get( 'dtypes.real_floating_point' );
942943
expected = [
943944
'float64',
944945
'float32',
@@ -947,7 +948,7 @@ tape( 'the function resolves an output data type (policy=accumulation)', functio
947948
'generic',
948949
'int32',
949950
'complex64',
950-
'int32'
951+
dt
951952
];
952953
for ( i = 0; i < values.length; i++ ) {
953954
dt = resolve( values[ i ], 'accumulation' );

0 commit comments

Comments
 (0)