fix: resolve ESLint errors by replacing new Array()

AlyAbdelmoneim · kgryte · web-flow · commit 7f639d31e561 · 2025-03-17T01:13:21.000-07:00
PR-URL: #6033 Closes: #6032 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Athan Reines <kgryte@gmail.com>
diff --git a/lib/node_modules/@stdlib/_tools/github/rank-followers/lib/pipeline.js b/lib/node_modules/@stdlib/_tools/github/rank-followers/lib/pipeline.js
@@ -40,9 +40,9 @@ function toArray( obj ) {
 	var out;
 	var i;
 	keys = objectKeys( obj );
-	out = new Array( keys.length );
+	out = [];
 	for ( i = 0; i < keys.length; i++ ) {
-		out[ i ] = obj[ keys[i] ];
+		out.push( obj[ keys[ i ] ] );
 	}
 	return out;
 }
@@ -78,9 +78,9 @@ function pipeline( opts, clbk ) {
 		if ( error ) {
 			return done( error );
 		}
-		usernames = new Array( data.length );
+		usernames = [];
 		for ( i = 0; i < data.length; i++ ) {
-			usernames[ i ] = data[ i ].login;
+			usernames.push( data[ i ].login );
 		}
 		options = {
 			'useragent': opts.useragent,

Original file line number	Diff line number	Diff line change
`@@ -40,9 +40,9 @@ function toArray( obj ) {`
`40`	`40`	`var out;`
`41`	`41`	`var i;`
`42`	`42`	`keys = objectKeys( obj );`
`43`		`- out = new Array( keys.length );`
	`43`	`+ out = [];`
`44`	`44`	`for ( i = 0; i < keys.length; i++ ) {`
`45`		`- out[ i ] = obj[ keys[i] ];`
	`45`	`+ out.push( obj[ keys[ i ] ] );`
`46`	`46`	`}`
`47`	`47`	`return out;`
`48`	`48`	`}`
`@@ -78,9 +78,9 @@ function pipeline( opts, clbk ) {`
`78`	`78`	`if ( error ) {`
`79`	`79`	`return done( error );`
`80`	`80`	`}`
`81`		`- usernames = new Array( data.length );`
	`81`	`+ usernames = [];`
`82`	`82`	`for ( i = 0; i < data.length; i++ ) {`
`83`		`- usernames[ i ] = data[ i ].login;`
	`83`	`+ usernames.push( data[ i ].login );`
`84`	`84`	`}`
`85`	`85`	`options = {`
`86`	`86`	`'useragent': opts.useragent,`