fix: avoid flattening due to user callback

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: kgryte

lib/node_modules/@stdlib/ndarray/base/every-by/lib/main.js

@@ -21,8 +21,8 @@
 // MODULES //
 
 var iterationOrder = require( '@stdlib/ndarray/base/iteration-order' );
-var minmaxViewBufferIndex = require( '@stdlib/ndarray/base/minmax-view-buffer-index' );
 var ndarray2object = require( '@stdlib/ndarray/base/ndarraylike2object' );
+var numel = require( '@stdlib/ndarray/base/numel' );
 var blockedaccessorevery2d = require( './2d_blocked_accessors.js' );
 var blockedaccessorevery3d = require( './3d_blocked_accessors.js' );
 var blockedaccessorevery4d = require( './4d_blocked_accessors.js' );
@@ -138,7 +138,7 @@ var MAX_DIMS = EVERY.length - 1;
 *
 * @param {ArrayLikeObject<Object>} arrays - array-like object containing one input array
 * @param {Function} clbk - callback function
-* @param {thisArg} thisArg - callback execution context
+* @param {thisArg} [thisArg] - callback execution context
 * @returns {boolean} result
 *
 * @example
@@ -176,18 +176,11 @@ var MAX_DIMS = EVERY.length - 1;
 * // returns true
 */
 function everyBy( arrays, clbk, thisArg ) {
-	var isCmplx;
 	var ndims;
-	var xmmv;
 	var shx;
 	var iox;
 	var len;
-	var sx;
-	var ox;
-	var ns;
 	var x;
-	var d;
-	var i;
 
 	// Unpack the ndarray and standardize ndarray meta data:
 	x = ndarray2object( arrays[ 0 ] );
@@ -201,20 +194,9 @@ function everyBy( arrays, clbk, thisArg ) {
 		}
 		return EVERY[ ndims ]( x, clbk, thisArg );
 	}
-	// Compute the number of elements and the number of singleton dimensions...
-	len = 1; // number of elements
-	ns = 0;  // number of singleton dimensions
-	for ( i = 0; i < ndims; i++ ) {
-		d = shx[ i ];
+	// Compute the number of elements:
+	len = numel( shx );
 
-		// Note that, if one of the dimensions is `0`, the length will be `0`...
-		len *= d;
-
-		// Check whether the current dimension is a singleton dimension...
-		if ( d === 1 ) {
-			ns += 1;
-		}
-	}
 	// Check whether we were provided an empty ndarray...
 	if ( len === 0 ) {
 		return true;
@@ -226,48 +208,11 @@ function everyBy( arrays, clbk, thisArg ) {
 		}
 		return EVERY[ ndims ]( x, clbk, thisArg );
 	}
-	sx = x.strides;
-
-	// Determine whether the ndarray has only **one** non-singleton dimension (e.g., ndims=4, shape=[10,1,1,1]) so that we can treat an ndarray as being equivalent to a one-dimensional strided array...
-	if ( ns === ndims-1 ) {
-		// Get the index of the non-singleton dimension...
-		for ( i = 0; i < ndims; i++ ) {
-			if ( shx[ i ] !== 1 ) {
-				break;
-			}
-		}
-		x.shape = [ shx[i] ];
-		x.strides = [ sx[i] ];
-		if ( x.accessorProtocol ) {
-			return ACCESSOR_EVERY[ 1 ]( x, clbk, thisArg );
-		}
-		return EVERY[ 1 ]( x, clbk, thisArg );
-	}
-	iox = iterationOrder( sx ); // +/-1
+	// Determine the iteration order:
+	iox = iterationOrder( x.strides ); // +/-1
 
 	// Determine whether we can avoid blocked iteration...
 	if ( iox !== 0 ) {
-		// Determine the minimum and maximum linear indices which are accessible by the array view:
-		xmmv = minmaxViewBufferIndex( shx, sx, x.offset );
-
-		// Determine whether we can ignore shape (and strides) and treat the ndarray as a linear one-dimensional strided array...
-		if ( len === ( xmmv[1]-xmmv[0]+1 ) || ( isCmplx && len*2 === ( xmmv[1]-xmmv[0]+1 ) ) ) { // eslint-disable-line max-len
-			// Note: the above is equivalent to @stdlib/ndarray/base/assert/is-contiguous, but in-lined so we can retain computed values...
-			if ( iox === 1 ) {
-				ox = xmmv[ 0 ];
-			} else {
-				ox = xmmv[ 1 ];
-			}
-			x.shape = [ len ];
-			x.strides = [ ( isCmplx ) ? iox*2 : iox ];
-			x.offset = ox;
-			if ( x.accessorProtocol ) {
-				return ACCESSOR_EVERY[ 1 ]( x, clbk, thisArg );
-			}
-			return EVERY[ 1 ]( x, clbk, thisArg );
-		}
-		// The ndarray is non-contiguous, so we cannot directly use one-dimensional array functionality...
-
 		// Determine whether we can use simple nested loops...
 		if ( ndims <= MAX_DIMS ) {
 			// So long as iteration always moves in the same direction (i.e., no mixed sign strides), we can leverage cache-optimal (i.e., normal) nested loops without resorting to blocked iteration...
@@ -278,8 +223,6 @@ function everyBy( arrays, clbk, thisArg ) {
 		}
 		// Fall-through to blocked iteration...
 	}
-	// At this point, we're either dealing with a non-contiguous n-dimensional array or a high dimensional n-dimensional array, so our only hope is that we can still perform blocked iteration...
-
 	// Determine whether we can perform blocked iteration...
 	if ( ndims <= MAX_DIMS ) {
 		if ( x.accessorProtocol ) {