Skip to content

Commit 8612da3

Browse files
headlessNodeheadlessNode
committed
fix: apply suggestions form code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 7261c9d commit 8612da3

File tree

1 file changed

+26
-28
lines changed

1 file changed

+26
-28
lines changed

‎lib/node_modules/@stdlib/blas/ext/last-index-of/test/test.assign.js‎

Lines changed: 26 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,13 @@
2222

2323
var tape = require( 'tape' );
2424
var isndarrayLike = require( '@stdlib/assert/is-ndarray-like' );
25-
var isSameArray = require( '@stdlib/assert/is-same-array' );
2625
var ndarray = require( '@stdlib/ndarray/ctor' );
2726
var zeros = require( '@stdlib/ndarray/zeros' );
2827
var ndarray2array = require( '@stdlib/ndarray/to-array' );
2928
var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
3029
var getDType = require( '@stdlib/ndarray/dtype' );
3130
var getShape = require( '@stdlib/ndarray/shape' );
3231
var getOrder = require( '@stdlib/ndarray/order' );
33-
var getData = require( '@stdlib/ndarray/data-buffer' );
3432
var lastIndexOf = require( './../lib' ).assign;
3533

3634

@@ -1059,13 +1057,13 @@ tape( 'the function returns the first index of a specified search element in an
10591057
});
10601058

10611059
actual = lastIndexOf( x, 2.0, y );
1062-
expected = [ 1, 1 ];
1060+
expected = [ -1, -1 ];
10631061

10641062
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
10651063
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
10661064
t.deepEqual( getShape( actual ), [ 2 ], 'returns expected value' );
10671065
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
1068-
t.strictEqual( isSameArray( getData( actual ), expected ), true, 'returns expected value' );
1066+
t.deepEqual( ndarray2array( actual ), expected, 'returns expected value' );
10691067
t.strictEqual( ( y === actual ), true, 'returns expected value' );
10701068

10711069
y = zeros( [ 2 ], {
@@ -1074,13 +1072,13 @@ tape( 'the function returns the first index of a specified search element in an
10741072
});
10751073

10761074
actual = lastIndexOf( x, 2.0, 0, y );
1077-
expected = [ 1, 1 ];
1075+
expected = [ -1, -1 ];
10781076

10791077
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
10801078
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
10811079
t.deepEqual( getShape( actual ), [ 2 ], 'returns expected value' );
10821080
t.strictEqual( getOrder( actual ), getOrder( x ), 'returns expected value' );
1083-
t.strictEqual( isSameArray( getData( actual ), expected ), true, 'returns expected value' );
1081+
t.deepEqual( ndarray2array( actual ), expected, 'returns expected value' );
10841082
t.strictEqual( ( y === actual ), true, 'returns expected value' );
10851083

10861084
t.end();
@@ -1101,7 +1099,7 @@ tape( 'the function returns the first index of a specified search element in an
11011099
});
11021100

11031101
actual = lastIndexOf( x, 2.0, y );
1104-
expected = [ -1, 1 ];
1102+
expected = [ -1, 0 ];
11051103

11061104
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
11071105
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1116,7 +1114,7 @@ tape( 'the function returns the first index of a specified search element in an
11161114
});
11171115

11181116
actual = lastIndexOf( x, 2.0, 0, y );
1119-
expected = [ -1, 1 ];
1117+
expected = [ -1, 0 ];
11201118

11211119
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
11221120
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1145,7 +1143,7 @@ tape( 'the function supports specifying an operation dimension (row-major)', fun
11451143
actual = lastIndexOf( x, 2.0, y, {
11461144
'dim': 0
11471145
});
1148-
expected = [ -1, 1 ];
1146+
expected = [ -1, 0 ];
11491147

11501148
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
11511149
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1162,7 +1160,7 @@ tape( 'the function supports specifying an operation dimension (row-major)', fun
11621160
actual = lastIndexOf( x, 2.0, 0, y, {
11631161
'dim': 0
11641162
});
1165-
expected = [ -1, 1 ];
1163+
expected = [ -1, 0 ];
11661164

11671165
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
11681166
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1181,7 +1179,7 @@ tape( 'the function supports specifying an operation dimension (row-major)', fun
11811179
actual = lastIndexOf( x, 2.0, y, {
11821180
'dim': 1
11831181
});
1184-
expected = [ 1, 1 ];
1182+
expected = [ -1, -1 ];
11851183

11861184
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
11871185
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1198,7 +1196,7 @@ tape( 'the function supports specifying an operation dimension (row-major)', fun
11981196
actual = lastIndexOf( x, 2.0, 0, y, {
11991197
'dim': 1
12001198
});
1201-
expected = [ 1, 1 ];
1199+
expected = [ -1, -1 ];
12021200

12031201
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
12041202
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1227,7 +1225,7 @@ tape( 'the function supports specifying an operation dimension (column-major)',
12271225
actual = lastIndexOf( x, 2.0, y, {
12281226
'dim': 0
12291227
});
1230-
expected = [ 1, 1 ];
1228+
expected = [ -1, -1 ];
12311229

12321230
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
12331231
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1244,7 +1242,7 @@ tape( 'the function supports specifying an operation dimension (column-major)',
12441242
actual = lastIndexOf( x, 2.0, 0, y, {
12451243
'dim': 0
12461244
});
1247-
expected = [ 1, 1 ];
1245+
expected = [ -1, -1 ];
12481246

12491247
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
12501248
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1263,7 +1261,7 @@ tape( 'the function supports specifying an operation dimension (column-major)',
12631261
actual = lastIndexOf( x, 2.0, y, {
12641262
'dim': 1
12651263
});
1266-
expected = [ -1, 1 ];
1264+
expected = [ -1, 0 ];
12671265

12681266
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
12691267
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1280,7 +1278,7 @@ tape( 'the function supports specifying an operation dimension (column-major)',
12801278
actual = lastIndexOf( x, 2.0, 0, y, {
12811279
'dim': 1
12821280
});
1283-
expected = [ -1, 1 ];
1281+
expected = [ -1, 0 ];
12841282

12851283
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
12861284
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1312,7 +1310,7 @@ tape( 'the function supports providing a from index (scalar)', function test( t
13121310
});
13131311

13141312
actual = lastIndexOf( x, 2.0, 2, y );
1315-
expected = [ 3, 4 ];
1313+
expected = [ 1, 2 ];
13161314

13171315
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
13181316
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1335,7 +1333,7 @@ tape( 'the function supports providing a from index (scalar)', function test( t
13351333
});
13361334

13371335
actual = lastIndexOf( x, 2.0, 2, y );
1338-
expected = [ -1, 4 ];
1336+
expected = [ -1, 1 ];
13391337

13401338
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
13411339
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1367,7 +1365,7 @@ tape( 'the function supports providing a from index (scalar, options)', function
13671365
});
13681366

13691367
actual = lastIndexOf( x, 2.0, 2, y, {} );
1370-
expected = [ 3, 4 ];
1368+
expected = [ 1, 2 ];
13711369

13721370
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
13731371
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1390,7 +1388,7 @@ tape( 'the function supports providing a from index (scalar, options)', function
13901388
});
13911389

13921390
actual = lastIndexOf( x, 2.0, 2, y, {} );
1393-
expected = [ -1, 4 ];
1391+
expected = [ -1, 1 ];
13941392

13951393
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
13961394
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1426,7 +1424,7 @@ tape( 'the function supports providing a from index (0d ndarray)', function test
14261424
'dtype': 'generic'
14271425
});
14281426
actual = lastIndexOf( x, 2.0, fromIdx, y );
1429-
expected = [ 3, 4 ];
1427+
expected = [ 1, 2 ];
14301428

14311429
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
14321430
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1449,7 +1447,7 @@ tape( 'the function supports providing a from index (0d ndarray)', function test
14491447
});
14501448

14511449
actual = lastIndexOf( x, 2.0, fromIdx, y );
1452-
expected = [ -1, 4 ];
1450+
expected = [ -1, 1 ];
14531451

14541452
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
14551453
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1485,7 +1483,7 @@ tape( 'the function supports providing a from index (0d ndarray, options)', func
14851483
'dtype': 'generic'
14861484
});
14871485
actual = lastIndexOf( x, 2.0, fromIdx, y, {} );
1488-
expected = [ 3, 4 ];
1486+
expected = [ 1, 2 ];
14891487

14901488
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
14911489
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1508,7 +1506,7 @@ tape( 'the function supports providing a from index (0d ndarray, options)', func
15081506
});
15091507

15101508
actual = lastIndexOf( x, 2.0, fromIdx, y, {} );
1511-
expected = [ -1, 4 ];
1509+
expected = [ -1, 1 ];
15121510

15131511
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
15141512
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1545,7 +1543,7 @@ tape( 'the function supports providing a from index (scalar, broadcasted)', func
15451543
actual = lastIndexOf( x, 2.0, 2, y, {
15461544
'dim': 0
15471545
});
1548-
expected = [ -1, 4 ];
1546+
expected = [ -1, 1 ];
15491547

15501548
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
15511549
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1573,7 +1571,7 @@ tape( 'the function supports providing a from index (scalar, broadcasted)', func
15731571
actual = lastIndexOf( x, 2.0, 2, y, {
15741572
'dim': 0
15751573
});
1576-
expected = [ 3, 4 ];
1574+
expected = [ 1, 2 ];
15771575

15781576
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
15791577
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1614,7 +1612,7 @@ tape( 'the function supports providing a from index (0d ndarray, broadcasted)',
16141612
actual = lastIndexOf( x, 2.0, fromIdx, y, {
16151613
'dim': 0
16161614
});
1617-
expected = [ -1, 4 ];
1615+
expected = [ -1, 1 ];
16181616

16191617
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
16201618
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );
@@ -1642,7 +1640,7 @@ tape( 'the function supports providing a from index (0d ndarray, broadcasted)',
16421640
actual = lastIndexOf( x, 2.0, fromIdx, y, {
16431641
'dim': 0
16441642
});
1645-
expected = [ 3, 4 ];
1643+
expected = [ 1, 2 ];
16461644

16471645
t.strictEqual( isndarrayLike( actual ), true, 'returns expected value' );
16481646
t.strictEqual( getDType( actual ), 'generic', 'returns expected value' );

0 commit comments

Comments
 (0)