fix: prevent writing to read-only ndarrays

Author: kgryte

lib/node_modules/@stdlib/blas/dswap/lib/main.js

@@ -22,6 +22,7 @@
 
 var isFloat64ndarrayLike = require( '@stdlib/assert/is-float64ndarray-like' );
 var isNegativeInteger = require( '@stdlib/assert/is-negative-integer' ).isPrimitive;
+var isReadOnly = require( '@stdlib/ndarray/base/assert/is-read-only' );
 var hasEqualValues = require( '@stdlib/array/base/assert/has-equal-values-indexed' );
 var min = require( '@stdlib/math/base/special/fast/min' );
 var without = require( '@stdlib/array/base/without' );
@@ -47,6 +48,7 @@ var format = require( '@stdlib/string/format' );
 * @throws {TypeError} second argument must have at least one dimension
 * @throws {Error} both input arrays must have the same shape
 * @throws {RangeError} third argument is out-of-bounds
+* @throws {Error} cannot write to read-only array
 * @returns {ndarrayLike} `y`
 *
 * @example
@@ -84,6 +86,9 @@ function dswap( x, y ) {
 	if ( !isFloat64ndarrayLike( y ) ) {
 		throw new TypeError( format( 'invalid argument. Second argument must be an ndarray containing double-precision floating-point numbers. Value: `%s`.', y ) );
 	}
+	if ( isReadOnly( x ) || isReadOnly( y ) ) {
+		throw new Error( 'invalid argument. Cannot write to read-only array.' );
+	}
 	// Convert the input arrays to "base" ndarrays:
 	xc = ndarraylike2ndarray( x );
 	yc = ndarraylike2ndarray( y );

lib/node_modules/@stdlib/blas/dswap/test/test.js

@@ -109,6 +109,34 @@ tape( 'the function throws an error if provided a first argument which is not a
 	}
 });
 
+tape( 'the function throws an error if provided a first argument which is a read-only ndarray', function test( t ) {
+	var values;
+	var opts;
+	var i;
+
+	opts = {
+		'readonly': true
+	};
+
+	values = [
+		array( new Float64Array( 10 ), opts ),
+		array( new Float64Array( 5 ), opts )
+	];
+
+	for ( i = 0; i < values.length; i++ ) {
+		t.throws( badValue( values[ i ] ), Error, 'throws an error when provided ' + values[ i ] );
+	}
+	t.end();
+
+	function badValue( value ) {
+		var y = array( new Float64Array( value.length ) );
+
+		return function badValue() {
+			dswap( value, y );
+		};
+	}
+});
+
 tape( 'the function throws an error if provided a second argument which is not a non-zero-dimensional ndarray containing double-precision floating-point numbers', function test( t ) {
 	var values;
 	var i;
@@ -175,6 +203,34 @@ tape( 'the function throws an error if provided a second argument which is not a
 	}
 });
 
+tape( 'the function throws an error if provided a second argument which is a read-only ndarray', function test( t ) {
+	var values;
+	var opts;
+	var i;
+
+	opts = {
+		'readonly': true
+	};
+
+	values = [
+		array( new Float64Array( 10 ), opts ),
+		array( new Float64Array( 5 ), opts )
+	];
+
+	for ( i = 0; i < values.length; i++ ) {
+		t.throws( badValue( values[ i ] ), Error, 'throws an error when provided ' + values[ i ] );
+	}
+	t.end();
+
+	function badValue( value ) {
+		var x = array( new Float64Array( value.length ) );
+
+		return function badValue() {
+			dswap( x, value );
+		};
+	}
+});
+
 tape( 'the function throws an error if provided a third argument which is not a negative integer (vectors)', function test( t ) {
 	var values;
 	var i;