Refactor random number generation in JS benchmarks for stats/base/dists/triangular #4989

Resolves #4989

Author: AryanJ18

lib/node_modules/@stdlib/stats/base/dists/triangular/ctor/benchmark/benchmark.js

@@ -21,11 +21,12 @@
 // MODULES //
 
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var EPS = require( '@stdlib/constants/float64/eps' );
 var pkg = require( './../package.json' ).name;
 var Triangular = require( './../lib' );
+var uniform = require( '@stdlib/random/base/uniform' );
+var Float64Array = require( '@stdlib/array/float64' );
 
 
 // MAIN //
@@ -36,12 +37,23 @@ bench( pkg+'::instantiation', function benchmark( bm ) {
 	var b;
 	var c;
 	var i;
+	var as = new Float64Array(bm.iterations);
+	var bs = new Float64Array(bm.iterations);
+	var cs = new Float64Array(bm.iterations);
+	for( i = 0; i<bm.iterations; i++){
+		a = uniform(EPS , 10.0);
+		b = uniform(a + EPS , a + 10.0);
+		c = uniform(a , b);
+		as[i] = a;
+		bs[i] = b;
+		cs[i] = c;
+	}
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		a = ( randu() * 10.0 ) + EPS;
-		b = ( randu() * 10.0 ) + a + EPS;
-		c = ( randu() * ( b-a ) ) + a;
+		a = as[i];
+		b = bs[i];
+		c = cs[i];
 		dist = new Triangular( a, b, c );
 		if ( !( dist instanceof Triangular ) ) {
 			bm.fail( 'should return a distribution instance' );
@@ -98,7 +110,7 @@ bench( pkg+'::set:a', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		y = ( 100.0*randu() ) + EPS;
+		y = uniform(EPS , 100.0);
 		dist.a = y;
 		if ( dist.a !== y ) {
 			bm.fail( 'should return set value' );
@@ -155,7 +167,7 @@ bench( pkg+'::set:b', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		y = ( 100.0*randu() ) + c + EPS;
+		y = uniform(EPS+c , 100.0+c+EPS);
 		dist.b = y;
 		if ( dist.b !== y ) {
 			bm.fail( 'should return set value' );
@@ -212,7 +224,7 @@ bench( pkg+'::set:c', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		y = ( randu() * ( b-a ) ) + a;
+		y = uniform(a , b);
 		dist.c = y;
 		if ( dist.c !== y ) {
 			bm.fail( 'should return set value' );
@@ -241,7 +253,7 @@ bench( pkg+':entropy', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		dist.a = randu() * c;
+		dist.a = uniform(0,c);
 		y = dist.entropy;
 		if ( isnan( y ) ) {
 			bm.fail( 'should not return NaN' );
@@ -270,7 +282,7 @@ bench( pkg+':kurtosis', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		dist.a = randu() * c;
+		dist.a = uniform(0.0 , c);
 		y = dist.kurtosis;
 		if ( isnan( y ) ) {
 			bm.fail( 'should not return NaN' );
@@ -299,7 +311,7 @@ bench( pkg+':mean', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		dist.a = randu() * c;
+		dist.a = uniform(0.0 , c);
 		y = dist.mean;
 		if ( isnan( y ) ) {
 			bm.fail( 'should not return NaN' );
@@ -328,7 +340,7 @@ bench( pkg+':median', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		dist.a = randu() * c;
+		dist.a = uniform(0.0 , c);
 		y = dist.median;
 		if ( isnan( y ) ) {
 			bm.fail( 'should not return NaN' );
@@ -357,7 +369,7 @@ bench( pkg+':skewness', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		dist.a = randu() * c;
+		dist.a = uniform(0.0 , c);
 		y = dist.skewness;
 		if ( isnan( y ) ) {
 			bm.fail( 'should not return NaN' );
@@ -386,7 +398,7 @@ bench( pkg+':stdev', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		dist.a = randu() * c;
+		dist.a = uniform(0.0 , c);
 		y = dist.stdev;
 		if ( isnan( y ) ) {
 			bm.fail( 'should not return NaN' );
@@ -415,7 +427,7 @@ bench( pkg+':variance', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		dist.a = randu() * c;
+		dist.a = uniform(0.0 , c);
 		y = dist.variance;
 		if ( isnan( y ) ) {
 			bm.fail( 'should not return NaN' );
@@ -445,7 +457,7 @@ bench( pkg+':cdf', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		x = randu() * 60.0;
+		x = uniform(0.0 , 60.0);
 		y = dist.cdf( x );
 		if ( isnan( y ) ) {
 			bm.fail( 'should not return NaN' );
@@ -475,7 +487,7 @@ bench( pkg+':mgf', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		x = randu();
+		x = uniform(0.0 , 1.0);
 		y = dist.mgf( x );
 		if ( isnan( y ) ) {
 			bm.fail( 'should not return NaN' );
@@ -505,7 +517,7 @@ bench( pkg+':pdf', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		x = randu() * 60.0;
+		x = uniform(0.0 , 60.0);
 		y = dist.pdf( x );
 		if ( isnan( y ) ) {
 			bm.fail( 'should not return NaN' );
@@ -535,7 +547,7 @@ bench( pkg+':quantile', function benchmark( bm ) {
 
 	bm.tic();
 	for ( i = 0; i < bm.iterations; i++ ) {
-		x = randu();
+		x = uniform(0.0 , 1.0);
 		y = dist.quantile( x );
 		if ( isnan( y ) ) {
 			bm.fail( 'should not return NaN' );

lib/node_modules/@stdlib/stats/base/dists/triangular/entropy/benchmark/benchmark.js

@@ -22,11 +22,11 @@
 
 var bench = require( '@stdlib/bench' );
 var Float64Array = require( '@stdlib/array/float64' );
-var randu = require( '@stdlib/random/base/randu' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var EPS = require( '@stdlib/constants/float64/eps' );
 var pkg = require( './../package.json' ).name;
 var entropy = require( './../lib' );
+var uniform = require( '@stdlib/random/base/uniform' );
 
 
 // MAIN //
@@ -44,9 +44,9 @@ bench( pkg, function benchmark( b ) {
 	max = new Float64Array( len );
 	mode = new Float64Array( len );
 	for ( i = 0; i < len; i++ ) {
-		min[ i ] = ( randu()*10.0 );
-		max[ i ] = ( randu()*10.0 ) + min[ i ] + EPS;
-		mode[ i ] = ( ( max[ i ] - min[ i ] ) * randu() ) + min[ i ];
+		min[ i ] = uniform(0.0 , 10.0);
+		max[ i ] = uniform( min[ i ] + EPS , 10.0 + min[ i ] + EPS);
+		mode[ i ] = uniform( min[ i ] , max[ i ]);
 	}
 
 	b.tic();

lib/node_modules/@stdlib/stats/base/dists/triangular/entropy/benchmark/benchmark.native.js

@@ -23,11 +23,11 @@
 var resolve = require( 'path' ).resolve;
 var bench = require( '@stdlib/bench' );
 var Float64Array = require( '@stdlib/array/float64' );
-var randu = require( '@stdlib/random/base/randu' );
 var EPS = require( '@stdlib/constants/float64/eps' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 var pkg = require( './../package.json' ).name;
+var uniform = require( '@stdlib/random/base/uniform' );
 
 
 // VARIABLES //
@@ -53,9 +53,9 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 	max = new Float64Array( len );
 	mode = new Float64Array( len );
 	for ( i = 0; i < len; i++ ) {
-		min[ i ] = ( randu()*10.0 );
-		max[ i ] = ( randu()*10.0 ) + min[ i ] + EPS;
-		mode[ i ] = ( ( max[ i ] - min[ i ] ) * randu() ) + min[ i ];
+		min[ i ] = ( uniform(0.0 , 10.0) );
+		max[ i ] = uniform(min[ i ] + EPS,10.0+min[ i ] + EPS);
+		mode[ i ] = uniform(min[ i ] + max[ i ]);
 	}
 
 	b.tic();

lib/node_modules/@stdlib/stats/base/dists/triangular/kurtosis/benchmark/benchmark.js

@@ -22,11 +22,11 @@
 
 var bench = require( '@stdlib/bench' );
 var Float64Array = require( '@stdlib/array/float64' );
-var randu = require( '@stdlib/random/base/randu' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var EPS = require( '@stdlib/constants/float64/eps' );
 var pkg = require( './../package.json' ).name;
 var kurtosis = require( './../lib' );
+var uniform = require( '@stdlib/random/base/uniform' );
 
 
 // MAIN //
@@ -44,9 +44,9 @@ bench( pkg, function benchmark( b ) {
 	max = new Float64Array( len );
 	mode = new Float64Array( len );
 	for ( i = 0; i < len; i++ ) {
-		min[ i ] = ( randu()*10.0 );
-		max[ i ] = ( randu()*10.0 ) + min[ i ] + EPS;
-		mode[ i ] = ( ( max[ i ] - min[ i ] ) * randu() ) + min[ i ];
+		min[ i ] = uniform(0.0 , 10.0);
+		max[ i ] = uniform(min[ i ] + EPS, 10.0+min[ i ] + EPS);
+		mode[ i ] = uniform(min[ i ], max[ i ]);
 	}
 
 	b.tic();

lib/node_modules/@stdlib/stats/base/dists/triangular/kurtosis/benchmark/benchmark.native.js

@@ -23,11 +23,11 @@
 var resolve = require( 'path' ).resolve;
 var bench = require( '@stdlib/bench' );
 var Float64Array = require( '@stdlib/array/float64' );
-var randu = require( '@stdlib/random/base/randu' );
 var EPS = require( '@stdlib/constants/float64/eps' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 var pkg = require( './../package.json' ).name;
+var uniform = require( '@stdlib/random/base/uniform' );
 
 
 // VARIABLES //
@@ -53,9 +53,9 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 	max = new Float64Array( len );
 	mode = new Float64Array( len );
 	for ( i = 0; i < len; i++ ) {
-		min[ i ] = ( randu()*10.0 );
-		max[ i ] = ( randu()*10.0 ) + min[ i ] + EPS;
-		mode[ i ] = ( ( max[ i ] - min[ i ] ) * randu() ) + min[ i ];
+		min[ i ] = uniform(0.0 , 10.0);
+		max[ i ] = uniform(min[ i ] + EPS, 10.0+min[ i ] + EPS);
+		mode[ i ] = uniform(min[ i ], max[ i ]);
 	}
 
 	b.tic();

lib/node_modules/@stdlib/stats/base/dists/triangular/mean/benchmark/benchmark.js

@@ -22,10 +22,10 @@
 
 var bench = require( '@stdlib/bench' );
 var Float64Array = require( '@stdlib/array/float64' );
-var randu = require( '@stdlib/random/base/randu' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pkg = require( './../package.json' ).name;
 var mean = require( './../lib' );
+var uniform = require( '@stdlib/random/base/uniform' );
 
 
 // MAIN //
@@ -43,9 +43,9 @@ bench( pkg, function benchmark( b ) {
 	bnd = new Float64Array( len );
 	c = new Float64Array( len );
 	for ( i = 0; i < len; i++ ) {
-		a[ i ] = randu() * 20.0;
-		bnd[ i ] = ( randu() * 20.0 ) + a[ i ];
-		c[ i ] = ( randu() * ( bnd[i] - a[i] ) ) + a[i];
+		a[ i ] = uniform(0.0 , 20.0);
+		bnd[ i ] = uniform(a[ i ] , 20.0 + a[ i ]);
+		c[ i ] = uniform( a[ i ], bnd[ i ] ); 
 	}
 
 	b.tic();

lib/node_modules/@stdlib/stats/base/dists/triangular/mean/benchmark/benchmark.native.js

@@ -23,10 +23,10 @@
 var resolve = require( 'path' ).resolve;
 var bench = require( '@stdlib/bench' );
 var Float64Array = require( '@stdlib/array/float64' );
-var randu = require( '@stdlib/random/base/randu' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 var pkg = require( './../package.json' ).name;
+var uniform = require( '@stdlib/random/base/uniform' );
 
 
 // VARIABLES //
@@ -52,9 +52,9 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 	bnd = new Float64Array( len );
 	c = new Float64Array( len );
 	for ( i = 0; i < len; i++ ) {
-		a[ i ] = ( randu() * 20.0 );
-		bnd[ i ] = ( randu() * 20.0 ) + a[ i ];
-		c[ i ] = ( randu() * ( bnd[i] - a[i] ) ) + a[i];
+		a[ i ] = uniform(0.0 , 20.0);
+		bnd[ i ] = uniform(a[ i ] , 20.0 + a[ i ]);
+		c[ i ] = uniform( a[ i ], bnd[ i ] ); 
 	}
 
 	b.tic();

lib/node_modules/@stdlib/stats/base/dists/triangular/median/benchmark/benchmark.js

@@ -22,11 +22,11 @@
 
 var bench = require( '@stdlib/bench' );
 var Float64Array = require( '@stdlib/array/float64' );
-var randu = require( '@stdlib/random/base/randu' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var EPS = require( '@stdlib/constants/float64/eps' );
 var pkg = require( './../package.json' ).name;
 var median = require( './../lib' );
+var uniform = require( '@stdlib/random/base/uniform' );
 
 
 // MAIN //
@@ -44,9 +44,9 @@ bench( pkg, function benchmark( b ) {
 	max = new Float64Array( len );
 	mode = new Float64Array( len );
 	for ( i = 0; i < len; i++ ) {
-		min[ i ] = ( randu()*10.0 );
-		max[ i ] = ( randu()*10.0 ) + min[ i ] + EPS;
-		mode[ i ] = ( ( max[ i ] - min[ i ] ) * randu() ) + min[ i ];
+		min[ i ] = uniform(0.0 , 10.0);
+		max[ i ] = uniform(min[ i ] + EPS , 10.0 + min[ i ] + EPS );
+		mode[ i ] = uniform(min[ i ] , max[ i ]);
 	}
 
 	b.tic();

lib/node_modules/@stdlib/stats/base/dists/triangular/median/benchmark/benchmark.native.js

@@ -23,11 +23,11 @@
 var resolve = require( 'path' ).resolve;
 var bench = require( '@stdlib/bench' );
 var Float64Array = require( '@stdlib/array/float64' );
-var randu = require( '@stdlib/random/base/randu' );
 var EPS = require( '@stdlib/constants/float64/eps' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 var pkg = require( './../package.json' ).name;
+var uniform = require( '@stdlib/random/base/uniform' );
 
 
 // VARIABLES //
@@ -53,9 +53,9 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 	max = new Float64Array( len );
 	mode = new Float64Array( len );
 	for ( i = 0; i < len; i++ ) {
-		min[ i ] = ( randu()*10.0 );
-		max[ i ] = ( randu()*10.0 ) + min[ i ] + EPS;
-		mode[ i ] = ( ( max[ i ] - min[ i ] ) * randu() ) + min[ i ];
+		min[ i ] = uniform(0.0 , 10.0);
+		max[ i ] = uniform(min[ i ] + EPS , 10.0 + min[ i ] + EPS );
+		mode[ i ] = uniform(min[ i ] , max[ i ]);
 	}
 
 	b.tic();

lib/node_modules/@stdlib/stats/base/dists/triangular/mode/benchmark/benchmark.js

@@ -22,7 +22,7 @@
 
 var bench = require( '@stdlib/bench' );
 var Float64Array = require( '@stdlib/array/float64' );
-var randu = require( '@stdlib/random/base/randu' );
+var uniform = require( '@stdlib/random/base/uniform' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pkg = require( './../package.json' ).name;
 var mode = require( './../lib' );
@@ -43,9 +43,9 @@ bench( pkg, function benchmark( b ) {
 	bnd = new Float64Array( len );
 	c = new Float64Array( len );
 	for ( i = 0; i < len; i++ ) {
-		a[ i ] = randu() * 20.0;
-		bnd[ i ] = ( randu() * 20.0 ) + a[ i ];
-		c[ i ] = ( randu() * ( bnd[i] - a[i] ) ) + a[i];
+		a[ i ] = uniform(0.0 , 20.0);
+		bnd[ i ] = uniform(a[ i ] , 20.0);
+		c[ i ] = uniform(a[i] , bnd[i]);
 	}
 
 	b.tic();