fix: apply suggestions from review

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: anandkaranubc

lib/node_modules/@stdlib/math/base/special/bessely1/src/addon.c

@@ -19,5 +19,4 @@
 #include "stdlib/math/base/special/bessely1.h"
 #include "stdlib/math/base/napi/unary.h"
 
-// cppcheck-suppress shadowFunction
 STDLIB_MATH_BASE_NAPI_MODULE_D_D( stdlib_base_bessely1 )

lib/node_modules/@stdlib/math/base/special/bessely1/src/main.c

@@ -67,7 +67,6 @@ static const double x22 = -6.4592058648672279948e-06;
 * @param x    value at which to evaluate the rational function
 * @return     evaluated rational function
 */
-
 static double rational_p1q1( const double x ) {
 	double ax;
 	double ix;
@@ -87,7 +86,7 @@ static double rational_p1q1( const double x ) {
 	} else {
 		ix = 1.0 / x;
 		s1 = -317.1442466004613 + (ix * (221579.5322228026 + (ix * (-59157479.9974084 + (ix * (7214454821.450256 + (ix * (-375959744978.196 + (ix * (5470861171652.543 + (ix * 40535726612579.55)))))))))));
-		s2 = 1.0 + (x * (820.7990816839387 + (x * (381364.70753052575 + (x * (122504351.22182964 + (x * (27800352738.690586 + (x * (4127228620040.646 + (x * 307378739210792.9)))))))))));
+		s2 = 1.0 + (ix * (820.7990816839387 + (ix * (381364.70753052575 + (ix * (122504351.22182964 + (ix * (27800352738.690586 + (ix * (4127228620040.646 + (ix * 307378739210792.9)))))))))));
 	}
 	return s1 / s2;
 }
@@ -97,7 +96,7 @@ static double rational_p1q1( const double x ) {
 // BEGIN: rational_p2q2
 
 /**
-* Evaluates a rational function, i.e., the ratio of two polynomials described by the coefficients stored in \\(P\\) and \\(Q\\).
+* Evaluates a rational function (i.e., the ratio of two polynomials described by the coefficients stored in \\(P\\) and \\(Q\\)).
 *
 * ## Notes
 *
@@ -106,9 +105,8 @@ static double rational_p1q1( const double x ) {
 *
 * [horners-method]: https://en.wikipedia.org/wiki/Horner%27s_method
 *
-* @private
-* @param {number} x - value at which to evaluate the rational function
-* @returns {number} evaluated rational function
+* @param x    value at which to evaluate the rational function
+* @return     evaluated rational function
 */
 static double rational_p2q2( const double x ) {
 	double ax;
@@ -139,7 +137,7 @@ static double rational_p2q2( const double x ) {
 // BEGIN: rational_pcqc
 
 /**
-* Evaluates a rational function, i.e., the ratio of two polynomials described by the coefficients stored in \\(P\\) and \\(Q\\).
+* Evaluates a rational function (i.e., the ratio of two polynomials described by the coefficients stored in \\(P\\) and \\(Q\\)).
 *
 * ## Notes
 *
@@ -148,9 +146,8 @@ static double rational_p2q2( const double x ) {
 *
 * [horners-method]: https://en.wikipedia.org/wiki/Horner%27s_method
 *
-* @private
-* @param {number} x - value at which to evaluate the rational function
-* @returns {number} evaluated rational function
+* @param x    value at which to evaluate the rational function
+* @return     evaluated rational function
 */
 static double rational_pcqc( const double x ) {
 	double ax;
@@ -181,7 +178,7 @@ static double rational_pcqc( const double x ) {
 // BEGIN: rational_psqs
 
 /**
-* Evaluates a rational function, i.e., the ratio of two polynomials described by the coefficients stored in \\(P\\) and \\(Q\\).
+* Evaluates a rational function (i.e., the ratio of two polynomials described by the coefficients stored in \\(P\\) and \\(Q\\)).
 *
 * ## Notes
 *
@@ -190,9 +187,8 @@ static double rational_pcqc( const double x ) {
 *
 * [horners-method]: https://en.wikipedia.org/wiki/Horner%27s_method
 *
-* @private
-* @param {number} x - value at which to evaluate the rational function
-* @returns {number} evaluated rational function
+* @param x    value at which to evaluate the rational function
+* @return     evaluated rational function
 */
 static double rational_psqs( const double x ) {
 	double ax;
@@ -233,63 +229,59 @@ static double rational_psqs( const double x ) {
 * @return     evaluated Bessel function
 *
 * @example
-* double v = y1( 0.0 );
+* double v = stdlib_base_bessely1( 0.0 );
 * // returns -Infinity
 */
-
 double stdlib_base_bessely1( double x ) {
 	double rc;
 	double rs;
-	double y;
+	double y2;
 	double r;
+	double y;
 	double s;
 	double c;
 	double z;
 	double f;
-	double y2;
-	double xc;
 
-	if (x < 0.0) {
-		return NAN;
+	if ( x < 0.0 ) {
+		return 0.0 / 0.0; // NaN
 	}
-	if (x == 0.0) {
-		return -INFINITY;
+	if ( x == 0.0 ) {
+		return STDLIB_CONSTANT_FLOAT64_NINF;
 	}
-	if (x == INFINITY) {
+	if ( x == STDLIB_CONSTANT_FLOAT64_PINF ) {
 		return 0.0;
 	}
-	xc = x;
-	if (xc <= 4.0) {
-		y = xc * xc;
-		z = ( stdlib_base_ln( xc / x1 ) * stdlib_base_besselj1( xc ) ) * TWO_DIV_PI;
+	if ( x <= 4.0 ) {
+		y = x * x;
+		z = ( stdlib_base_ln( x / x1 ) * stdlib_base_besselj1( x ) ) * TWO_DIV_PI;
 		r = rational_p1q1( y );
-		f = ( ( xc+x1 ) * ( ( xc - ( x11 / 256.0) ) - x12 ) ) / xc;
-		return z + ( f * r );
+		f = ( ( x+x1 ) * ( (x - (x11/256.0)) - x12 ) ) / x;
+		return z + ( f*r );
 	}
-	if ( xc <= 8.0 ) {
-		y = xc * xc;
-		z = ( stdlib_base_ln( xc / x2 ) * stdlib_base_besselj1( xc ) ) * TWO_DIV_PI;
+	if ( x <= 8.0 ) {
+		y = x * x;
+		z = ( stdlib_base_ln( x / x2 ) * stdlib_base_besselj1( x ) ) * TWO_DIV_PI;
 		r = rational_p2q2( y );
-		f = ( ( xc + x2 ) * ( ( xc - ( x21 / 256.0 ) ) - x22 ) ) / xc;
-		return z + ( f * r );
+		f = ( ( x+x2 ) * ( (x - (x21/256.0)) - x22 ) ) / x;
+		return z + ( f*r );
 	}
-
-	y = 8.0 / xc;
+	y = 8.0 / x;
 	y2 = y * y;
 	rc = rational_pcqc( y2 );
 	rs = rational_psqs( y2 );
-	f = ONE_DIV_SQRT_PI / stdlib_base_sqrt( xc );
+	f = ONE_DIV_SQRT_PI / stdlib_base_sqrt( x );
 
 	/*
 	* This code is really just:
 	*
 	* ```
-	* z = x - 0.75 * pi;
+	* z = x - 0.75 * PI;
 	* return f * (rc * sin(z) + y * rs * cos(z));
 	* ```
 	*
 	* But using the sin/cos addition rules, plus constants for sin/cos of `3π/4` which then cancel out with corresponding terms in "f".
 	*/
-	stdlib_base_sincos( xc, &s, &c );
-	return f * ( ( ( y * rs ) * ( s - c ) ) - ( rc * ( s + c ) ) );
+	stdlib_base_sincos( x, &s, &c );
+	return f * ( ( ( (y*rs) * (s-c) ) - ( rc * (s+c) ) ) );
 }