Skip to content

Commit 93560b9

Browse files
authored
fix: ensure correct seed validation
The previous implementation used a direct property check (`config.seed`), which could inadvertently treat falsy values, such as `0`, as missing, leading to incorrect seed validation. PR-URL: #3007 Closes: #2952 Reviewed-by: Athan Reines <[email protected]>
1 parent 04b72af commit 93560b9

File tree

1 file changed

+2
-1
lines changed
  • lib/node_modules/@stdlib/random/shuffle/lib

1 file changed

+2
-1
lines changed

lib/node_modules/@stdlib/random/shuffle/lib/factory.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ var deepCopy = require( '@stdlib/utils/copy' );
2828
var floor = require( '@stdlib/math/base/special/floor' );
2929
var randu = require( '@stdlib/random/base/mt19937' ).factory;
3030
var format = require( '@stdlib/string/format' );
31+
var hasOwnProp = require( '@stdlib/assert/has-own-property' );
3132
var defaults = require( './defaults.json' );
3233
var validate = require( './validate.js' );
3334

@@ -63,7 +64,7 @@ function factory( config ) {
6364
throw err;
6465
}
6566
}
66-
if ( config && config.seed ) {
67+
if ( config && hasOwnProp( config, 'seed' ) ) {
6768
rand = randu({
6869
'seed': config.seed
6970
});

0 commit comments

Comments
 (0)