You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# Process comments to create one GitHub issue per commit tagging @stdlib-bot:
334
339
echo"Processing commit comments for tasks tagging @stdlib-bot...">&2
335
340
336
-
# Instead of an associative array, use two indexed arrays:
337
341
commit_keys=()
338
342
commit_counts=()
343
+
commit_links=()
339
344
340
345
forcommentin"${all_comments[@]}";do
341
346
# Extract the comment body:
@@ -353,7 +358,10 @@ main() {
353
358
local commit_sha
354
359
commit_sha=$(echo "$comment"| jq -r '.commit_id')
355
360
if [ -n"$commit_sha" ];then
356
-
update_commit_map "$commit_sha"
361
+
# Extract the comment URL:
362
+
local comment_url
363
+
comment_url=$(echo "$comment"| jq -r '.html_url')
364
+
update_commit_map "$commit_sha""$comment_url"
357
365
fi
358
366
else
359
367
echo"Skipping comment by non-core contributor: ${comment_author}">&2
@@ -366,16 +374,44 @@ main() {
366
374
foridxin$(seq 0 $((${#commit_keys[@]}-1)));do
367
375
local commit_sha="${commit_keys[$idx]}"
368
376
local count="${commit_counts[$idx]}"
377
+
local links="${commit_links[$idx]}"
369
378
370
379
# Generate a short SHA (first 7 characters):
371
380
local short_sha=${commit_sha:0:7}
372
381
local issue_title="Address commit comments (commit ${short_sha})"
373
382
local commit_link="https://github.com/${owner}/${repo}/commit/${commit_sha}"
374
-
local issue_body="This issue was created automatically to address commit comments tagging @stdlib-bot.
383
+
local issue_body="This commit has **${count}** comment(s) from core contributors that require attention.
375
384
376
385
**Commit:** [${commit_sha}](${commit_link})
377
386
378
-
This commit has **${count}** comment(s) from core contributors that require attention."
387
+
**Comments:**
388
+
${links}
389
+
390
+
Interested in helping improve the project? If you are, the comment linked to above has **${count}** comment(s) from core contributors that could use your attention.
391
+
392
+
What do you need to do?
393
+
394
+
1. Open the link to the commit above.
395
+
2. Find all the comments which mention @stdlib-bot. These comments should describe follow-up tasks or desired changes, such as formatting improvements, small refactorings, or clean-up.
396
+
3. If you are a first-time contributor, follow the [contributing](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md) and [development](https://github.com/stdlib-js/stdlib/blob/develop/docs/development.md) guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
397
+
4. Make all the desired changes and commit those changes to a local branch.
398
+
5. Push the changes to GitHub and open a new pull request against the \`develop\` branch of the main stdlib development [repository](https://github.com/stdlib-js/stdlib).
399
+
400
+
Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.
401
+
402
+
And that's it!
403
+
404
+
Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌
405
+
406
+
* * *
407
+
408
+
## Notes
409
+
410
+
- For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!
411
+
412
+
* * *
413
+
414
+
This issue was created automatically to address commit comments tagging @stdlib-bot."
379
415
380
416
# Check if an issue for this commit already exists:
0 commit comments