Skip to content

Commit 97c705a

Browse files
authored
Apply suggestions from code review
Signed-off-by: Athan <[email protected]>
1 parent 62e84fc commit 97c705a

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

.github/workflows/scripts/rate_limit_contributions

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,15 +133,17 @@ main() {
133133

134134
if [ "${num_good_first_prs}" -gt "${max_good_first_prs}" ]; then
135135
# Post a comment on the PR:
136-
comment="Hey, we noticed that you've been opening a number of PRs addressing good first issues.
136+
comment="Hello! 👋
137137
138-
Thanks for your interest and enthusiasm.
138+
We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!
139139
140-
Now that you've made a few contributions, we suggest no longer working on good first issues and instead working on more involved tasks.
140+
Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.
141141
142-
Not only does this ensure that other new contributors can work on things, but it ensures you can spend your time on more challenging problems."
142+
Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀
143143
144-
if ! github_api "POST" "/repos/${repo_owner}/${repo_name}/issues/${pr_number}/comments" "{\"body\":$(echo "$comment" | jq -R -s -c .)}"; then
144+
For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!"
145+
146+
if ! github_api "POST" "/repos/${repo_owner}/${repo_name}/issues/${pr_number}/comments" "{\"body\":$(echo "${comment}" | jq -R -s -c .)}"; then
145147
echo "Failed to post comment on PR."
146148
on_error 1
147149
fi

0 commit comments

Comments
 (0)