Skip to content

Commit 9d1f200

Browse files
authored
chore: apply suggestions from code review
Signed-off-by: Philipp Burckhardt <[email protected]>
1 parent 616f492 commit 9d1f200

File tree

6 files changed

+9
-29
lines changed

6 files changed

+9
-29
lines changed

lib/node_modules/@stdlib/stats/base/dists/laplace/cdf/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ int main( void ) {
208208
b = random_uniform( 0.0, 20.0 );
209209
x = random_uniform( 0.0, 1.0 );
210210
y = stdlib_base_dists_laplace_cdf( p, mu, b );
211-
printf( "x: %lf, µ: %lf, b: %lf, cdf(X;x,µ,b): %lf\n", x, mu, b, y );
211+
printf( "x: %lf, µ: %lf, b: %lf, F(x;µ,b): %lf\n", x, mu, b, y );
212212
}
213213
}
214214
```

lib/node_modules/@stdlib/stats/base/dists/laplace/cdf/benchmark/c/benchmark.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ static double benchmark( void ) {
104104
for ( i = 0; i < 100; i++ ) {
105105
x[ i ] = random_uniform( 0.0, 10.0 );
106106
mu[ i ] = random_uniform( 0.0, 10.0 );
107-
b[ i ] = random_uniform( 0.0, 10.0 ) + STDLIB_CONSTANT_FLOAT64_EPS;
107+
b[ i ] = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
108108
}
109109

110110
t = tic();

lib/node_modules/@stdlib/stats/base/dists/laplace/cdf/examples/c/example.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,6 @@ int main( void ) {
3737
mu = random_uniform( 0.0, 10.0 );
3838
b = random_uniform( 0.0, 10.0 );
3939
y = stdlib_base_dists_laplace_cdf( x, mu, b );
40-
printf( "x: %lf, µ: %lf, b: %lf, cdf(X;x,µ,b): %lf\n", x, mu, b, y );
40+
printf( "x: %lf, µ: %lf, b: %lf, F(x;µ,b): %lf\n", x, mu, b, y );
4141
}
4242
}

lib/node_modules/@stdlib/stats/base/dists/laplace/cdf/include/stdlib/stats/base/dists/laplace/cdf.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ extern "C" {
2727
#endif
2828

2929
/**
30-
* Returns the cumulative distribution function (CDF) for a Laplace distribution with location parameter `mu` and scale parameter `b` at value `x`.
30+
* Evaluates the cumulative distribution function (CDF) for a Laplace distribution with location parameter `mu` and scale parameter `b` at value `x`.
3131
*/
3232
double stdlib_base_dists_laplace_cdf( const double x, const double mu, const double b );
3333

lib/node_modules/@stdlib/stats/base/dists/laplace/cdf/lib/native.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ var addon = require( './../src/addon.node' );
2828
/**
2929
* Evaluates the cumulative distribution function (CDF) for a Laplace distribution with location parameter `mu` and scale parameter `b` at value `x`.
3030
*
31+
* @private
3132
* @param {number} x - input value
3233
* @param {number} mu - location parameter
3334
* @param {PositiveNumber} b - scale parameter

lib/node_modules/@stdlib/stats/base/dists/laplace/cdf/src/main.c

Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -24,35 +24,14 @@
2424
/**
2525
* Returns the cumulative distribution function (CDF) for a Laplace distribution with location parameter `mu` and scale parameter `b` at value `x`.
2626
*
27-
* @param {number} x - input value
28-
* @param {number} mu - location parameter
29-
* @param {PositiveNumber} b - scale parameter
30-
* @returns {Probability} evaluated CDF
27+
* @param x input value
28+
* @param mu location parameter
29+
* @param b scale parameter
30+
* @return evaluated CDF
3131
*
3232
* @example
3333
* double y = stdlib_base_dists_laplace_cdf( 2.0, 0.0, 1.0 );
3434
* // returns ~0.932
35-
*
36-
* @example
37-
* double y = stdlib_base_dists_laplace_cdf( 5.0, 10.0, 3.0 );
38-
* // returns ~0.094
39-
*
40-
* @example
41-
* double y = stdlib_base_dists_laplace_cdf( NaN, 0.0, 1.0 );
42-
* // returns NaN
43-
*
44-
* @example
45-
* double y = stdlib_base_dists_laplace_cdf( 2, NaN, 1.0 );
46-
* // returns NaN
47-
*
48-
* @example
49-
* double y = stdlib_base_dists_laplace_cdf( 2.0, 0.0, NaN );
50-
* // returns NaN
51-
*
52-
* @example
53-
* // Negative scale parameter:
54-
* double y = stdlib_base_dists_laplace_cdf( 2.0, 0.0, -1.0 );
55-
* // returns NaN
5635
*/
5736
double stdlib_base_dists_laplace_cdf( const double x, const double mu, const double b ) {
5837
double z;

0 commit comments

Comments
 (0)