Skip to content

Commit a2225c2

Browse files
committed
fix: apply review suggestions
Signed-off-by: Snehil Shah <[email protected]>
1 parent 3897f2a commit a2225c2

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

lib/node_modules/@stdlib/blas/ext/base/snansumpw/lib/ndarray.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ function snansumpw( N, x, strideX, offsetX ) {
7878
}
7979
ix = offsetX;
8080
if ( strideX === 0 ) {
81-
if ( isnanf( x[ offsetX ] ) ) {
81+
if ( isnanf( x[ ix ] ) ) {
8282
return 0.0;
8383
}
8484
return N * x[ ix ];

lib/node_modules/@stdlib/blas/ext/base/snansumpw/src/addon.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
3737
STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 );
3838
STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 );
3939
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 1 );
40-
STDLIB_NAPI_CREATE_DOUBLE( env, (double)API_SUFFIX(stdlib_strided_snansumpw)( N, X, strideX ), v )
40+
STDLIB_NAPI_CREATE_DOUBLE( env, (double)API_SUFFIX(stdlib_strided_snansumpw)( N, X, strideX ), v );
4141
return v;
4242
}
4343

@@ -54,7 +54,7 @@ static napi_value addon_method( napi_env env, napi_callback_info info ) {
5454
STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 );
5555
STDLIB_NAPI_ARGV_INT64( env, offsetX, argv, 3 );
5656
STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY( env, X, N, strideX, argv, 1 );
57-
STDLIB_NAPI_CREATE_DOUBLE( env, (double)API_SUFFIX(stdlib_strided_snansumpw_ndarray)( N, X, strideX, offsetX ), v )
57+
STDLIB_NAPI_CREATE_DOUBLE( env, (double)API_SUFFIX(stdlib_strided_snansumpw_ndarray)( N, X, strideX, offsetX ), v );
5858
return v;
5959
}
6060

lib/node_modules/@stdlib/blas/ext/base/snansumpw/src/main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ float API_SUFFIX(stdlib_strided_snansumpw_ndarray)( const CBLAS_INT N, const flo
7979
}
8080
ix = offsetX;
8181
if ( strideX == 0 ) {
82-
if ( stdlib_base_is_nanf( X[ 0 ] ) ) {
82+
if ( stdlib_base_is_nanf( X[ ix ] ) ) {
8383
return 0.0f;
8484
}
8585
return N * X[ ix ];
@@ -135,7 +135,7 @@ float API_SUFFIX(stdlib_strided_snansumpw_ndarray)( const CBLAS_INT N, const flo
135135
ix += strideX;
136136
}
137137
// Pairwise sum the accumulators:
138-
sum = ((s0+s1) + (s2+s3)) + ((s4+s5) + (s6+s7));
138+
sum = ( (s0+s1) + (s2+s3) ) + ( (s4+s5) + (s6+s7) );
139139

140140
// Clean-up loop...
141141
for (; i < N; i++ ) {

lib/node_modules/@stdlib/blas/ext/base/snansumpw/test/test.snansumpw.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ tape( 'main export is a function', function test( t ) {
3434
});
3535

3636
tape( 'the function has an arity of 3', function test( t ) {
37-
t.strictEqual( snansumpw.length, 3, 'return expected value' );
37+
t.strictEqual( snansumpw.length, 3, 'returns expected value' );
3838
t.end();
3939
});
4040

lib/node_modules/@stdlib/blas/ext/base/snansumpw/test/test.snansumpw.native.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ tape( 'main export is a function', opts, function test( t ) {
4343
});
4444

4545
tape( 'the function has an arity of 3', opts, function test( t ) {
46-
t.strictEqual( snansumpw.length, 3, 'return expected value' );
46+
t.strictEqual( snansumpw.length, 3, 'returns expected value' );
4747
t.end();
4848
});
4949

0 commit comments

Comments
 (0)