fix: avoid input argument mutation

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: kgryte

lib/node_modules/@stdlib/ndarray/base/broadcast-array-except-dimensions/lib/index.js

@@ -19,7 +19,7 @@
 'use strict';
 
 /**
-* Broadcast an input ndarray to a target shape keeping the specified dimensions unchanged.
+* Broadcast an input ndarray to a target shape while keeping a list of specified dimensions unchanged.
 *
 * @module @stdlib/ndarray/base/broadcast-array-except-dimensions
 *
@@ -33,7 +33,7 @@
 * var shx = x.shape;
 * // returns [ 1, 3 ]
 *
-* var y = broadcastArrayExceptDimensionsExceptDimensions( x, [ 2, 2, 3 ], [ -2 ] );
+* var y = broadcastArrayExceptDimensions( x, [ 2, 2, 3 ], [ -2 ] );
 * // returns <ndarray>
 *
 * var shy = y.shape;

lib/node_modules/@stdlib/ndarray/base/broadcast-array-except-dimensions/lib/main.js

@@ -20,7 +20,7 @@
 
 // MODULES //
 
-var copy = require( '@stdlib/array/base/copy-indexed' );
+var copy = require( '@stdlib/array/base/copy' );
 var ndarray = require( '@stdlib/ndarray/base/ctor' );
 var getShape = require( '@stdlib/ndarray/base/shape' );
 var getStrides = require( '@stdlib/ndarray/base/strides' );
@@ -29,18 +29,19 @@ var getOrder = require( '@stdlib/ndarray/base/order' );
 var getDType = require( '@stdlib/ndarray/base/dtype' );
 var getData = require( '@stdlib/ndarray/base/data-buffer' );
 var normalizeIndices = require( '@stdlib/ndarray/base/normalize-indices' );
-var format = require( '@stdlib/string/format' );
 var join = require( '@stdlib/array/base/join' );
+var zeros = require( '@stdlib/array/base/zeros' );
+var format = require( '@stdlib/string/format' );
 
 
 // MAIN //
 
 /**
-* Broadcasts an input ndarray to a target shape keeping the specified dimensions unchanged.
+* Broadcasts an input ndarray to a target shape while keeping a list of specified dimensions unchanged.
 *
 * @param {ndarray} arr - input array
 * @param {NonNegativeIntegerArray} shape - desired shape
-* @param {IntegerArray} [dims] - list of dimensions to exclude
+* @param {IntegerArray} dims - list of dimensions to exclude from broadcasting
 * @throws {Error} input array cannot have more dimensions than the desired shape
 * @throws {Error} input array and desired shape must be broadcast compatible
 * @throws {RangeError} dimension indices must not exceed desired shape bounds
@@ -80,7 +81,7 @@ var join = require( '@stdlib/array/base/join' );
 * v = y.get( 1, 0, 2 );
 * // returns 3
 */
-function broadcastArrayExceptDimensions( arr, shape, dims ) {
+function broadcastArrayExceptDimensions( arr, shape, dims ) { // eslint-disable-line id-length
 	var strides;
 	var dim;
 	var sh;
@@ -93,26 +94,20 @@ function broadcastArrayExceptDimensions( arr, shape, dims ) {
 	var i;
 	var j;
 
+	shape = copy( shape ); // perform a copy to avoid unintended mutation
 	N = shape.length;
+
 	sh = getShape( arr, false );
 	M = sh.length;
 	if ( N < M ) {
 		throw new Error( 'invalid argument. Cannot broadcast an array to a shape having fewer dimensions. Arrays can only be broadcasted to shapes having the same or more dimensions.' );
 	}
-	// Initialize a strides array...
-	strides = [];
-	for ( i = 0; i < N; i++ ) {
-		strides.push( 0 );
-	}
-	// Determine the output array strides...
-	st = getStrides( arr, false );
+	// Initialize a strides array:
+	strides = zeros( N );
 
-	if ( !dims ) {
-		dims = [ -1 ];
-	}
 	// Verify that we've been provided a list of unique dimension indices...
 	dl = dims.length;
-	dims = normalizeIndices( dims, N - 1 );
+	dims = normalizeIndices( dims, N-1 );
 	if ( dims === null ) {
 		throw new RangeError( format( 'invalid argument. Third argument contains an out-of-bounds dimension index. Value: [%s].', join( dims, ',' ) ) );
 	}
@@ -121,6 +116,9 @@ function broadcastArrayExceptDimensions( arr, shape, dims ) {
 		throw new Error( format( 'invalid argument. Third argument must contain a list of unique dimension indices. Value: [%s].', join( dims, ',' ) ) );
 	}
 	di = dims.length - 1;
+
+	// Determine the output array strides...
+	st = getStrides( arr, false );
 	for ( i = N-1; i >= 0; i-- ) {
 		j = M - N + i;
 		if ( di >= 0 && dims[ di ] === i ) {
@@ -150,7 +148,7 @@ function broadcastArrayExceptDimensions( arr, shape, dims ) {
 			throw new Error( format( 'invalid argument. Input array and the specified shape are broadcast incompatible. Array shape: (%s). Desired shape: (%s). Dimension: %u.', copy( sh ).join( ', ' ), copy( shape ).join( ', ' ), i ) );
 		}
 	}
-	return ndarray( getDType( arr ), getData( arr ), copy( shape ), strides, getOffset( arr ), getOrder( arr ) ); // eslint-disable-line max-len
+	return ndarray( getDType( arr ), getData( arr ), shape, strides, getOffset( arr ), getOrder( arr ) ); // eslint-disable-line max-len
 }