Skip to content

Commit a4cbab5

Browse files
committed
fix: convert the JS result to float32
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 13b838b commit a4cbab5

File tree

1 file changed

+2
-1
lines changed
  • lib/node_modules/@stdlib/math/base/special/factorial2f/lib

1 file changed

+2
-1
lines changed

lib/node_modules/@stdlib/math/base/special/factorial2f/lib/main.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
2424
var isIntegerf = require( '@stdlib/math/base/assert/is-integerf' );
2525
var isEvenf = require( '@stdlib/math/base/assert/is-evenf' );
26+
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
2627
var PINF = require( '@stdlib/constants/float32/pinf' );
2728
var FLOAT32_MAX_SAFE_NTH_DOUBLE_FACTORIAL = require( '@stdlib/constants/float32/max-safe-nth-double-factorial' ); // eslint-disable-line id-length
2829

@@ -83,7 +84,7 @@ function factorial2f( n ) {
8384
for ( i = v|0; i >= last; i -= 2|0 ) {
8485
out *= i|0; // asm type annotation
8586
}
86-
return out;
87+
return float64ToFloat32( out );
8788
}
8889

8990

0 commit comments

Comments
 (0)