refactor: avoid duplicate computation

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: kgryte

lib/node_modules/@stdlib/ndarray/base/unary-by/lib/10d.js

@@ -20,11 +20,6 @@
 
 'use strict';
 
-// MODULES //
-
-var strides2order = require( '@stdlib/ndarray/base/strides2order' );
-
-
 // MAIN //
 
 /**
@@ -45,6 +40,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * @param {IntegerArray} y.strides - stride lengths
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @param {Function} fcn - unary function to apply to callback return values
 * @param {Callback} clbk - callback
 * @param {*} [thisArg] - callback execution context
@@ -95,12 +91,12 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * };
 *
 * // Apply the unary function:
-* unary10d( x, y, scale, accessor );
+* unary10d( x, y, true, scale, accessor );
 *
 * console.log( y.data );
 * // => <Float64Array>[ 40.0, 60.0, 120.0, 140.0, 200.0, 220.0 ]
 */
-function unary10d( x, y, fcn, clbk, thisArg ) { // eslint-disable-line max-statements
+function unary10d( x, y, isRowMajor, fcn, clbk, thisArg ) { // eslint-disable-line max-statements
 	var xbuf;
 	var ybuf;
 	var dx0;
@@ -157,7 +153,7 @@ function unary10d( x, y, fcn, clbk, thisArg ) { // eslint-disable-line max-state
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( strides2order( sx ) === 1 ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 9 ];
 		S1 = sh[ 8 ];

lib/node_modules/@stdlib/ndarray/base/unary-by/lib/10d_accessors.js

@@ -20,11 +20,6 @@
 
 'use strict';
 
-// MODULES //
-
-var strides2order = require( '@stdlib/ndarray/base/strides2order' );
-
-
 // MAIN //
 
 /**
@@ -47,6 +42,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
 * @param {Array<Function>} y.accessors - data buffer accessors
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @param {Function} fcn - unary function to apply to callback return values
 * @param {Callback} clbk - callback
 * @param {*} [thisArg] - callback execution context
@@ -108,7 +104,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * };
 *
 * // Apply the unary function:
-* unary10d( x, y, scale, cidentityf );
+* unary10d( x, y, true, scale, cidentityf );
 *
 * var v = y.data.get( 0 );
 *
@@ -118,7 +114,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * var im = imagf( v );
 * // returns 20.0
 */
-function unary10d( x, y, fcn, clbk, thisArg ) { // eslint-disable-line max-statements
+function unary10d( x, y, isRowMajor, fcn, clbk, thisArg ) { // eslint-disable-line max-statements
 	var xbuf;
 	var ybuf;
 	var get;
@@ -177,7 +173,7 @@ function unary10d( x, y, fcn, clbk, thisArg ) { // eslint-disable-line max-state
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( strides2order( sx ) === 1 ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 9 ];
 		S1 = sh[ 8 ];

lib/node_modules/@stdlib/ndarray/base/unary-by/lib/2d.js

@@ -18,11 +18,6 @@
 
 'use strict';
 
-// MODULES //
-
-var strides2order = require( '@stdlib/ndarray/base/strides2order' );
-
-
 // MAIN //
 
 /**
@@ -43,6 +38,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * @param {IntegerArray} y.strides - stride lengths
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @param {Function} fcn - unary function to apply to callback return values
 * @param {Callback} clbk - callback
 * @param {*} [thisArg] - callback execution context
@@ -93,12 +89,12 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * };
 *
 * // Apply the unary function:
-* unary2d( x, y, scale, accessor );
+* unary2d( x, y, true, scale, accessor );
 *
 * console.log( y.data );
 * // => <Float64Array>[ 40.0, 60.0, 120.0, 140.0 ]
 */
-function unary2d( x, y, fcn, clbk, thisArg ) {
+function unary2d( x, y, isRowMajor, fcn, clbk, thisArg ) {
 	var xbuf;
 	var ybuf;
 	var dx0;
@@ -123,7 +119,7 @@ function unary2d( x, y, fcn, clbk, thisArg ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( strides2order( sx ) === 1 ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 1 ];
 		S1 = sh[ 0 ];

lib/node_modules/@stdlib/ndarray/base/unary-by/lib/2d_accessors.js

@@ -18,11 +18,6 @@
 
 'use strict';
 
-// MODULES //
-
-var strides2order = require( '@stdlib/ndarray/base/strides2order' );
-
-
 // MAIN //
 
 /**
@@ -45,6 +40,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
 * @param {Array<Function>} y.accessors - data buffer accessors
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @param {Function} fcn - unary function to apply to callback return values
 * @param {Callback} clbk - callback
 * @param {*} [thisArg] - callback execution context
@@ -106,7 +102,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * };
 *
 * // Apply the unary function:
-* unary2d( x, y, scale, cidentityf );
+* unary2d( x, y, true, scale, cidentityf );
 *
 * var v = y.data.get( 0 );
 *
@@ -116,7 +112,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * var im = imagf( v );
 * // returns 20.0
 */
-function unary2d( x, y, fcn, clbk, thisArg ) {
+function unary2d( x, y, isRowMajor, fcn, clbk, thisArg ) {
 	var xbuf;
 	var ybuf;
 	var get;
@@ -143,7 +139,7 @@ function unary2d( x, y, fcn, clbk, thisArg ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( strides2order( sx ) === 1 ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 1 ];
 		S1 = sh[ 0 ];

lib/node_modules/@stdlib/ndarray/base/unary-by/lib/3d.js

@@ -18,11 +18,6 @@
 
 'use strict';
 
-// MODULES //
-
-var strides2order = require( '@stdlib/ndarray/base/strides2order' );
-
-
 // MAIN //
 
 /**
@@ -43,6 +38,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * @param {IntegerArray} y.strides - stride lengths
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @param {Function} fcn - unary function to apply to callback return values
 * @param {Callback} clbk - callback
 * @param {*} [thisArg] - callback execution context
@@ -93,12 +89,12 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * };
 *
 * // Apply the unary function:
-* unary3d( x, y, scale, accessor );
+* unary3d( x, y, true, scale, accessor );
 *
 * console.log( y.data );
 * // => <Float64Array>[ 40.0, 60.0, 120.0, 140.0, 200.0, 220.0 ]
 */
-function unary3d( x, y, fcn, clbk, thisArg ) {
+function unary3d( x, y, isRowMajor, fcn, clbk, thisArg ) {
 	var xbuf;
 	var ybuf;
 	var dx0;
@@ -127,7 +123,7 @@ function unary3d( x, y, fcn, clbk, thisArg ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( strides2order( sx ) === 1 ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 2 ];
 		S1 = sh[ 1 ];

lib/node_modules/@stdlib/ndarray/base/unary-by/lib/3d_accessors.js

@@ -20,11 +20,6 @@
 
 'use strict';
 
-// MODULES //
-
-var strides2order = require( '@stdlib/ndarray/base/strides2order' );
-
-
 // MAIN //
 
 /**
@@ -47,6 +42,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
 * @param {Array<Function>} y.accessors - data buffer accessors
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @param {Function} fcn - unary function to apply to callback return values
 * @param {Callback} clbk - callback
 * @param {*} [thisArg] - callback execution context
@@ -108,7 +104,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * };
 *
 * // Apply the unary function:
-* unary3d( x, y, scale, cidentityf );
+* unary3d( x, y, true, scale, cidentityf );
 *
 * var v = y.data.get( 0 );
 *
@@ -118,7 +114,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * var im = imagf( v );
 * // returns 20.0
 */
-function unary3d( x, y, fcn, clbk, thisArg ) {
+function unary3d( x, y, isRowMajor, fcn, clbk, thisArg ) {
 	var xbuf;
 	var ybuf;
 	var get;
@@ -149,7 +145,7 @@ function unary3d( x, y, fcn, clbk, thisArg ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( strides2order( sx ) === 1 ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 2 ];
 		S1 = sh[ 1 ];

lib/node_modules/@stdlib/ndarray/base/unary-by/lib/4d.js

@@ -20,11 +20,6 @@
 
 /* eslint-disable max-len */
 
-// MODULES //
-
-var strides2order = require( '@stdlib/ndarray/base/strides2order' );
-
-
 // MAIN //
 
 /**
@@ -45,6 +40,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * @param {IntegerArray} y.strides - stride lengths
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @param {Function} fcn - unary function to apply to callback return values
 * @param {Callback} clbk - callback
 * @param {*} [thisArg] - callback execution context
@@ -95,12 +91,12 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * };
 *
 * // Apply the unary function:
-* unary4d( x, y, scale, accessor );
+* unary4d( x, y, true, scale, accessor );
 *
 * console.log( y.data );
 * // => <Float64Array>[ 40.0, 60.0, 120.0, 140.0, 200.0, 220.0 ]
 */
-function unary4d( x, y, fcn, clbk, thisArg ) {
+function unary4d( x, y, isRowMajor, fcn, clbk, thisArg ) {
 	var xbuf;
 	var ybuf;
 	var dx0;
@@ -133,7 +129,7 @@ function unary4d( x, y, fcn, clbk, thisArg ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( strides2order( sx ) === 1 ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 3 ];
 		S1 = sh[ 2 ];

lib/node_modules/@stdlib/ndarray/base/unary-by/lib/4d_accessors.js

@@ -20,11 +20,6 @@
 
 'use strict';
 
-// MODULES //
-
-var strides2order = require( '@stdlib/ndarray/base/strides2order' );
-
-
 // MAIN //
 
 /**
@@ -47,6 +42,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * @param {NonNegativeInteger} y.offset - index offset
 * @param {string} y.order - specifies whether `y` is row-major (C-style) or column-major (Fortran-style)
 * @param {Array<Function>} y.accessors - data buffer accessors
+* @param {boolean} isRowMajor - boolean indicating if provided arrays are in row-major order
 * @param {Function} fcn - unary function to apply to callback return values
 * @param {Callback} clbk - callback
 * @param {*} [thisArg] - callback execution context
@@ -108,7 +104,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * };
 *
 * // Apply the unary function:
-* unary4d( x, y, scale, cidentityf );
+* unary4d( x, y, true, scale, cidentityf );
 *
 * var v = y.data.get( 0 );
 *
@@ -118,7 +114,7 @@ var strides2order = require( '@stdlib/ndarray/base/strides2order' );
 * var im = imagf( v );
 * // returns 20.0
 */
-function unary4d( x, y, fcn, clbk, thisArg ) {
+function unary4d( x, y, isRowMajor, fcn, clbk, thisArg ) {
 	var xbuf;
 	var ybuf;
 	var get;
@@ -153,7 +149,7 @@ function unary4d( x, y, fcn, clbk, thisArg ) {
 	sh = x.shape;
 	sx = x.strides;
 	sy = y.strides;
-	if ( strides2order( sx ) === 1 ) {
+	if ( isRowMajor ) {
 		// For row-major ndarrays, the last dimensions have the fastest changing indices...
 		S0 = sh[ 3 ];
 		S1 = sh[ 2 ];