Skip to content

Commit a61dab3

Browse files
bench(triangular): move random number generation outside the benchmarking loops
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 201de98 commit a61dab3

File tree

26 files changed

+336
-166
lines changed

26 files changed

+336
-166
lines changed

lib/node_modules/@stdlib/stats/base/dists/triangular/cdf/benchmark/benchmark.js

Lines changed: 24 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var Float64Array = require( '@stdlib/array/float64' );
25+
var uniform = require( '@stdlib/random/base/uniform' );
2526
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2627
var EPS = require( '@stdlib/constants/float64/eps' );
2728
var pkg = require( './../package.json' ).name;
@@ -34,17 +35,26 @@ bench( pkg, function benchmark( b ) {
3435
var mode;
3536
var min;
3637
var max;
38+
var len;
3739
var x;
3840
var y;
3941
var i;
4042

43+
len = b.iterations;
44+
min = new Float64Array( len );
45+
max = new Float64Array( len );
46+
mode = new Float64Array( len );
47+
x = new Float64Array( len );
48+
for ( i = 0; i < len; i++ ) {
49+
min[ i ] = uniform( 0.0, 10.0 );
50+
max[ i ] = uniform( min[ i ] + EPS, min[ i ] + 40.0 + EPS );
51+
mode[ i ] = uniform( min[ i ], max[ i ] );
52+
x[ i ] = uniform( 0.0, 30.0 );
53+
}
54+
4155
b.tic();
4256
for ( i = 0; i < b.iterations; i++ ) {
43-
x = randu() * 30.0;
44-
min = randu() * 10.0;
45-
max = min + ( randu() * 40.0 ) + EPS;
46-
mode = min + ( ( max - min ) * randu() );
47-
y = cdf( x, min, max, mode );
57+
y = cdf( x[ i ], min[ i % len ], max[ i % len ], mode[ i % len ] );
4858
if ( isnan( y ) ) {
4959
b.fail( 'should not return NaN' );
5060
}
@@ -62,19 +72,25 @@ bench( pkg+':factory', function benchmark( b ) {
6272
var mode;
6373
var min;
6474
var max;
75+
var len;
6576
var x;
6677
var y;
6778
var i;
6879

80+
len = b.iterations;
6981
min = -1.5;
7082
max = 1.5;
7183
mode = 0.5;
7284
mycdf = cdf.factory( min, max, mode );
85+
x = new Float64Array( len );
86+
87+
for ( i = 0; i < len; i++ ) {
88+
x[ i ] = uniform( -2.0, 0.0 );
89+
}
7390

7491
b.tic();
7592
for ( i = 0; i < b.iterations; i++ ) {
76-
x = ( randu()*2.0 ) - 2.0;
77-
y = mycdf( x );
93+
y = mycdf( x[ i % len ] );
7894
if ( isnan( y ) ) {
7995
b.fail( 'should not return NaN' );
8096
}

0 commit comments

Comments
 (0)