Skip to content

Commit b1944c5

Browse files
committed
refactor: apply code review suggestion
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---
1 parent 34cbfba commit b1944c5

File tree

2 files changed

+6
-20
lines changed

2 files changed

+6
-20
lines changed

lib/node_modules/@stdlib/blas/ext/base/gnansumkbn2/test/test.main.js

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
// MODULES //
2222

2323
var tape = require( 'tape' );
24-
var floor = require( '@stdlib/math/base/special/floor' );
2524
var Float64Array = require( '@stdlib/array/float64' );
2625
var gnansumkbn2 = require( './../lib' );
2726

@@ -102,7 +101,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first
102101
});
103102

104103
tape( 'the function supports a `stride` parameter', function test( t ) {
105-
var N;
106104
var x;
107105
var v;
108106

@@ -119,15 +117,13 @@ tape( 'the function supports a `stride` parameter', function test( t ) {
119117
NaN
120118
];
121119

122-
N = floor( x.length / 2 );
123-
v = gnansumkbn2( N, x, 2 );
120+
v = gnansumkbn2( 5, x, 2 );
124121

125122
t.strictEqual( v, 5.0, 'returns expected value' );
126123
t.end();
127124
});
128125

129126
tape( 'the function supports a negative `stride` parameter', function test( t ) {
130-
var N;
131127
var x;
132128
var v;
133129

@@ -144,8 +140,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t )
144140
2.0
145141
];
146142

147-
N = floor( x.length / 2 );
148-
v = gnansumkbn2( N, x, -2 );
143+
v = gnansumkbn2( 5, x, -2 );
149144

150145
t.strictEqual( v, 5.0, 'returns expected value' );
151146
t.end();
@@ -178,7 +173,6 @@ tape( 'if provided a `stride` parameter equal to `0` and the first element is Na
178173
tape( 'the function supports view offsets', function test( t ) {
179174
var x0;
180175
var x1;
181-
var N;
182176
var v;
183177

184178
x0 = new Float64Array([
@@ -196,9 +190,8 @@ tape( 'the function supports view offsets', function test( t ) {
196190
]);
197191

198192
x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element
199-
N = floor(x1.length / 2);
200193

201-
v = gnansumkbn2( N, x1, 2 );
194+
v = gnansumkbn2( 5, x1, 2 );
202195
t.strictEqual( v, 5.0, 'returns expected value' );
203196

204197
t.end();

lib/node_modules/@stdlib/blas/ext/base/gnansumkbn2/test/test.ndarray.js

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
// MODULES //
2222

2323
var tape = require( 'tape' );
24-
var floor = require( '@stdlib/math/base/special/floor' );
2524
var gnansumkbn2 = require( './../lib/ndarray.js' );
2625

2726

@@ -101,7 +100,6 @@ tape( 'if provided an `N` parameter equal to `1`, the function returns the first
101100
});
102101

103102
tape( 'the function supports a `stride` parameter', function test( t ) {
104-
var N;
105103
var x;
106104
var v;
107105

@@ -118,15 +116,13 @@ tape( 'the function supports a `stride` parameter', function test( t ) {
118116
NaN
119117
];
120118

121-
N = floor( x.length / 2 );
122-
v = gnansumkbn2( N, x, 2, 0 );
119+
v = gnansumkbn2( 5, x, 2, 0 );
123120

124121
t.strictEqual( v, 5.0, 'returns expected value' );
125122
t.end();
126123
});
127124

128125
tape( 'the function supports a negative `stride` parameter', function test( t ) {
129-
var N;
130126
var x;
131127
var v;
132128

@@ -143,8 +139,7 @@ tape( 'the function supports a negative `stride` parameter', function test( t )
143139
2.0
144140
];
145141

146-
N = floor( x.length / 2 );
147-
v = gnansumkbn2( N, x, -2, 8 );
142+
v = gnansumkbn2( 5, x, -2, 8 );
148143

149144
t.strictEqual( v, 5.0, 'returns expected value' );
150145
t.end();
@@ -175,7 +170,6 @@ tape( 'if provided a `stride` parameter equal to `0` and the first element is Na
175170
});
176171

177172
tape( 'the function supports an `offset` parameter', function test( t ) {
178-
var N;
179173
var x;
180174
var v;
181175

@@ -191,9 +185,8 @@ tape( 'the function supports an `offset` parameter', function test( t ) {
191185
NaN,
192186
NaN // 4
193187
];
194-
N = floor( x.length / 2 );
195188

196-
v = gnansumkbn2( N, x, 2, 1 );
189+
v = gnansumkbn2( 5, x, 2, 1 );
197190
t.strictEqual( v, 5.0, 'returns expected value' );
198191

199192
t.end();

0 commit comments

Comments
 (0)