applied reviewed changes

Author: AbhijitRaut04

lib/node_modules/@stdlib/math/base/special/minmax/README.md

@@ -20,7 +20,7 @@ limitations under the License.
 
 # minmax
 
-> Return the minimum and maximum values.
+> Returns the minimum and maximum values.
 
 <!-- Section to include introductory text. Make sure to keep an empty line after the intro `section` element and another before the `/section` close. -->
 
@@ -148,25 +148,25 @@ for ( i = 0; i < 100; i++ ) {
 
 #### stdlib_base_minmax( x, y, &min, &max )
 
-Gives the minimum and maximum value.
+Returns the minimum and maximum value.
 
 ```c
 double min;
 double max;
 stdlib_base_minmax( 4.2, 3.14, &min, &max );
-// min = 3.14, max = 4.2 
 
 stdlib_base_minmax( 0.0, -0.0, &min, &max );
-// min = -0.0, max = 0.0 
 ```
 
 The function accepts the following arguments:
 
 -   **x**: `[in] double` input value.
 -   **y**: `[in] double` input value.
+-   **min**: `[out] double` destination for minimum value.
+-   **max**: `[out] double` destination for maximum value.
 
 ```c
-double stdlib_base_minmax( const double x, const double y, double* min, double* max );
+void stdlib_base_minmax( const double x, const double y, double* min, double* max );
 ```
 
 </section>
@@ -193,10 +193,10 @@ double stdlib_base_minmax( const double x, const double y, double* min, double*
 #include <stdio.h>
 
 int main( void ) {
-    double x;
-    double y;
     double min;
     double max;
+    double x;
+    double y;
     int i;
 
     for ( i = 0; i < 100; i++ ) {

lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.js

@@ -37,10 +37,11 @@ bench( pkg, function benchmark( b ) {
 	var z;
 	var i;
 
+	x = ( randu()*1000.0 ) - 500.0;
+	y = ( randu()*1000.0 ) - 500.0;
+
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = ( randu()*1000.0 ) - 500.0;
-		y = ( randu()*1000.0 ) - 500.0;
 		z = minmax( x, y );
 		if ( z.length !== 2 ) {
 			b.fail( 'should have expected length' );
@@ -63,10 +64,11 @@ bench( pkg+':assign', function benchmark( b ) {
 
 	out = [ 0.0, 0.0 ];
 
+	x = ( randu()*1000.0 ) - 500.0;
+	y = ( randu()*1000.0 ) - 500.0;
+
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = ( randu()*1000.0 ) - 500.0;
-		y = ( randu()*1000.0 ) - 500.0;
 		z = minmax.assign( x, y, out, 1, 0 );
 		if ( z.length !== 2 ) {
 			b.fail( 'should have expected length' );
@@ -86,10 +88,11 @@ bench( pkg+'::min,max', function benchmark( b ) {
 	var z;
 	var i;
 
+	x = ( randu()*1000.0 ) - 500.0;
+	y = ( randu()*1000.0 ) - 500.0;
+
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = ( randu()*1000.0 ) - 500.0;
-		y = ( randu()*1000.0 ) - 500.0;
 		z = [ min( x, y ), max( x, y ) ];
 		if ( z.length !== 2 ) {
 			b.fail( 'should have expected length' );
@@ -111,10 +114,11 @@ bench( pkg+'::min,max,memory_reuse', function benchmark( b ) {
 
 	z = [ 0.0, 0.0 ];
 
+	x = ( randu()*1000.0 ) - 500.0;
+	y = ( randu()*1000.0 ) - 500.0;
+	
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = ( randu()*1000.0 ) - 500.0;
-		y = ( randu()*1000.0 ) - 500.0;
 		z[ 0 ] = min( x, y );
 		z[ 1 ] = max( x, y );
 		if ( z.length !== 2 ) {

lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.native.js

@@ -22,7 +22,7 @@
 
 var resolve = require( 'path' ).resolve;
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var randu = require( '@stdlib/random/base/uniform' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 var pkg = require( './../package.json' ).name;
@@ -44,17 +44,18 @@ bench( pkg+'::native', opts, function benchmark( b ) {
 	var v;
 	var i;
 
+	x = ( randu() * 20.0 ) - 10.0;
+	y = ( randu() * 20.0 ) - 10.0;
+
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
-		x = ( randu() * 20.0 ) - 10.0;
-		y = ( randu() * 20.0 ) - 10.0;
 		v = minmax( x, y );
-		if ( isnan( v[0] ) || isnan( v[1] )) {
+		if ( isnan( v[ 0 ] ) || isnan( v[ 1 ] )) {
 			b.fail( 'should not return NaN' );
 		}
 	}
 	b.toc();
-	if ( isnan( v[0] ) || isnan( v[1] ) ) {
+	if ( isnan( v[ 0 ] ) || isnan( v[ 1 ] ) ) {
 		b.fail( 'should not return NaN' );
 	}
 	b.pass( 'benchmark finished' );

lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/benchmark.c

@@ -91,8 +91,8 @@ static double rand_double( void ) {
 */
 static double benchmark( void ) {
 	double elapsed;
-	double x1[100];
-	double x2[100];
+	double x1[ 100 ];
+	double x2[ 100 ];
 	double min;
 	double max;
 	double t;
@@ -106,13 +106,13 @@ static double benchmark( void ) {
 	t = tic();
 	for ( i = 0; i < ITERATIONS; i++ ) {
 		stdlib_base_minmax( x1[ i % 100 ], x2[ i % 100 ], &min, &max );
-		if ( min != min && max != max ) {
+		if ( min != min || max != max ) {
 			printf( "should not return NaN\n" );
 			break;
 		}
 	}
 	elapsed = tic() - t;
-	if ( min != min && max != max ) {
+	if ( min != min || max != max ) {
 		printf( "should not return NaN\n" );
 	}
 	return elapsed;

lib/node_modules/@stdlib/math/base/special/minmax/examples/c/example.c

@@ -20,14 +20,13 @@
 #include <stdio.h>
 
 int main(void) {
-
-    const double x1[] = { 1.0, 0.45, -0.89, 0.0 / 0.0, -0.78, -0.22, 0.66, 0.11, -0.55, 0.0 };
+	const double x1[] = { 1.0, 0.45, -0.89, 0.0 / 0.0, -0.78, -0.22, 0.66, 0.11, -0.55, 0.0 };
 	const double x2[] = { -0.22, 0.66, 0.0, -0.55, 0.33, 1.0, 0.0 / 0.0, 0.11, 0.45, -0.78 };
 
+	double min;
+	double max;
 	int i;
 	for ( i = 0; i < 10; i++ ) {
-		double min;
-		double max;
 		stdlib_base_minmax( x1[ i ], x2[ i ], &min, &max );
 		printf( "x1[ %d ]: %lf, x2[ %d ]: %lf, minmax( x1[ %d ], x2[ %d ] ): ( %lf, %lf )\n", i, x1[ i ], i, x2[ i ], i, i, min, max );
 	}

lib/node_modules/@stdlib/math/base/special/minmax/include/stdlib/math/base/special/minmax.h

@@ -27,14 +27,9 @@ extern "C" {
 #endif
 
 /**
-* Evaluates the min and max of two values.
-*
-* @param x   First value
-* @param y   Second value
-* @param min   double to store minimum value
-* @param max   double to store maximum value
+* Returns the minimum and maximum values.
 */
-void stdlib_base_minmax(const double x, const double y, double* min, double* max );
+void stdlib_base_minmax( const double x, const double y, double* min, double* max );
 
 #ifdef __cplusplus
 }

lib/node_modules/@stdlib/math/base/special/minmax/lib/native.js

@@ -27,7 +27,7 @@ var addon = require( './../src/addon.node' );
 // MAIN //
 
 /**
-* Returns the minimum and maximum value, ignoring NaN.
+* Returns the minimum and maximum values.
 *
 * @private
 * @param {number} x - first number

lib/node_modules/@stdlib/math/base/special/minmax/manifest.json

@@ -1,73 +1,72 @@
 {
-    "options": {
-      "task": "build"
+  "options": {
+    "task": "build"
+  },
+  "fields": [
+    {
+      "field": "src",
+      "resolve": true,
+      "relative": true
     },
-    "fields": [
-      {
-        "field": "src",
-        "resolve": true,
-        "relative": true
-      },
-      {
-        "field": "include",
-        "resolve": true,
-        "relative": true
-      },
-      {
-        "field": "libraries",
-        "resolve": false,
-        "relative": false
-      },
-      {
-        "field": "libpath",
-        "resolve": true,
-        "relative": false
-      }
-    ],
-    "confs": [
-      {
-        "task": "build",
-        "src": [
-          "./src/main.c"
-        ],
-        "include": [
-          "./include"
-        ],
-        "libraries": [],
-        "libpath": [],
-        "dependencies": [
-          "@stdlib/math/base/napi/binary",
-          "@stdlib/math/base/assert/is-nan"
-        ]
-      },
-      {
-        "task": "benchmark",
-        "src": [
-          "./src/main.c"
-        ],
-        "include": [
-          "./include"
-        ],
-        "libraries": [],
-        "libpath": [],
-        "dependencies": [
-          "@stdlib/math/base/assert/is-nan"
-        ]
-      },
-      {
-        "task": "examples",
-        "src": [
-          "./src/main.c"
-        ],
-        "include": [
-          "./include"
-        ],
-        "libraries": [],
-        "libpath": [],
-        "dependencies": [
-          "@stdlib/math/base/assert/is-nan"
-        ]
-      }
-    ]
-  }
-  
+    {
+      "field": "include",
+      "resolve": true,
+      "relative": true
+    },
+    {
+      "field": "libraries",
+      "resolve": false,
+      "relative": false
+    },
+    {
+      "field": "libpath",
+      "resolve": true,
+      "relative": false
+    }
+  ],
+  "confs": [
+    {
+      "task": "build",
+      "src": [
+        "./src/main.c"
+      ],
+      "include": [
+        "./include"
+      ],
+      "libraries": [],
+      "libpath": [],
+      "dependencies": [
+        "@stdlib/math/base/napi/binary",
+        "@stdlib/math/base/assert/is-nan"
+      ]
+    },
+    {
+      "task": "benchmark",
+      "src": [
+        "./src/main.c"
+      ],
+      "include": [
+        "./include"
+      ],
+      "libraries": [],
+      "libpath": [],
+      "dependencies": [
+        "@stdlib/math/base/assert/is-nan"
+      ]
+    },
+    {
+      "task": "examples",
+      "src": [
+        "./src/main.c"
+      ],
+      "include": [
+        "./include"
+      ],
+      "libraries": [],
+      "libpath": [],
+      "dependencies": [
+        "@stdlib/math/base/assert/is-nan"
+      ]
+    }
+  ]
+}

lib/node_modules/@stdlib/math/base/special/minmax/src/addon.c

@@ -68,6 +68,15 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
 		return NULL;
 	}
 
+	napi_valuetype vtype2;
+	status = napi_typeof( env, argv[ 2 ], &vtype1 );
+	assert( status == napi_ok );
+	if ( vtype2 != napi_number ) {
+		status = napi_throw_type_error( env, NULL, "invalid argument. Third argument must be a number." );
+		assert( status == napi_ok );
+		return NULL;
+	}
+
 	napi_typedarray_type vtype0;
 	size_t len;
 	void *Out;