Skip to content

Commit b440f63

Browse files
chore: changes request in code reviews
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---
1 parent d6e22cf commit b440f63

File tree

7 files changed

+15
-24
lines changed

7 files changed

+15
-24
lines changed

lib/node_modules/@stdlib/stats/base/dists/binomial/kurtosis/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ for ( i = 0; i < 10; i++ ) {
167167

168168
#### stdlib_base_dists_binomial_kurtosis( n, p )
169169

170-
Returns the kurtosis of a binomial distribution.
170+
Returns the [excess kurtosis][kurtosis] of a [binomial][binomial-distribution] distribution with number of trials `n` and success probability `p`.
171171

172172
```c
173173
double out = stdlib_base_dists_binomial_kurtosis( 100, 0.1 );
@@ -176,11 +176,11 @@ double out = stdlib_base_dists_binomial_kurtosis( 100, 0.1 );
176176

177177
The function accepts the following arguments:
178178

179-
- **n**: `[in] int` number of trials.
179+
- **n**: `[in] int32_t` number of trials.
180180
- **p**: `[in] double` success probability.
181181

182182
```c
183-
double stdlib_base_dists_binomial_kurtosis( const int n, const double p );
183+
double stdlib_base_dists_binomial_kurtosis( const int32_t n, const double p );
184184
```
185185
186186
</section>
@@ -220,8 +220,8 @@ int main( void ) {
220220
int i;
221221
222222
for ( i = 0; i < 25; i++ ) {
223-
n = stdlib_base_ceil( random_uniform( 0, 100 ) );
224-
p = random_uniform( 0, 1 );
223+
n = stdlib_base_ceil( random_uniform( 0.0, 100.0 ) );
224+
p = random_uniform( 0.0, 1.0 );
225225
y = stdlib_base_dists_binomial_kurtosis( n, p );
226226
printf( "n: %d, p: %lf, Kurt(X;n,p): %lf\n", n, p, y );
227227
}

lib/node_modules/@stdlib/stats/base/dists/binomial/kurtosis/benchmark/c/benchmark.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ static double benchmark( void ) {
102102
int i;
103103

104104
for ( i = 0; i < 100; i++ ) {
105-
n[ i ] = stdlib_base_ceil( random_uniform( 0, 100 ) );
106-
p[ i ] = random_uniform( 0, 1 );
105+
n[ i ] = stdlib_base_ceil( random_uniform( 0.0, 100.0 ) );
106+
p[ i ] = random_uniform( 0.0, 1.0 );
107107
}
108108

109109
t = tic();

lib/node_modules/@stdlib/stats/base/dists/binomial/kurtosis/examples/c/example.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ int main( void ) {
3434
int i;
3535

3636
for ( i = 0; i < 25; i++ ) {
37-
n = stdlib_base_ceil( random_uniform( 0, 100 ) );
38-
p = random_uniform( 0, 1 );
37+
n = stdlib_base_ceil( random_uniform( 0.0, 100.0 ) );
38+
p = random_uniform( 0.0, 1.0 );
3939
y = stdlib_base_dists_binomial_kurtosis( n, p );
4040
printf( "n: %d, p: %lf, Kurt(X;n,p): %lf\n", n, p, y );
4141
}

lib/node_modules/@stdlib/stats/base/dists/binomial/kurtosis/include/stdlib/stats/base/dists/binomial/kurtosis.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ extern "C" {
2929
#endif
3030

3131
/**
32-
* Returns the kurtosis of a binomial distribution.
32+
* Returns the excess kurtosis of a binomial distribution with number of trials `n` and success probability `p`.
3333
*/
3434
double stdlib_base_dists_binomial_kurtosis( const int32_t n, const double p );
3535

lib/node_modules/@stdlib/stats/base/dists/binomial/kurtosis/lib/native.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,9 @@ var addon = require( './../src/addon.node' );
2626
// MAIN //
2727

2828
/**
29-
* Returns the kurtosis of a binomial distribution.
29+
* Returns the excess kurtosis of a binomial distribution with number of trials `n` and success probability `p`.
3030
*
31+
* @private
3132
* @param {NonNegativeInteger} n - number of trials
3233
* @param {Probability} p - success probability
3334
* @returns {number} excess kurtosis

lib/node_modules/@stdlib/stats/base/dists/binomial/kurtosis/manifest.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@
4040
"dependencies": [
4141
"@stdlib/math/base/napi/binary",
4242
"@stdlib/math/base/assert/is-nan",
43-
"@stdlib/math/base/assert/is-nonnegative-integer",
44-
"@stdlib/constants/float64/pinf",
4543
"@stdlib/math/base/special/ceil"
4644
]
4745
},
@@ -58,8 +56,6 @@
5856
"libpath": [],
5957
"dependencies": [
6058
"@stdlib/math/base/assert/is-nan",
61-
"@stdlib/math/base/assert/is-nonnegative-integer",
62-
"@stdlib/constants/float64/pinf",
6359
"@stdlib/math/base/special/ceil"
6460
]
6561
},
@@ -76,8 +72,6 @@
7672
"libpath": [],
7773
"dependencies": [
7874
"@stdlib/math/base/assert/is-nan",
79-
"@stdlib/math/base/assert/is-nonnegative-integer",
80-
"@stdlib/constants/float64/pinf",
8175
"@stdlib/math/base/special/ceil"
8276
]
8377
}

lib/node_modules/@stdlib/stats/base/dists/binomial/kurtosis/src/main.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818

1919
#include "stdlib/stats/base/dists/binomial/kurtosis.h"
2020
#include "stdlib/math/base/assert/is_nan.h"
21-
#include "stdlib/constants/float64/pinf.h"
22-
#include "stdlib/math/base/assert/is_nonnegative_integer.h"
2321
#include <stdint.h>
2422

2523
/**
@@ -35,15 +33,13 @@
3533
*/
3634
double stdlib_base_dists_binomial_kurtosis( const int32_t n, const double p ) {
3735
if (
38-
stdlib_base_is_nan( n ) ||
3936
stdlib_base_is_nan( p ) ||
40-
n < 0.0 ||
41-
n >= INT32_MAX ||
37+
n < 0 ||
4238
p < 0.0 ||
4339
p > 1.0
4440
) {
4541
return 0.0 / 0.0;
4642
}
47-
double pq = p * ( 1.0 - p );
48-
return ( 1.0 - (6.0 * pq ) ) / ( n * pq );
43+
const double pq = p * ( 1.0 - p );
44+
return ( 1.0 - ( 6.0 * pq ) ) / ( n * pq );
4945
}

0 commit comments

Comments
 (0)