Skip to content

Commit b9af090

Browse files
hrshyahrshya
authored
bench: update random value generation
PR-URL: #6400 Reviewed-by: Philipp Burckhardt <[email protected]>
1 parent 1c89a51 commit b9af090

File tree

18 files changed

+83
-68
lines changed

18 files changed

+83
-68
lines changed

‎lib/node_modules/@stdlib/math/base/special/rcbrtf/benchmark/benchmark.js‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
2626
var pkg = require( './../package.json' ).name;
2727
var rcbrtf = require( './../lib' );
@@ -34,10 +34,13 @@ bench( pkg, function benchmark( b ) {
3434
var y;
3535
var i;
3636

37+
x = uniform( 100, 0.0, 100000.0, {
38+
'dtype': 'float32'
39+
});
40+
3741
b.tic();
3842
for ( i = 0; i < b.iterations; i++ ) {
39-
x = ( randu() * 100000.0 ) - 0.0;
40-
y = rcbrtf( x );
43+
y = rcbrtf( x[ i%x.length ] );
4144
if ( isnanf( y ) ) {
4245
b.fail( 'should not return NaN' );
4346
}

‎lib/node_modules/@stdlib/math/base/special/rcbrtf/benchmark/benchmark.native.js‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2626
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
2727
var tryRequire = require( '@stdlib/utils/try-require' );
2828
var pkg = require( './../package.json' ).name;
@@ -43,10 +43,13 @@ bench( pkg+'::native', opts, function benchmark( b ) {
4343
var y;
4444
var i;
4545

46+
x = uniform( 100, 0.0, 100000.0, {
47+
'dtype': 'float32'
48+
});
49+
4650
b.tic();
4751
for ( i = 0; i < b.iterations; i++ ) {
48-
x = ( randu() * 100000.0 ) - 0.0;
49-
y = rcbrtf( x );
52+
y = rcbrtf( x[ i%x.length ] );
5053
if ( isnanf( y ) ) {
5154
b.fail( 'should not return NaN' );
5255
}

‎lib/node_modules/@stdlib/math/base/special/rcbrtf/benchmark/c/native/benchmark.c‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,17 @@ static float rand_float( void ) {
9292
static double benchmark( void ) {
9393
double elapsed;
9494
double t;
95-
float x;
95+
float x[ 100 ];
9696
float y;
9797
int i;
9898

99+
for ( i = 0; i < 100; i++ ) {
100+
x[ i ] = rand_float() * 100000.0f;
101+
}
102+
99103
t = tic();
100104
for ( i = 0; i < ITERATIONS; i++ ) {
101-
x = rand_float() * 100000.0f;
102-
y = stdlib_base_rcbrtf( x );
105+
y = stdlib_base_rcbrtf( x[ i%100 ] );
103106
if ( y != y ) {
104107
printf( "should not return NaN\n" );
105108
break;

‎lib/node_modules/@stdlib/math/base/special/rcbrtf/test/test.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -439,24 +439,24 @@ tape( 'the function returns `NaN` if provided `NaN`', function test( t ) {
439439

440440
tape( 'the function returns `0.0` if provided `+infinity`', function test( t ) {
441441
var v = rcbrtf( PINF );
442-
t.equal( v, 0.0, 'returns 0.0' );
442+
t.equal( v, 0.0, 'returns expected value' );
443443
t.end();
444444
});
445445

446446
tape( 'the function returns `+infinity` if provided `+0`', function test( t ) {
447447
var v = rcbrtf( +0.0 );
448-
t.equal( v, PINF, 'returns +infinity' );
448+
t.equal( v, PINF, 'returns expected value' );
449449
t.end();
450450
});
451451

452452
tape( 'the function returns `-infinity` if provided `-0`', function test( t ) {
453453
var v = rcbrtf( -0.0 );
454-
t.equal( v, NINF, 'returns -infinity' );
454+
t.equal( v, NINF, 'returns expected value' );
455455
t.end();
456456
});
457457

458458
tape( 'the function returns `0.0` if provided `-infinity`', function test( t ) {
459459
var v = rcbrtf( NINF );
460-
t.equal( v, 0.0, 'returns 0.0' );
460+
t.equal( v, 0.0, 'returns expected value' );
461461
t.end();
462462
});

‎lib/node_modules/@stdlib/math/base/special/rcbrtf/test/test.native.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -448,24 +448,24 @@ tape( 'the function returns `NaN` if provided `NaN`', opts, function test( t ) {
448448

449449
tape( 'the function returns `0.0` if provided `+infinity`', opts, function test( t ) {
450450
var v = rcbrtf( PINF );
451-
t.equal( v, 0.0, 'returns 0.0' );
451+
t.equal( v, 0.0, 'returns expected value' );
452452
t.end();
453453
});
454454

455455
tape( 'the function returns `+infinity` if provided `+0`', opts, function test( t ) {
456456
var v = rcbrtf( +0.0 );
457-
t.equal( v, PINF, 'returns +infinity' );
457+
t.equal( v, PINF, 'returns expected value' );
458458
t.end();
459459
});
460460

461461
tape( 'the function returns `-infinity` if provided `-0`', opts, function test( t ) {
462462
var v = rcbrtf( -0.0 );
463-
t.equal( v, NINF, 'returns -infinity' );
463+
t.equal( v, NINF, 'returns expected value' );
464464
t.end();
465465
});
466466

467467
tape( 'the function returns `0.0` if provided `-infinity`', opts, function test( t ) {
468468
var v = rcbrtf( NINF );
469-
t.equal( v, 0.0, 'returns 0.0' );
469+
t.equal( v, 0.0, 'returns expected value' );
470470
t.end();
471471
});

‎lib/node_modules/@stdlib/math/base/special/rempio2/benchmark/benchmark.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/array/uniform' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2626
var pkg = require( './../package.json' ).name;
2727
var rempio2 = require( './../lib' );
@@ -36,7 +36,7 @@ bench( pkg, function benchmark( b ) {
3636
var i;
3737

3838
y = [ 0.0, 0.0 ];
39-
x = randu( 100, -100.0, 100.0 );
39+
x = uniform( 100, -100.0, 100.0 );
4040

4141
b.tic();
4242
for ( i = 0; i < b.iterations; i++ ) {

‎lib/node_modules/@stdlib/math/base/special/rempio2/benchmark/benchmark.native.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/array/uniform' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2626
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2727
var tryRequire = require( '@stdlib/utils/try-require' );
2828
var pkg = require( './../package.json' ).name;
@@ -45,7 +45,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
4545
var i;
4646

4747
y = [ 0.0, 0.0 ];
48-
x = randu( 100, -100.0, 100.0 );
48+
x = uniform( 100, -100.0, 100.0 );
4949

5050
b.tic();
5151
for ( i = 0; i < b.iterations; i++ ) {

‎lib/node_modules/@stdlib/math/base/special/riemann-zeta/benchmark/benchmark.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/array/uniform' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2626
var EPS = require( '@stdlib/constants/float64/eps' );
2727
var pkg = require( './../package.json' ).name;
@@ -35,7 +35,7 @@ bench( pkg, function benchmark( b ) {
3535
var y;
3636
var i;
3737

38-
x = randu( 100, 1.0 + EPS, 57.0 + EPS );
38+
x = uniform( 100, 1.0 + EPS, 57.0 + EPS );
3939

4040
b.tic();
4141
for ( i = 0; i < b.iterations; i++ ) {

‎lib/node_modules/@stdlib/math/base/special/riemann-zeta/benchmark/benchmark.native.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/array/uniform' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2626
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2727
var EPS = require( '@stdlib/constants/float64/eps' );
2828
var tryRequire = require( '@stdlib/utils/try-require' );
@@ -44,7 +44,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
4444
var y;
4545
var i;
4646

47-
x = randu( 100, 1.0 + EPS, 57.0 + EPS );
47+
x = uniform( 100, 1.0 + EPS, 57.0 + EPS );
4848

4949
b.tic();
5050
for ( i = 0; i < b.iterations; i++ ) {

‎lib/node_modules/@stdlib/math/base/special/rising-factorial/benchmark/benchmark.js‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
25-
var round = require( '@stdlib/math/base/special/round' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
25+
var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
2626
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2727
var pkg = require( './../package.json' ).name;
2828
var risingFactorial = require( './../lib' );
@@ -36,11 +36,12 @@ bench( pkg, function benchmark( b ) {
3636
var y;
3737
var i;
3838

39+
x = uniform( 100, -50.0, 50.0 );
40+
n = discreteUniform( 100, -50, 50 );
41+
3942
b.tic();
4043
for ( i = 0; i < b.iterations; i++ ) {
41-
x = ( randu()*100.0 ) - 50.0;
42-
n = round( ( randu()*100.0 ) - 50.0 );
43-
y = risingFactorial( x, n );
44+
y = risingFactorial( x[ i%x.length ], n[ i%n.length ] );
4445
if ( isnan( y ) ) {
4546
b.fail( 'should not return NaN' );
4647
}

0 commit comments

Comments
 (0)