refactor: apply suggestions from code review

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---

Author: headlessNode

lib/node_modules/@stdlib/array/base/map/README.md

@@ -89,7 +89,7 @@ The callback function is provided the following arguments:
 -   **index**: current element index.
 -   **arr**: input array.
 
-#### map.assign( x, y, fcn\[, thisArg] )
+#### map.assign( x, y, strideX, offsetX, fcn\[, thisArg] )
 
 Applies a callback function to elements in an input array and assigns results to elements in an output array.
 
@@ -102,7 +102,7 @@ var x = [ -1.0, -2.0, -3.0, -4.0 ];
 
 var y = zeros( x.length );
 
-var out = map.assign( x, y, naryFunction( abs, 1 ) );
+var out = map.assign( x, y, 1, 0, naryFunction( abs, 1 ) );
 // returns [ 1.0, 2.0, 3.0, 4.0 ]
 
 var bool = ( out === y );
@@ -113,6 +113,8 @@ The function accepts the following arguments:
 
 -   **x**: input array.
 -   **y**: output array.
+-   **strideX**: stride length for x.
+-   **offsetX**: starting index for x.
 -   **fcn**: callback function.
 -   **thisArg**: callback execution context (_optional_).
 

lib/node_modules/@stdlib/array/base/map/docs/repl.txt

@@ -1,3 +1,4 @@
+
 {{alias}}( x, fcn[, thisArg] )
     Applies a callback function to elements in an input array and assigns
     results to elements in a new output array.
@@ -37,7 +38,7 @@
     [ 1, 2, 3, 4 ]
 
 
-{{alias}}.assign( x, y, fcn[, thisArg] )
+{{alias}}.assign( x, y, strideX, offsetX, fcn[, thisArg] )
     Applies a callback function to elements in an input array and assigns
     results to elements in an output array.
 
@@ -49,6 +50,12 @@
     y: Array|TypedArray|Object
         Output array.
 
+    strideX: integer
+        Stride length for x.
+
+    offsetX: integer
+        Starting index for x.
+
     fcn: Function
         Callback function.
 
@@ -64,7 +71,7 @@
     --------
     > var x = [ -1, -2, -3, -4 ];
     > var y = [ 0, 0, 0, 0 ];
-    > var out = {{alias}}.assign( x, y, {{alias:@stdlib/math/base/special/abs}} )
+    > var out = {{alias}}.assign( x, y, 1, 0, {{alias:@stdlib/math/base/special/abs}} )
     [ 1, 2, 3, 4 ]
     > var bool = ( out === y )
     true

lib/node_modules/@stdlib/array/base/map/docs/types/index.d.ts

@@ -73,56 +73,57 @@ interface Routine {
 	/**
 	* Applies a callback function to elements in an input array and assigns results to elements in a new output array.
 	*
-	* @param x - input array
+	* @param x - input array object
 	* @param fcn - callback function
 	* @param thisArg - callback execution context
 	* @returns output array
 	*
 	* @example
+	* var toAccessorArray = require( '@stdlib/array/to-accessor-array' );
 	* var ones = require( '@stdlib/array/base/ones' );
 	*
 	* function scale( v ) {
-	*     return v * 10;
+	*     return v * 10.0;
 	* }
 	*
 	* var x = ones( 4 );
-	* var y = map( x, scale );
-	* // returns [ 10, 10, 10, 10 ]
+	* var y = map( toAccessorArray( x ), scale );
+	* // returns [ 10.0, 10.0, 10.0, 10.0 ]
 	*/
-	<T = unknown, U = unknown, V = unknown>( x: Collection<T>, fcn: Callback<T, U, V>, thisArg?: ThisParameterType<Callback<T, U, V>> ): Collection<U>;
+	<T = unknown, U = unknown, V = unknown>( x: AccessorArrayLike<T>, fcn: Callback<T, U, V>, thisArg?: ThisParameterType<Callback<T, U, V>> ): AccessorArrayLike<U>;
 
 	/**
 	* Applies a callback function to elements in an input array and assigns results to elements in a new output array.
 	*
-	* @param x - input array object
+	* @param x - input array
 	* @param fcn - callback function
 	* @param thisArg - callback execution context
-	* @returns output array object
+	* @returns output array
 	*
 	* @example
-	* var toAccessorArray = require( '@stdlib/array/to-accessor-array' );
 	* var ones = require( '@stdlib/array/base/ones' );
 	*
 	* function scale( v ) {
-	*     return v * 10;
+	*     return v * 10.0;
 	* }
 	*
-	* var x = toAccessorArray( ones( 4 ) );
+	* var x = ones( 4 );
 	* var y = map( x, scale );
-	* // returns {...}
+	* // returns [ 10.0, 10.0, 10.0, 10.0 ]
 	*/
-	<T = unknown, U = unknown, V = unknown>( x: AccessorArrayLike<T>, fcn: Callback<T, U, V>, thisArg?: ThisParameterType<Callback<T, U, V>> ): AccessorArrayLike<U>;
+	<T = unknown, U = unknown, V = unknown>( x: Collection<T>, fcn: Callback<T, U, V>, thisArg?: ThisParameterType<Callback<T, U, V>> ): Collection<U>;
 
 	/**
 	* Applies a callback function to elements in an input array and assigns results to elements in an output array.
 	*
-	* @param x - input array
-	* @param y - output array
+	* @param x - input array object
+	* @param y - output array object
 	* @param fcn - callback function
 	* @param thisArg - callback execution context
-	* @returns output array
+	* @returns output array object
 	*
 	* @example
+	* var toAccessorArray = require( '@stdlib/array/to-accessor-array' );
 	* var ones = require( '@stdlib/array/base/ones' );
 	* var zeros = require( '@stdlib/array/base/zeros' );
 	*
@@ -132,13 +133,10 @@ interface Routine {
 	* var x = ones( 4 );
 	* var y = zeros( x.length );
 	*
-	* var out = map.assign( x, y, scale );
-	* // returns [ 10, 10, 10, 10 ]
-	*
-	* var bool = ( out === y );
-	* // returns true
+	* var out = map.assign( toAccessorArray( x ), toAccessorArray( y ), scale );
+	* // y => [ 10, 10, 10, 10 ]
 	*/
-	assign<T = unknown, U = unknown, V = unknown>( x: Collection<T>, y: Collection<U>, fcn: Callback<T, U, V>, thisArg?: ThisParameterType<Callback<T, U, V>> ): Collection<U>;
+	assign<T = unknown, U = unknown, V = unknown>( x: AccessorArrayLike<T>, y: AccessorArrayLike<U>, fcn: Callback<T, U, V>, thisArg?: ThisParameterType<Callback<T, U, V>> ): AccessorArrayLike<U>;
 
 	/**
 	* Applies a callback function to elements in an input array and assigns results to elements in an output array.
@@ -150,23 +148,22 @@ interface Routine {
 	* @returns output array
 	*
 	* @example
-	* var toAccessorArray = require( '@stdlib/array/to-accessor-array' );
 	* var ones = require( '@stdlib/array/base/ones' );
 	* var zeros = require( '@stdlib/array/base/zeros' );
 	*
 	* function scale( v ) {
 	*     return v * 10;
 	* }
-	* var x = toAccessorArray( ones( 4 ) );
-	* var y = toAccessorArray( zeros( x.length ) );
+	* var x = ones( 4 );
+	* var y = zeros( x.length );
 	*
 	* var out = map.assign( x, y, scale );
-	* // returns {...}
+	* // returns [ 10, 10, 10, 10 ]
 	*
 	* var bool = ( out === y );
 	* // returns true
 	*/
-	assign<T = unknown, U = unknown, V = unknown>( x: AccessorArrayLike<T>, y: AccessorArrayLike<U>, fcn: Callback<T, U, V>, thisArg?: ThisParameterType<Callback<T, U, V>> ): AccessorArrayLike<U>;
+	assign<T = unknown, U = unknown, V = unknown>( x: Collection<T>, y: Collection<U>, fcn: Callback<T, U, V>, thisArg?: ThisParameterType<Callback<T, U, V>> ): Collection<U>;
 }
 
 /**
@@ -197,14 +194,11 @@ interface Routine {
 *     return v * 10;
 * }
 *
-* var x = toAccessorArray( ones( 4 ) );
-* var y = toAccessorArray( zeros( x.length ) );
-*
-* var out = map.assign( x, y, scale );
-* // returns {...}
+* var x = ones( 4 );
+* var y = zeros( x.length );
 *
-* var bool = ( out === y );
-* // returns true
+* var out = map.assign( toAccessorArray( x ), toAccessorArray( y ), scale );
+* // y => [ 10, 10, 10, 10 ]
 */
 declare var map: Routine;
 

lib/node_modules/@stdlib/array/base/map/lib/assign.js

@@ -31,6 +31,8 @@ var arraylike2object = require( '@stdlib/array/base/arraylike2object' );
 * @private
 * @param {Collection} x - input array
 * @param {Collection} y - output array
+* @param {integer} strideX - stride length for x
+* @param {NonNegativeInteger} offsetX - starting index for x
 * @param {Function} fcn - callback function
 * @param {*} thisArg - callback execution context
 * @returns {Collection} output array
@@ -45,16 +47,20 @@ var arraylike2object = require( '@stdlib/array/base/arraylike2object' );
 *
 * var x = ones( 4 );
 * var y = zeros( x.length );
-* var out = internal( x, y, scale );
+* var out = internal( x, y, 1, 0, scale );
 * // returns [ 10.0, 10.0, 10.0, 10.0 ]
 *
 * var bool = ( out === y );
 * // returns true
 */
-function internal( x, y, fcn, thisArg ) {
+function internal( x, y, strideX, offsetX, fcn, thisArg ) {
+	var ix;
 	var i;
-	for ( i = 0; i < x.length; i++ ) {
-		y[ i ] = fcn.call( thisArg, x[ i ], i, x );
+
+	ix = offsetX;
+	for ( i = 0; i < y.length; i++ ) {
+		y[ i ] = fcn.call( thisArg, x[ ix ], ix, x );
+		ix += strideX;
 	}
 	return y;
 }
@@ -65,6 +71,8 @@ function internal( x, y, fcn, thisArg ) {
 * @private
 * @param {Object} x - input array object
 * @param {Object} y - output array object
+* @param {integer} strideX - stride length for x
+* @param {NonNegativeInteger} offsetX - starting index for x
 * @param {Function} fcn - callback function
 * @param {*} thisArg - callback execution context
 * @returns {Object} output array object
@@ -79,28 +87,29 @@ function internal( x, y, fcn, thisArg ) {
 *     return x * 10.0;
 * }
 *
-* var x = arraylike2object( toAccessorArray( ones( 4 ) ) );
-* var y = arraylike2object( toAccessorArray( zeros( x.data.length ) ) );
-* var out = accessors( x, y, scale );
-* // returns {...}
+* var x = ones( 4 );
+* var y = zeros( x.length );
 *
-* var bool = ( out === y );
-* // returns true
+* var out = accessors( arraylike2object( toAccessorArray( x ) ), arraylike2object( toAccessorArray( y ) ), 1, 0, scale );
+* // y => [ 10.0, 10.0, 10.0, 10.0 ]
 */
-function accessors( x, y, fcn, thisArg ) {
+function accessors( x, y, strideX, offsetX, fcn, thisArg ) {
 	var xdata;
 	var ydata;
 	var xget;
 	var yset;
+	var ix;
 	var i;
 
 	xdata = x.data;
 	ydata = y.data;
 	xget = x.accessors[ 0 ];
 	yset = y.accessors[ 1 ];
 
-	for ( i = 0; i < xdata.length; i++ ) {
-		yset( ydata, i, fcn.call( thisArg, xget( xdata, i ), i, xdata ) );
+	ix = offsetX;
+	for ( i = 0; i < ydata.length; i++ ) {
+		yset( ydata, i, fcn.call( thisArg, xget( xdata, ix ), ix, xdata ) );
+		ix += strideX;
 	}
 	return y;
 }
@@ -113,6 +122,8 @@ function accessors( x, y, fcn, thisArg ) {
 *
 * @param {Collection} x - input array
 * @param {Collection} y - output array
+* @param {integer} strideX - stride length for x
+* @param {NonNegativeInteger} offsetX - starting index for x
 * @param {Function} fcn - callback function
 * @param {*} [thisArg] - callback execution context
 * @returns {Collection} output array
@@ -128,23 +139,23 @@ function accessors( x, y, fcn, thisArg ) {
 * var x = ones( 4 );
 * var y = zeros( x.length );
 *
-* var out = assign( x, y, scale );
+* var out = assign( x, y, 1, 0, scale );
 * // returns [ 10.0, 10.0, 10.0, 10.0 ]
 *
 * var bool = ( out === y );
 * // returns true
 */
-function assign( x, y, fcn, thisArg ) {
+function assign( x, y, strideX, offsetX, fcn, thisArg ) {
 	var xobj;
 	var yobj;
 
 	xobj = arraylike2object( x );
 	yobj = arraylike2object( y );
 	if ( xobj.accessorProtocol || yobj.accessorProtocol ) {
-		accessors( xobj, yobj, fcn, thisArg );
+		accessors( xobj, yobj, strideX, offsetX, fcn, thisArg );
 		return y;
 	}
-	return internal( x, y, fcn, thisArg );
+	return internal( x, y, strideX, offsetX, fcn, thisArg );
 }