Skip to content

Commit c640b9f

Browse files
committed
chore: code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent ab129fe commit c640b9f

File tree

1 file changed

+26
-10
lines changed
  • lib/node_modules/@stdlib/lapack/base/dgebal/lib

1 file changed

+26
-10
lines changed

lib/node_modules/@stdlib/lapack/base/dgebal/lib/base.js

Lines changed: 26 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* limitations under the License.
1717
*/
1818

19-
/* eslint-disable max-len, max-params, max-statements */
19+
/* eslint-disable max-len, max-params, max-statements, max-lines-per-function */
2020

2121
'use strict';
2222

@@ -104,9 +104,14 @@ function dgebal( job, N, A, strideA1, strideA2, offsetA, out, strideOut, offsetO
104104
var ia2;
105105
var ia3;
106106
var ia4;
107+
var oa1;
108+
var oa2;
109+
var oa3;
110+
var oa4;
107111
var ca;
108112
var ra;
109113
var is;
114+
var os;
110115
var c;
111116
var r;
112117
var k;
@@ -184,15 +189,21 @@ function dgebal( job, N, A, strideA1, strideA2, offsetA, out, strideOut, offsetO
184189
}
185190
}
186191

192+
os = offsetScale + ( k * strideScale );
193+
oa1 = offsetA + ( k * strideA2 );
194+
oa2 = offsetA + ( k * strideA2 );
195+
oa3 = offsetA + ( k * strideA1 );
196+
oa4 = offsetA + ( k * strideA1 );
197+
187198
noconv = true;
188199
while ( noconv ) {
189200
// Search for columns isolating an eigenvalue and push them left
190201
noconv = false;
191-
is = offsetScale + ( k * strideScale ); // Follows scale
192-
ia1 = offsetA + ( k * strideA2 ); // Follows `j`th column of A
193-
ia2 = offsetA + ( k * strideA2 ); // Follows `k`th column of A
194-
ia3 = offsetA + ( k * strideA1 ); // Follows `j`th row of A
195-
ia4 = offsetA + ( k * strideA1 ); // Follows `k`th row of A
202+
is = os; // Follows scale
203+
ia1 = oa1; // Follows `j`th column of A
204+
ia2 = oa2; // Follows `k`th column of A
205+
ia3 = oa3; // Follows `j`th row of A
206+
ia4 = oa4; // Follows `k`th row of A
196207

197208
for ( j = k; j <= l; j++ ) {
198209
canSwap = true;
@@ -232,13 +243,18 @@ function dgebal( job, N, A, strideA1, strideA2, offsetA, out, strideOut, offsetO
232243
return 0;
233244
}
234245

246+
os = offsetScale + ( k * strideScale );
247+
oa1 = offsetA + ( k * strideA1 ) + ( k * strideA2 );
248+
oa2 = offsetA + ( k * strideA1 ) + ( k * strideA2 );
249+
oa3 = offsetA + ( k * strideA2 );
250+
235251
// Balance the submatrix in rows K to L, iterative loop for norm reduction (job = 'B')
236252
noconv = true;
237253
while ( noconv ) {
238-
is = offsetScale + ( k * strideScale ); // Follows scale
239-
ia1 = offsetA + ( k * strideA1 ) + ( k * strideA2 ); // Follows A[ k, i ]
240-
ia2 = offsetA + ( k * strideA1 ) + ( k * strideA2 ); // Follows A[ i, k ]
241-
ia3 = offsetA + ( k * strideA2 ); // follows `i`th column of A
254+
is = os; // Follows scale
255+
ia1 = oa1; // Follows A[ k, i ]
256+
ia2 = oa2; // Follows A[ i, k ]
257+
ia3 = oa3; // follows `i`th column of A
242258

243259
noconv = false;
244260
for ( i = k; i <= l; i++ ) {

0 commit comments

Comments
 (0)