Skip to content

Commit c7725bd

Browse files
committed
fix: update implementation to preserve signed zeros
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 08611d0 commit c7725bd

File tree

2 files changed

+46
-13
lines changed

2 files changed

+46
-13
lines changed

lib/node_modules/@stdlib/blas/ext/base/dnannsumors/lib/ndarray.js

Lines changed: 28 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,36 +49,54 @@ var isnan = require( '@stdlib/math/base/assert/is-nan' );
4949
function dnannsumors( N, x, strideX, offsetX, out, strideOut, offsetOut ) {
5050
var sum;
5151
var ix;
52+
var io;
5253
var n;
54+
var v;
5355
var i;
5456

55-
sum = 0.0;
57+
io = offsetOut;
5658
if ( N <= 0 ) {
57-
out[ offsetOut ] = sum;
58-
out[ offsetOut+strideOut ] = 0;
59+
out[ io ] = 0.0;
60+
out[ io+strideOut ] = 0;
5961
return out;
6062
}
6163
ix = offsetX;
6264
if ( strideX === 0 ) {
6365
if ( isnan( x[ ix ] ) ) {
64-
out[ offsetOut ] = sum;
65-
out[ offsetOut+strideOut ] = 0;
66+
out[ io ] = 0.0;
67+
out[ io+strideOut ] = 0;
6668
return out;
6769
}
68-
out[ offsetOut ] = x[ ix ] * N;
69-
out[ offsetOut+strideOut ] = N;
70+
out[ io ] = x[ ix ] * N;
71+
out[ io+strideOut ] = N;
7072
return out;
7173
}
72-
n = 0;
74+
// Find the first non-NaN element...
7375
for ( i = 0; i < N; i++ ) {
76+
v = x[ ix ];
77+
if ( isnan( v ) === false ) {
78+
break;
79+
}
80+
ix += strideX;
81+
}
82+
if ( i === N ) {
83+
out[ io ] = 0.0;
84+
out[ io+strideOut ] = 0;
85+
return out;
86+
}
87+
n = 1;
88+
sum = v;
89+
ix += strideX;
90+
i += 1;
91+
for ( ; i < N; i++ ) {
7492
if ( isnan( x[ ix ] ) === false ) {
7593
sum += x[ ix ];
7694
n += 1;
7795
}
7896
ix += strideX;
7997
}
80-
out[ offsetOut ] = sum;
81-
out[ offsetOut+strideOut ] = n;
98+
out[ io ] = sum;
99+
out[ io+strideOut ] = n;
82100
return out;
83101
}
84102

lib/node_modules/@stdlib/blas/ext/base/dnannsumors/src/main.c

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,21 +49,36 @@ double API_SUFFIX(stdlib_strided_dnannsumors_ndarray)( const CBLAS_INT N, const
4949
CBLAS_INT ix;
5050
CBLAS_INT i;
5151
double sum;
52+
double v;
5253

53-
sum = 0.0;
5454
*n = 0;
5555
if ( N <= 0 ) {
56-
return sum;
56+
return 0.0;
5757
}
5858
ix = offsetX;
5959
if ( strideX == 0 ) {
6060
if ( stdlib_base_is_nan( X[ ix ] ) ) {
61-
return sum;
61+
return 0.0;
6262
}
6363
*n += N;
6464
return X[ ix ] * N;
6565
}
66+
// Find the first non-NaN element...
6667
for ( i = 0; i < N; i++ ) {
68+
v = X[ ix ];
69+
if ( !stdlib_base_is_nan( v ) ) {
70+
break;
71+
}
72+
ix += strideX;
73+
}
74+
if ( i == N ) {
75+
return 0.0;
76+
}
77+
*n += 1;
78+
sum = v;
79+
ix += strideX;
80+
i += 1;
81+
for ( ; i < N; i++ ) {
6782
if ( !stdlib_base_is_nan( X[ ix ] ) ) {
6883
sum += X[ ix ];
6984
*n += 1;

0 commit comments

Comments
 (0)