fix: add missing checks and tests

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: kgryte

lib/node_modules/@stdlib/blas/base/dsyr/lib/ndarray.native.js

@@ -44,6 +44,8 @@ var addon = require( './../src/addon.node' );
 * @throws {TypeError} first argument must specify whether to reference the lower or upper triangular matrix
 * @throws {RangeError} second argument must be a nonnegative integer
 * @throws {RangeError} fifth argument must be non-zero
+* @throws {RangeError} eighth argument must be non-zero
+* @throws {RangeError} ninth argument must be non-zero
 * @returns {Float64Array} `A`
 *
 * @example
@@ -65,6 +67,12 @@ function dsyr( uplo, N, alpha, x, strideX, offsetX, A, strideA1, strideA2, offse
 	if ( strideX === 0 ) {
 		throw new RangeError( format( 'invalid argument. Fifth argument must be non-zero. Value: `%d`.', strideX ) );
 	}
+	if ( strideA1 === 0 ) {
+		throw new RangeError( format( 'invalid argument. Eighth argument must be non-zero. Value: `%d`.', strideA1 ) );
+	}
+	if ( strideA2 === 0 ) {
+		throw new RangeError( format( 'invalid argument. Ninth argument must be non-zero. Value: `%d`.', strideA2 ) );
+	}
 	// Check if we can early return...
 	if ( N === 0 || alpha === 0.0 ) {
 		return A;

lib/node_modules/@stdlib/blas/base/dsyr/test/test.ndarray.native.js

@@ -35,6 +35,7 @@ var rl = require( './fixtures/row_major_l.json' );
 var rxp = require( './fixtures/row_major_xp.json' );
 var rxn = require( './fixtures/row_major_xn.json' );
 var roa = require( './fixtures/row_major_oa.json' );
+var rox = require( './fixtures/row_major_ox.json' );
 var rsa1sa2 = require( './fixtures/row_major_sa1_sa2.json' );
 var rsa1nsa2 = require( './fixtures/row_major_sa1n_sa2.json' );
 var rsa1sa2n = require( './fixtures/row_major_sa1_sa2n.json' );
@@ -46,6 +47,7 @@ var cl = require( './fixtures/column_major_l.json' );
 var cxp = require( './fixtures/column_major_xp.json' );
 var cxn = require( './fixtures/column_major_xn.json' );
 var coa = require( './fixtures/column_major_oa.json' );
+var cox = require( './fixtures/column_major_ox.json' );
 var csa1sa2 = require( './fixtures/column_major_sa1_sa2.json' );
 var csa1nsa2 = require( './fixtures/column_major_sa1n_sa2.json' );
 var csa1sa2n = require( './fixtures/column_major_sa1_sa2n.json' );
@@ -148,6 +150,52 @@ tape( 'the function throws an error if provided an invalid fifth argument', opts
 	}
 });
 
+tape( 'the function throws an error if provided an invalid eighth argument', opts, function test( t ) {
+	var values;
+	var data;
+	var i;
+
+	data = ru;
+
+	values = [
+		0
+	];
+
+	for ( i = 0; i < values.length; i++ ) {
+		t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
+	}
+	t.end();
+
+	function badValue( value ) {
+		return function badValue() {
+			dsyr( data.uplo, data.N, data.alpha, new Float64Array( data.x ), data.strideX, data.offsetX, new Float64Array( data.A ), value, data.strideA2, data.offsetA );
+		};
+	}
+});
+
+tape( 'the function throws an error if provided an invalid ninth argument', opts, function test( t ) {
+	var values;
+	var data;
+	var i;
+
+	data = ru;
+
+	values = [
+		0
+	];
+
+	for ( i = 0; i < values.length; i++ ) {
+		t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
+	}
+	t.end();
+
+	function badValue( value ) {
+		return function badValue() {
+			dsyr( data.uplo, data.N, data.alpha, new Float64Array( data.x ), data.strideX, data.offsetX, new Float64Array( data.A ), data.strideA1, value, data.offsetA );
+		};
+	}
+});
+
 tape( 'the function performs the symmetric rank 1 operation `A = α*x*x^T + A` (row-major, upper)', opts, function test( t ) {
 	var expected;
 	var data;
@@ -593,6 +641,48 @@ tape( 'the function supports specifying a negative `x` stride (column-major)', o
 	t.end();
 });
 
+tape( 'the function supports specifying an `x` offset (row-major)', opts, function test( t ) {
+	var expected;
+	var data;
+	var out;
+	var a;
+	var x;
+
+	data = rox;
+
+	a = new Float64Array( data.A );
+	x = new Float64Array( data.x );
+
+	expected = new Float64Array( data.A_out );
+
+	out = dsyr( data.uplo, data.N, data.alpha, x, data.strideX, data.offsetX, a, data.strideA1, data.strideA2, data.offsetA );
+	t.strictEqual( out, a, 'returns expected value' );
+	t.deepEqual( out, expected, 'returns expected value' );
+
+	t.end();
+});
+
+tape( 'the function supports specifying an `x` offset (column-major)', opts, function test( t ) {
+	var expected;
+	var data;
+	var out;
+	var a;
+	var x;
+
+	data = cox;
+
+	a = new Float64Array( data.A );
+	x = new Float64Array( data.x );
+
+	expected = new Float64Array( data.A_out );
+
+	out = dsyr( data.uplo, data.N, data.alpha, x, data.strideX, data.offsetX, a, data.strideA1, data.strideA2, data.offsetA );
+	t.strictEqual( out, a, 'returns expected value' );
+	t.deepEqual( out, expected, 'returns expected value' );
+
+	t.end();
+});
+
 tape( 'the function supports complex access patterns (row-major)', opts, function test( t ) {
 	var expected;
 	var data;