Skip to content

Commit ca13113

Browse files
committed
refactor: test for an array of marks and enable event listening
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 4134161 commit ca13113

File tree

1 file changed

+3
-2
lines changed
  • lib/node_modules/@stdlib/plot/vega/builder/lib/marks

1 file changed

+3
-2
lines changed

lib/node_modules/@stdlib/plot/vega/builder/lib/marks/set.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323
// MODULES //
2424

2525
var logger = require( 'debug' );
26-
var isArrayLikeObject = require( '@stdlib/assert/is-array-like-object' );
26+
var isMarkArray = require( '@stdlib/plot/vega/base/assert/is-mark-array' );
27+
var isEmptyArrayLikeObject = require( '@stdlib/assert/is-empty-array-like-object' );
2728
var hasEqualValues = require( '@stdlib/array/base/assert/has-equal-values' );
2829
var copy = require( '@stdlib/array/base/copy' );
2930
var format = require( '@stdlib/string/format' );
@@ -47,7 +48,7 @@ var debug = logger( 'vega:builder:set:'+prop.name );
4748
* @returns {void}
4849
*/
4950
function set( value ) {
50-
if ( !isArrayLikeObject( value ) ) { // FIXME: validate array of marks or an empty array
51+
if ( !isMarkArray( value ) && !isEmptyArrayLikeObject( value ) ) {
5152
throw new TypeError( format( 'invalid assignment. `%s` must be an array of marks. Value: `%s`.', prop.name, value ) );
5253
}
5354
value = copy( value );

0 commit comments

Comments
 (0)