refactor: use plot/base/server for serving content

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: kgryte

lib/node_modules/@stdlib/plot/base/view/lib/electron/index.js

@@ -30,7 +30,7 @@ var ENV = require( '@stdlib/process/env' );
 var copy = require( '@stdlib/utils/copy' );
 var merge = require( '@stdlib/utils/merge' );
 var readFileSync = require( '@stdlib/fs/read-file' ).sync;
-var httpServer = require( '@stdlib/net/disposable-http-server' );
+var createServer = require( '@stdlib/plot/base/server' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 
 
@@ -54,6 +54,7 @@ var electron = tryRequire( '@stdlib/electron' );
 * @throws {Error} Electron must be properly installed
 */
 function view( plot, html ) {
+	var server;
 	var index;
 	var opts;
 	var css;
@@ -76,31 +77,29 @@ function view( plot, html ) {
 	css = readFileSync( css, opts );
 	index = index.replace( /\{\{reset\}\}/, css );
 
-	debug( 'Creating a disposable HTTP server...' );
-	opts = {
-		'html': index,
-		'open': false
-	};
-	httpServer( opts, onReady );
+	debug( 'Creating a server...' );
+	createServer( router, onReady );
 
 	/**
 	* Callback invoked once a server is ready to receive requests.
 	*
 	* @private
 	* @param {(Error|null)} error - error object
-	* @param {Server} server - HTTP server
+	* @param {Server} _server - server instance
 	* @throws {Error} unexpected error
 	*/
-	function onReady( error, server ) {
+	function onReady( error, _server ) {
 		var child;
 		var addr;
 		var opts;
 		var env;
 		if ( error ) {
 			throw error;
 		}
+		server = _server;
+
 		addr = server.address();
-		debug( 'HTTP server initialized. Server is listening for requests on %s:%d.', addr.address, addr.port );
+		debug( 'Server initialized. Server is listening for requests on %s:%d.', addr.address, addr.port );
 
 		debug( 'Electron executable: %s.', electron );
 
@@ -111,26 +110,51 @@ function view( plot, html ) {
 			'PLOT_WIDTH': plot.width,
 			'PLOT_HEIGHT': plot.height,
 			'PLOT_APP_PATH': __dirname,
-			'PLOT_MIN_WIDTH': 100,
-			'PLOT_MIN_HEIGHT': 100,
 			'PLOT_TITLE': plot.title || 'stdlib'
 		};
 		debug( 'Electron process environment variables: %s.', JSON.stringify( env ) );
 
 		opts = {
 			'cwd': __dirname,
 			'detached': true,
-			'stdio': 'ignore'
+			'stdio': 'ignore' // NOTE: when debugging, set to 'inherit'
 		};
 		debug( 'Electron process options: %s.', JSON.stringify( opts ) );
 
 		// Merge the current process' environment variables:
 		opts.env = merge( {}, copy( ENV ), env );
+		opts.env.DEBUG = '*';
 
 		debug( 'Spawning an electron process...' );
 		child = spawn( electron, [ './main.js' ], opts );
 		child.unref();
 	}
+
+	/**
+	* Request handler.
+	*
+	* @private
+	* @param {IncomingMessage} request - HTTP request object
+	* @param {ServerResponse} response - HTTP response object
+	* @returns {void}
+	*/
+	function router( request, response ) {
+		debug( 'Received a request for %s', request.url );
+		response.once( 'finish', onFinish );
+		response.write( index );
+		response.end();
+	}
+
+	/**
+	* Callback invoked once the server should close.
+	*
+	* @private
+	*/
+	function onFinish() {
+		debug( 'Finished serving content.' );
+		debug( 'Closing the server...' );
+		server.close();
+	}
 }
 
 

lib/node_modules/@stdlib/plot/base/view/lib/electron/main.js

@@ -16,19 +16,30 @@
 * limitations under the License.
 */
 
+/* eslint-disable max-len */
+
 'use strict';
 
 // MODULES //
 
 var logger = require( 'debug' );
-var app = require( 'electron' ).app; // eslint-disable-line stdlib/require-file-extensions
-var BrowserWindow = require( 'electron' ).BrowserWindow; // eslint-disable-line stdlib/require-file-extensions
+var electron = require( 'electron' ); // eslint-disable-line stdlib/require-file-extensions
 var ENV = require( '@stdlib/process/env' );
 
 
 // VARIABLES //
 
 var debug = logger( 'plot:view:electron:main-process' );
+
+// Define convenience aliases:
+var BrowserWindow = electron.BrowserWindow;
+var session = electron.session;
+var app = electron.app;
+
+// Define the error code which arises when attempting to use a self-signed certificate over localhost:
+var ERR_CERT_AUTHORITY_INVALID = -202; // eslint-disable-line id-length
+
+// Initialize a reference to the main window which will be created:
 var mainWindow = null;
 
 
@@ -43,36 +54,52 @@ function createWindow() {
 	var opts;
 	var url;
 
+	// Intercept certificate verification to allow using a local self-signed certificate:
+	session.defaultSession.setCertificateVerifyProc( onVerifyCertificate );
+
 	opts = {
 		'width': parseInt( ENV.PLOT_WIDTH, 10 ) + 80,
 		'height': parseInt( ENV.PLOT_HEIGHT, 10 ) + 20,
 		'title': ENV.PLOT_TITLE,
 
-		// 'minWidth': parseInt( ENV.PLOT_MIN_WIDTH, 10 ), // TODO: needed?
-
-		// 'minHeight': parseInt( ENV.PLOT_MIN_HEIGHT, 10 ), // TODO: needed?
-
 		// 'titleBarStyle': 'hidden-inset', // hide title bar on OS X
 
 		'useContentSize': true // specify web page size only considering the content
 	};
-	debug( 'Creating a new browser window configured with the following options: %s.', JSON.stringify( opts ) );
+	debug( 'Creating a new window configured with the following options: %s.', JSON.stringify( opts ) );
 	mainWindow = new BrowserWindow( opts );
 
+	// mainWindow.webContents.openDevTools(); // NOTE: uncomment to allow using the inspector in the Electron window
+
 	mainWindow.on( 'close', onClose );
 
-	url = 'http://'+ENV.SERVER_ADDRESS+':'+ENV.SERVER_PORT+'/index.html';
+	url = 'https://'+ENV.SERVER_ADDRESS+':'+ENV.SERVER_PORT+'/index.html';
 	debug( 'Loading %s.', url );
 	mainWindow.loadURL( url );
 }
 
+/**
+* Callback invoked when attempting to verify a certificate.
+*
+* @private
+* @param {Request} request - request object
+* @param {Callback} clbk - callback to invoke upon verification
+* @returns {void}
+*/
+function onVerifyCertificate( request, clbk ) {
+	if ( request.errorCode === ERR_CERT_AUTHORITY_INVALID && request.hostname === ENV.SERVER_ADDRESS ) {
+		return clbk( 0 ); // allow
+	}
+	return clbk( -3 ); // use default verification result
+}
+
 /**
 * Callback invoked once a window closes.
 *
 * @private
 */
 function onClose() {
-	debug( 'Window closed. Dereferencing window object to allow for GC...' );
+	debug( 'Window closed. De-referencing window object to allow for garbage collection...' );
 	mainWindow = null;
 }