Skip to content

Commit cf02567

Browse files
committed
build: address PR feedback
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: passed - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 7ac1308 commit cf02567

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/scripts/check_tracking_issue_closure

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ repo_owner="stdlib-js"
5959
repo_name="stdlib"
6060

6161
# Regular expressions for auto-closing language:
62-
closing_keywords="(resolves|closes|fixes|resolved|closed|fixed)"
62+
closing_keywords="(close|closes|closed|fix|fixes|fixed|resolve|resolves|resolved)"
6363

6464
# Unique identifier for our bot comments:
6565
comment_identifier="<!-- stdlib-bot-tracking-issue-closure-check -->"
@@ -188,12 +188,14 @@ post_comment() {
188188
I noticed your PR description contains closing keywords (\"Resolves\", \"Closes\", or \"Fixes\") referencing a \"Tracking Issue\".
189189
190190
**Why this matters:**
191-
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged.
191+
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged. For more information, see [GitHub's documentation on using keywords in issues and pull requests][github-keywords].
192192
193193
**Required action:**
194194
Use \"Progresses\" instead to reference the tracking issue without automatically closing it.
195195
196-
Thank you for your contribution to the project!"
196+
Thank you for your contribution to the project!
197+
198+
[github-keywords]: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests"
197199

198200
# Create properly escaped JSON payload using jq
199201
json_payload=$(jq -n --arg body "$comment_body" '{"body": $body}')

0 commit comments

Comments
 (0)