Skip to content

Commit d27d06c

Browse files
committed
test: fix ulp difference
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent bf5c3bc commit d27d06c

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

lib/node_modules/@stdlib/math/base/special/gammainc/test/test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ tape( 'the function correctly evaluates the lower incomplete gamma function for
108108
b2 = isnan( expected[ i ] );
109109
t.strictEqual( b1, b2, 'returns expected value' );
110110
if ( !b1 || !b2 ) {
111-
// TODO: The difference is larger here as compared to the native tests. This is likely because the C implementation follows the latest Boost implementation, unlike the JS implementation.
112111
t.strictEqual( ulpdiff( actual, expected[ i ] ) <= 45, true, 'returns expected value within 45 ulp' );
113112
}
114113
}
@@ -499,7 +498,6 @@ tape( 'the function correctly evaluates the upper incomplete gamma function for
499498
b2 = isnan( expected[ i ] );
500499
t.strictEqual( b1, b2, 'returns expected value' );
501500
if ( !b1 || !b2 ) {
502-
// TODO: The difference is larger here as compared to the native tests. This is likely because the C implementation follows the latest Boost implementation, unlike the JS implementation.
503501
t.strictEqual( ulpdiff( actual, expected[ i ] ) <= 134, true, 'returns expected value within 131 ulp' );
504502
}
505503
}

lib/node_modules/@stdlib/math/base/special/gammainc/test/test.native.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ tape( 'the function correctly evaluates the lower incomplete gamma function for
117117
b2 = isnan( expected[ i ] );
118118
t.strictEqual( b1, b2, 'returns expected value' );
119119
if ( !b1 || !b2 ) {
120-
t.strictEqual( ulpdiff( actual, expected[ i ] ) <= 44, true, 'returns expected value within 44 ulp' );
120+
t.strictEqual( ulpdiff( actual, expected[ i ] ) <= 45, true, 'returns expected value within 45 ulp' );
121121
}
122122
}
123123
t.end();
@@ -507,7 +507,7 @@ tape( 'the function correctly evaluates the upper incomplete gamma function for
507507
b2 = isnan( expected[ i ] );
508508
t.strictEqual( b1, b2, 'returns expected value' );
509509
if ( !b1 || !b2 ) {
510-
t.strictEqual( ulpdiff( actual, expected[ i ] ) <= 130, true, 'returns expected value within 130 ulp' );
510+
t.strictEqual( ulpdiff( actual, expected[ i ] ) <= 134, true, 'returns expected value within 131 ulp' );
511511
}
512512
}
513513
t.end();

0 commit comments

Comments
 (0)