Skip to content

Commit d55df5e

Browse files
committed
fixup! refactor: updated accessor implemntation to avoid duplication
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent cf80425 commit d55df5e

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

lib/node_modules/@stdlib/stats/base/varianceyc/lib/accessors.js

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@
4545
* var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' );
4646
* var arraylike2object = require( '@stdlib/array/base/arraylike2object' );
4747
*
48-
* var x = toAccessorArray( [ 1.0, -2.0, 2.0 ] );
48+
* var x = toAccessorArray( [ 1.0, -2.0, -4.0, 5.0, 0.0, 3.0 ] );
4949
*
5050
* var v = varianceyc( x.length, 1, arraylike2object( x ), 1, 0 );
51-
* // returns ~4.3333
51+
* // returns 10.7
5252
*/
5353
function varianceyc( N, correction, x, strideX, offsetX ) {
5454
var xbuf;
@@ -62,12 +62,6 @@ function varianceyc( N, correction, x, strideX, offsetX ) {
6262
var i;
6363

6464
n = N - correction;
65-
if ( N <= 0 || n <= 0.0 ) {
66-
return NaN;
67-
}
68-
if ( N === 1 || strideX === 0 ) {
69-
return 0.0;
70-
}
7165

7266
// Cache references to array data:
7367
xbuf = x.data;

lib/node_modules/@stdlib/stats/base/varianceyc/lib/ndarray.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,6 @@ function varianceyc( N, correction, x, strideX, offsetX ) {
6363
var i;
6464
var o;
6565

66-
o = arraylike2object( x );
67-
if ( o.accessorProtocol ) {
68-
return accessors( N, correction, o, strideX, offsetX );
69-
}
70-
7166
n = N - correction;
7267
if ( N <= 0 || n <= 0.0 ) {
7368
return NaN;
@@ -76,6 +71,11 @@ function varianceyc( N, correction, x, strideX, offsetX ) {
7671
return 0.0;
7772
}
7873

74+
o = arraylike2object( x );
75+
if ( o.accessorProtocol ) {
76+
return accessors( N, correction, o, strideX, offsetX );
77+
}
78+
7979
sum = x[ offsetX ];
8080
ix = offsetX + strideX;
8181
S = 0.0;

0 commit comments

Comments
 (0)