refactor!: modify C implementation to accept float instead of int32 in math/base/special/nonfibonaccif

This commit updates the signature of the C API to accept a float rather than int32. The rationale was so that users get the same results/behavior in both JavaScript and C. This arose in the context of ufuncs, where the diverging type signatures meant differences in what dtypes would be permissible. Instead, we decided to unify and ensure the behavior is consistent.

BREAKING CHANGE: update signature to accept floats

User code should behave similarly in the primary case of providing integer-valued input values. However, no longer will real-values truncate. Now, real-valued inputs will result in `NaN`, which is, arguably, better behavior, as real-to-integer truncation can be a source of silent bugs.

PR-URL: #7960
Reviewed-by: Athan Reines <[email protected]>

Author: gunjjoshi

lib/node_modules/@stdlib/math/base/special/nonfibonaccif/README.md

@@ -151,19 +151,19 @@ for ( i = 1; i < 100; i++ ) {
 Computes the nth non-Fibonacci single-precision floating-point number.
 
 ```c
-float out = stdlib_base_nonfibonaccif( 1 );
+float out = stdlib_base_nonfibonaccif( 1.0f );
 // returns 4.0f
 
-out = stdlib_base_nonfibonaccif( 2 );
+out = stdlib_base_nonfibonaccif( 2.0f );
 // returns 6.0f
 ```
 
 The function accepts the following arguments:
 
--   **x**: `[in] int32_t` input value.
+-   **x**: `[in] float` input value.
 
 ```c
-float stdlib_base_nonfibonaccif( const int32_t x );
+float stdlib_base_nonfibonaccif( const float x );
 ```
 
 </section>
@@ -189,10 +189,12 @@ float stdlib_base_nonfibonaccif( const int32_t x );
 #include <stdio.h>
 
 int main( void ) {
-    int i;
+    float i;
+    float v;
 
-    for ( i = 1; i < 12; i++ ) {
-        printf( "x: %i => result: %f\n", i, stdlib_base_nonfibonaccif( i ) );
+    for ( i = 1.0f; i < 12.0f; i++ ) {
+        v = stdlib_base_nonfibonaccif( i );
+        printf( "nonfibonaccif(%f) = %f\n", i, v );
     }
 }
 ```

lib/node_modules/@stdlib/math/base/special/nonfibonaccif/benchmark/c/native/benchmark.c

@@ -90,13 +90,13 @@ static float rand_float( void ) {
 */
 static double benchmark( void ) {
 	double elapsed;
-	int x[ 100 ];
+	float x[ 100 ];
 	double t;
 	float y;
 	int i;
 
 	for ( i = 0; i < 100; i++ ) {
-		x[ i ] = (int)floorf( ( 100.0f * rand_float() ) + 1.0f );
+		x[ i ] = floorf( ( 100.0f * rand_float() ) + 1.0f );
 	}
 
 	t = tic();

lib/node_modules/@stdlib/math/base/special/nonfibonaccif/examples/c/example.c

@@ -20,9 +20,11 @@
 #include <stdio.h>
 
 int main( void ) {
-	int i;
+	float i;
+	float v;
 
-	for ( i = 1; i < 12; i++ ) {
-		printf( "x: %i => result: %f\n", i, stdlib_base_nonfibonaccif( i ) );
+	for ( i = 1.0f; i < 12.0f; i++ ) {
+		v = stdlib_base_nonfibonaccif( i );
+		printf( "nonfibonaccif(%f) = %f\n", i, v );
 	}
 }

lib/node_modules/@stdlib/math/base/special/nonfibonaccif/include/stdlib/math/base/special/nonfibonaccif.h

@@ -19,8 +19,6 @@
 #ifndef STDLIB_MATH_BASE_SPECIAL_NONFIBONACCIF_H
 #define STDLIB_MATH_BASE_SPECIAL_NONFIBONACCIF_H
 
-#include <stdint.h>
-
 /*
 * If C++, prevent name mangling so that the compiler emits a binary file having undecorated names, thus mirroring the behavior of a C compiler.
 */
@@ -32,7 +30,7 @@ extern "C"
 /**
 * Computes the nth non-Fibonacci single-precision floating-point number.
 */
-float stdlib_base_nonfibonaccif( const int32_t n );
+float stdlib_base_nonfibonaccif( const float n );
 
 #ifdef __cplusplus
 }

lib/node_modules/@stdlib/math/base/special/nonfibonaccif/manifest.json

@@ -39,7 +39,9 @@
         "@stdlib/math/base/napi/unary",
         "@stdlib/constants/float32/nan",
         "@stdlib/math/base/special/floorf",
-        "@stdlib/math/base/special/lnf"
+        "@stdlib/math/base/special/lnf",
+        "@stdlib/math/base/assert/is-integerf",
+        "@stdlib/constants/float32/pinf"
       ]
     },
     {
@@ -55,7 +57,9 @@
       "dependencies": [
         "@stdlib/constants/float32/nan",
         "@stdlib/math/base/special/floorf",
-        "@stdlib/math/base/special/lnf"
+        "@stdlib/math/base/special/lnf",
+        "@stdlib/math/base/assert/is-integerf",
+        "@stdlib/constants/float32/pinf"
       ]
     },
     {
@@ -71,7 +75,9 @@
       "dependencies": [
         "@stdlib/constants/float32/nan",
         "@stdlib/math/base/special/floorf",
-        "@stdlib/math/base/special/lnf"
+        "@stdlib/math/base/special/lnf",
+        "@stdlib/math/base/assert/is-integerf",
+        "@stdlib/constants/float32/pinf"
       ]
     }
   ]

lib/node_modules/@stdlib/math/base/special/nonfibonaccif/src/addon.c

@@ -19,4 +19,4 @@
 #include "stdlib/math/base/special/nonfibonaccif.h"
 #include "stdlib/math/base/napi/unary.h"
 
-STDLIB_MATH_BASE_NAPI_MODULE_I_F( stdlib_base_nonfibonaccif )
+STDLIB_MATH_BASE_NAPI_MODULE_F_F( stdlib_base_nonfibonaccif )

lib/node_modules/@stdlib/math/base/special/nonfibonaccif/src/main.c

@@ -17,10 +17,11 @@
 */
 
 #include "stdlib/math/base/special/nonfibonaccif.h"
+#include "stdlib/math/base/assert/is_integerf.h"
 #include "stdlib/constants/float32/nan.h"
+#include "stdlib/constants/float32/pinf.h"
 #include "stdlib/math/base/special/floorf.h"
 #include "stdlib/math/base/special/lnf.h"
-#include <stdint.h>
 
 static const float SQRT5 = 2.23606797749979f;
 static const float LN_PHI = 0.48121182506f;
@@ -32,30 +33,30 @@ static const float LN_PHI = 0.48121182506f;
 * @return     output value
 *
 * @example
-* float y = stdlib_base_nonfibonaccif( 2 );
+* float y = stdlib_base_nonfibonaccif( 2.0f );
 * // returns 6.0f
 *
 * @example
-* float y = stdlib_base_nonfibonaccif( 1 );
+* float y = stdlib_base_nonfibonaccif( 1.0f );
 * // returns 4.0f
 *
 * @example
-* float y = stdlib_base_nonfibonaccif( 3 );
+* float y = stdlib_base_nonfibonaccif( 3.0f );
 * // returns 7.0f
 *
 * @example
-* float y = stdlib_base_nonfibonaccif( -1 );
+* float y = stdlib_base_nonfibonaccif( -1.0f );
 * // returns NaN
 */
-float stdlib_base_nonfibonaccif( const int32_t n ) {
-	int32_t m;
+float stdlib_base_nonfibonaccif( const float n ) {
+	float m;
 	float a;
 	float b;
 
-	if ( n < 1 ) {
+	if ( !stdlib_base_is_integerf( n ) || n == STDLIB_CONSTANT_FLOAT32_PINF || n < 1.0f ) {
 		return STDLIB_CONSTANT_FLOAT32_NAN;
 	}
-	m = n + 1;
+	m = n + 1.0f;
 	a = stdlib_base_lnf( m * SQRT5 ) / LN_PHI;
 	b = stdlib_base_lnf( ( SQRT5 * ( m + a ) ) - 5.0f + ( 3.0f / m ) ) / LN_PHI;
 	return stdlib_base_floorf( m + b - 2.0f );