Skip to content

Commit d9baf7d

Browse files
committed
refactor: use correct property paths
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 5a7d8b8 commit d9baf7d

File tree

7 files changed

+10
-15
lines changed

7 files changed

+10
-15
lines changed

lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/app/app.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -469,6 +469,7 @@
469469
'width': 300
470470
});
471471
editor.title( 'Editor' );
472+
editor.close();
472473

473474
editor.add( editorConfig.meta, 'Toggle Menus' );
474475
addGeneralMenu( editor );

lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/padding/bottom/set.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ function handler( request, response, next ) {
4747

4848
debug( 'New value: %s', body );
4949
try {
50-
// FIXME
51-
// this.plot.padding.bottom = parseInt( body, 10 );
52-
this.plot.paddingBottom = parseInt( body, 10 );
50+
this.plot.padding.bottom = parseInt( body, 10 );
5351
} catch ( err ) {
5452
debug( 'Encountered an error when attempting to assign value. Error: %s', err.message );
5553
return next({

lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/padding/left/set.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ function handler( request, response, next ) {
4747

4848
debug( 'New value: %s', body );
4949
try {
50-
// FIXME
51-
// this.plot.padding.left = parseInt( body, 10 );
52-
this.plot.paddingLeft = parseInt( body, 10 );
50+
this.plot.padding.left = parseInt( body, 10 );
5351
} catch ( err ) {
5452
debug( 'Encountered an error when attempting to assign value. Error: %s', err.message );
5553
return next({

lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/padding/right/set.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ function handler( request, response, next ) {
4747

4848
debug( 'New value: %s', body );
4949
try {
50-
// FIXME
51-
// this.plot.padding.right = parseInt( body, 10 );
52-
this.plot.paddingRight = parseInt( body, 10 );
50+
this.plot.padding.right = parseInt( body, 10 );
5351
} catch ( err ) {
5452
debug( 'Encountered an error when attempting to assign value. Error: %s', err.message );
5553
return next({

lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/padding/top/set.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ function handler( request, response, next ) {
4747

4848
debug( 'New value: %s', body );
4949
try {
50-
// FIXME
51-
// this.plot.padding.top = parseInt( body, 10 );
52-
this.plot.paddingTop = parseInt( body, 10 );
50+
this.plot.padding.top = parseInt( body, 10 );
5351
} catch ( err ) {
5452
debug( 'Encountered an error when attempting to assign value. Error: %s', err.message );
5553
return next({

lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/title/text/set.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,7 @@ function handler( request, response, next ) {
4747

4848
debug( 'New value: %s', body );
4949
try {
50-
// FIXME
51-
// this.plot.title.text = body;
52-
this.plot.title = body;
50+
this.plot.title.text = body;
5351
} catch ( err ) {
5452
debug( 'Encountered an error when attempting to assign value. Error: %s', err.message );
5553
return next({

lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/events/main.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ function handler( request, response ) {
6161
debug( 'Last event id: %s', id );
6262
replay( id );
6363
}
64+
debug( 'Starting connection heartbeat...' );
6465
timer = setInterval( keepAlive, KEEP_ALIVE_INTERVAL );
66+
6567
request.on( 'close', closeConnection );
6668

6769
// Begin listening for plot "change" events:
@@ -90,6 +92,8 @@ function handler( request, response ) {
9092
'type': 'patch',
9193
'data': data
9294
});
95+
96+
debug( 'Sending a patch to the client...' );
9397
response.write( 'event: patch\n' );
9498
response.write( format( 'id: %d\n', counter ) );
9599
response.write( format( 'data: %s\n\n', data ) );

0 commit comments

Comments
 (0)