feat(negative-binomial-variance): changing r to be double instead of int64

Author: Aadish Jain

lib/node_modules/@stdlib/math/base/napi/binary/include/stdlib/math/base/napi/binary.h

@@ -616,48 +616,6 @@
 	};                                                                         \
 	NAPI_MODULE( NODE_GYP_MODULE_NAME, stdlib_math_base_napi_ll_d_init )
 
-/**
-* Macro for registering a Node-API module exporting an interface invoking a binary function accepting signed 64-bit integers and a double-precision floating-point and returning a double-precision floating-point number.
-*
-* @param fcn   binary function
-*
-* @example
-* #include <stdint.h>
-*
-* static double fcn( const int_64 x, const double y ) {
-*     // ...
-* }
-*
-* // ...
-*
-* // Register a Node-API module:
-* STDLIB_MATH_BASE_NAPI_MODULE_LD_D( fcn );
-*/
-#define STDLIB_MATH_BASE_NAPI_MODULE_LD_D( fcn )                               \
-	static napi_value stdlib_math_base_napi_ld_d_wrapper(                      \
-		napi_env env,                                                          \
-		napi_callback_info info                                                \
-	) {                                                                        \
-		return stdlib_math_base_napi_ld_d( env, info, fcn );                   \
-	};                                                                         \
-	static napi_value stdlib_math_base_napi_ld_d_init(                         \
-		napi_env env,                                                          \
-		napi_value exports                                                     \
-	) {                                                                        \
-		napi_value fcn;                                                        \
-		napi_status status = napi_create_function(                             \
-			env,                                                               \
-			"exports",                                                         \
-			NAPI_AUTO_LENGTH,                                                  \
-			stdlib_math_base_napi_ld_d_wrapper,                                \
-			NULL,                                                              \
-			&fcn                                                               \
-		);                                                                     \
-		assert( status == napi_ok );                                           \
-		return fcn;                                                            \
-	};                                                                         \
-	NAPI_MODULE( NODE_GYP_MODULE_NAME, stdlib_math_base_napi_ld_d_init )
-
 /**
 * Macro for registering a Node-API module exporting an interface invoking a binary function accepting signed 32-bit integers and returning a single-precision floating-point number.
 *
@@ -772,11 +730,6 @@ napi_value stdlib_math_base_napi_cf_c( napi_env env, napi_callback_info info, st
 */
 napi_value stdlib_math_base_napi_ll_d( napi_env env, napi_callback_info info, double (*fcn)( int64_t, int64_t ) );
 
-/**
-* Invokes a binary function accepting a signed 64-bit integer and a double-precision floating-point number and returning a double-precision floating-point number.
-*/
-napi_value stdlib_math_base_napi_ld_d( napi_env env, napi_callback_info info, double (*fcn)( int64_t, double ) );
-
 /**
 * Invokes a binary function accepting signed 32-bit integers and returning a single-precision floating-point number.
 */

lib/node_modules/@stdlib/math/base/napi/binary/src/main.c

@@ -87,67 +87,6 @@ napi_value stdlib_math_base_napi_dd_d( napi_env env, napi_callback_info info, do
 
 	return v;
 }
-/**
-* Invokes a binary function accepting a signed 64-bit integer and a double-precision floating-point number and returning double-precision floating-point numbers.
-*
-* ## Notes
-*
-* -   This function expects that the callback `info` argument provides access to the following JavaScript arguments:
-*
-*     -   `x`: input value.
-*     -   `y`: input value.
-*
-* @param env    environment under which the function is invoked
-* @param info   callback data
-* @param fcn    binary function
-* @return       function return value as a Node-API double-precision floating-point number
-*/
-napi_value stdlib_math_base_napi_ld_d( napi_env env, napi_callback_info info, double (*fcn)( int64_t, double ) ) {
-	napi_status status;
-
-	size_t argc = 2;
-	napi_value argv[ 2 ];
-	status = napi_get_cb_info( env, info, &argc, argv, NULL, NULL );
-	assert( status == napi_ok );
-
-	if ( argc < 2 ) {
-		status = napi_throw_error( env, NULL, "invalid invocation. Must provide two numbers." );
-		assert( status == napi_ok );
-		return NULL;
-	}
-
-	napi_valuetype vtype0;
-	status = napi_typeof( env, argv[ 0 ], &vtype0 );
-	assert( status == napi_ok );
-	if ( vtype0 != napi_number ) {
-		status = napi_throw_type_error( env, NULL, "invalid argument. First argument must be a number." );
-		assert( status == napi_ok );
-		return NULL;
-	}
-
-	napi_valuetype vtype1;
-	status = napi_typeof( env, argv[ 1 ], &vtype1 );
-	assert( status == napi_ok );
-	if ( vtype1 != napi_number ) {
-		status = napi_throw_type_error( env, NULL, "invalid argument. Second argument must be a number." );
-		assert( status == napi_ok );
-		return NULL;
-	}
-
-	int64_t x;
-	status = napi_get_value_int64( env, argv[ 0 ], &x );
-	assert( status == napi_ok );
-
-	double y;
-	status = napi_get_value_double( env, argv[ 1 ], &y );
-	assert( status == napi_ok );
-
-	napi_value v;
-	status = napi_create_double( env, fcn( x, y ), &v );
-	assert( status == napi_ok );
-
-	return v;
-}
 
 /**
 * Invokes a binary function accepting and returning single-precision floating-point numbers.

lib/node_modules/@stdlib/stats/base/dists/negative-binomial/variance/README.md

@@ -174,11 +174,11 @@ double v = stdlib_base_dists_negative_binomial_variance( 100, 0.2 );
 
 The function accepts the following arguments:
 
--   **r**: `[in] int` number of successes until experiment is stopped.
+-   **r**: `[in] double` number of successes until experiment is stopped.
 -   **p**: `[in] double` success probability.
 
 ```c
-double stdlib_base_dists_negative_binomial_variance( const int64_t r, const double p );
+double stdlib_base_dists_negative_binomial_variance( const double r, const double p );
 ```
 
 </section>
@@ -202,7 +202,6 @@ double stdlib_base_dists_negative_binomial_variance( const int64_t r, const doub
 ```c
 #include "stdlib/stats/base/dists/negative-binomial/variance.h"
 #include <stdlib.h>
-#include <stdint.h>
 #include <stdio.h>
 
 static double random_uniform( const double min, const double max ) {
@@ -211,17 +210,17 @@ static double random_uniform( const double min, const double max ) {
 }
 
 int main( void ) {
-    int64_t r;
+    double r;
     double p;
     double v;
     int i;
 
 
     for ( i = 0; i < 10; i++ ) {
-        r = (int64_t)random_uniform( -1.0, 100.0 );
+        r = random_uniform( -1.0, 100.0 );
         p = random_uniform( 0.0, 1.0 );
         v = stdlib_base_dists_negative_binomial_variance( r, p );
-        printf( "r: %ld, p: %lf, Var(X;r,p): %lf\n", r, p, v );
+        printf( "r: %lf, p: %lf, Var(X;r,p): %lf\n", r, p, v );
     }
 }
 ```

lib/node_modules/@stdlib/stats/base/dists/negative-binomial/variance/benchmark/benchmark.js

@@ -24,7 +24,6 @@ var bench = require( '@stdlib/bench' );
 var Float64Array = require( '@stdlib/array/float64' );
 var randu = require( '@stdlib/random/base/randu' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
-var floor = require( '@stdlib/math/base/special/floor' );
 var pkg = require( './../package.json' ).name;
 var variance = require( './../lib' );
 
@@ -42,7 +41,7 @@ bench(pkg, function benchmark(b) {
 	r = new Float64Array(len);
 	p = new Float64Array(len);
 	for (i = 0; i < len; i++) {
-		r[i] = floor((randu() * 10.0) + 1.0); // Treat r as int64_t
+		r[i] = (randu() * 10.0) + 1.0; // Treat r as double
 		p[i] = (randu() * 0.8) + 0.1;
 	}
 
@@ -67,7 +66,7 @@ bench(pkg + ':direct', function benchmark(b) {
 	var y;
 	var i;
 
-	r = 5;
+	r = 5.0; // Treat r as double
 	p = 0.5;
 
 	b.tic();

lib/node_modules/@stdlib/stats/base/dists/negative-binomial/variance/benchmark/benchmark.native.js

@@ -26,7 +26,6 @@ var Float64Array = require( '@stdlib/array/float64' );
 var randu = require( '@stdlib/random/base/randu' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var tryRequire = require( '@stdlib/utils/try-require' );
-var floor = require( '@stdlib/math/base/special/floor' );
 var pkg = require( './../package.json' ).name;
 
 
@@ -51,7 +50,7 @@ bench(pkg + '::native', opts, function benchmark(b) {
 	r = new Float64Array(len);
 	p = new Float64Array(len);
 	for (i = 0; i < len; i++) {
-		r[i] = floor((randu() * 10.0) + 1.0);
+		r[i] = (randu() * 10.0) + 1.0; // Treat r as double
 		p[i] = (randu() * 0.8) + 0.1;
 	}
 

lib/node_modules/@stdlib/stats/base/dists/negative-binomial/variance/benchmark/c/benchmark.c

@@ -19,7 +19,6 @@
 #include <sys/time.h>
 #include "stdlib/stats/base/dists/negative-binomial/variance.h"
 #include <math.h>
-#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <time.h>
@@ -94,14 +93,14 @@ static double random_uniform( const double min, const double max ) {
 */
 static double benchmark( void ) {
 	double elapsed;
-	int64_t r[ 100 ];
+	double r[ 100 ];
 	double p[ 100 ];
 	double v;
 	double t;
 	int i;
 
 	for ( i = 0; i < 100; i++ ) {
-		r[ i ] = (int64_t)random_uniform( 1.0, 10.0 );
+		r[ i ] = random_uniform( 1.0, 10.0 );
 		p[ i ] = random_uniform( 0.1, 0.9 );
 	}
 

lib/node_modules/@stdlib/stats/base/dists/negative-binomial/variance/examples/c/example.c

@@ -17,7 +17,6 @@
 */
 
 #include "stdlib/stats/base/dists/negative-binomial/variance.h"
-#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 
@@ -27,15 +26,15 @@ static double random_uniform( const double min, const double max ) {
 }
 
 int main( void ) {
-	int64_t r;
+	double r;
 	double p;
 	double v;
 	int i;
 
 	for ( i = 0; i < 25; i++ ) {
-		r = (int64_t)random_uniform( 1.0, 10.0 );
+		r = random_uniform( 1.0, 10.0 );
 		p = random_uniform( 0.1, 0.9 );
 		v = stdlib_base_dists_negative_binomial_variance( r, p );
-		printf( "r: %ld, p: %lf, Var(r,p): %lf\n", r, p, v );
+		printf( "r: %lf, p: %lf, Var(r,p): %lf\n", r, p, v );
 	}
 }

lib/node_modules/@stdlib/stats/base/dists/negative-binomial/variance/examples/index.js

@@ -30,5 +30,5 @@ for ( i = 0; i < 10; i++ ) {
 	r = randu() * 100;
 	p = randu();
 	v = variance( r, p );
-	console.log( 'r: %d, p: %d, Var(X;r,p): %d', r, p.toFixed( 4 ), v.toFixed( 4 ) );
+	console.log( 'r: %lf, p: %lf, Var(X;r,p): %lf', r, p.toFixed( 4 ), v.toFixed( 4 ) );
 }

lib/node_modules/@stdlib/stats/base/dists/negative-binomial/variance/include/stdlib/stats/base/dists/negative-binomial/variance.h

@@ -31,7 +31,7 @@ extern "C" {
 /**
 * Computes the variance for a negative binomial distribution with number of successes `r` and success probability `p`.
 */
-double stdlib_base_dists_negative_binomial_variance( const int64_t r, const double p );
+double stdlib_base_dists_negative_binomial_variance( const double r, const double p );
 
 #ifdef __cplusplus
 }

lib/node_modules/@stdlib/stats/base/dists/negative-binomial/variance/lib/native.js

@@ -34,27 +34,27 @@ var addon = require( './../src/addon.node' );
 * @returns {number} evaluated variance
 *
 * @example
-* var v = variance( 10, 0.5 );
+* var v = variance( 10.0, 0.5 );
 * // returns 20.0
 *
 * @example
-* var v = variance( 5, 0.2 );
+* var v = variance( 5.0, 0.2 );
 * // returns 100.0
 *
 * @example
 * var v = variance( NaN, 0.5 );
 * // returns NaN
 *
 * @example
-* var v = variance( 10, NaN );
+* var v = variance( 10.0, NaN );
 * // returns NaN
 *
 * @example
-* var v = variance( -1, 0.5 );
+* var v = variance( -1.0, 0.5 );
 * // returns NaN
 *
 * @example
-* var v = variance( 10, 1.5 );
+* var v = variance( 10.0, 1.5 );
 * // returns NaN
 */
 function variance(r, p) {