Skip to content

Commit da87aba

Browse files
hrshyahrshya
authored
bench: update random value generation
PR-URL: #6690 Reviewed-by: Philipp Burckhardt <[email protected]>
1 parent 65f0948 commit da87aba

File tree

16 files changed

+110
-70
lines changed

16 files changed

+110
-70
lines changed

‎lib/node_modules/@stdlib/math/base/assert/is-positive-finite/benchmark/benchmark.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isBoolean = require( '@stdlib/assert/is-boolean' ).isPrimitive;
2626
var pkg = require( './../package.json' ).name;
2727
var isPositiveFinite = require( './../lib' );
@@ -30,14 +30,19 @@ var isPositiveFinite = require( './../lib' );
3030
// MAIN //
3131

3232
bench( pkg, function benchmark( b ) {
33+
var opts;
3334
var x;
3435
var y;
3536
var i;
3637

38+
opts = {
39+
'dtype': 'float64'
40+
};
41+
x = uniform( 100, -100.0, 100.0, opts );
42+
3743
b.tic();
3844
for ( i = 0; i < b.iterations; i++ ) {
39-
x = (randu()*200.0) - 100.0;
40-
y = isPositiveFinite( x );
45+
y = isPositiveFinite( x[ i%x.length ] );
4146
if ( typeof y !== 'boolean' ) {
4247
b.fail( 'should return a boolean' );
4348
}

‎lib/node_modules/@stdlib/math/base/assert/is-positive-finite/benchmark/benchmark.native.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2626
var isBoolean = require( '@stdlib/assert/is-boolean' ).isPrimitive;
2727
var tryRequire = require( '@stdlib/utils/try-require' );
2828
var pkg = require( './../package.json' ).name;
@@ -39,14 +39,19 @@ var opts = {
3939
// MAIN //
4040

4141
bench( pkg+'::native', opts, function benchmark( b ) {
42+
var opts;
4243
var x;
4344
var y;
4445
var i;
4546

47+
opts = {
48+
'dtype': 'float64'
49+
};
50+
x = uniform( 100, -100.0, 100.0, opts );
51+
4652
b.tic();
4753
for ( i = 0; i < b.iterations; i++ ) {
48-
x = ( randu()*200.0 ) - 100.0;
49-
y = isPositiveFinite( x );
54+
y = isPositiveFinite( x[ i%x.length ] );
5055
if ( typeof y !== 'boolean' ) {
5156
b.fail( 'should return a boolean' );
5257
}

‎lib/node_modules/@stdlib/math/base/assert/is-positive-finite/benchmark/c/native/benchmark.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,15 +92,18 @@ static double rand_double( void ) {
9292
*/
9393
static double benchmark( void ) {
9494
double elapsed;
95-
double x;
95+
double x[ 100 ];
9696
double t;
9797
bool b;
9898
int i;
9999

100+
for ( i = 0; i < 100; i++ ) {
101+
x[ i ] = ( rand_double() * 200.0 ) - 100.0;
102+
}
103+
100104
t = tic();
101105
for ( i = 0; i < ITERATIONS; i++ ) {
102-
x = ( rand_double() * 200.0 ) - 100.0;
103-
b = stdlib_base_is_positive_finite( x );
106+
b = stdlib_base_is_positive_finite( x[ i%100 ] );
104107
if ( b != true && b != false ) {
105108
printf( "should return either true or false\n" );
106109
break;

‎lib/node_modules/@stdlib/math/base/assert/is-positive-finite/test/test.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,26 +35,26 @@ tape( 'main export is a function', function test( t ) {
3535
});
3636

3737
tape( 'the function returns `true` if provided a positive finite number', function test( t ) {
38-
t.equal( isPositiveFinite( 1.0 ), true, 'returns true' );
39-
t.equal( isPositiveFinite( 3.14 ), true, 'returns true' );
40-
t.equal( isPositiveFinite( 1.0e308 ), true, 'returns true' );
38+
t.equal( isPositiveFinite( 1.0 ), true, 'returns expected value' );
39+
t.equal( isPositiveFinite( 3.14 ), true, 'returns expected value' );
40+
t.equal( isPositiveFinite( 1.0e308 ), true, 'returns expected value' );
4141
t.end();
4242
});
4343

4444
tape( 'the function returns `false` if provided a negative number', function test( t ) {
45-
t.equal( isPositiveFinite( -1.0 ), false, 'returns false' );
46-
t.equal( isPositiveFinite( -3.14 ), false, 'returns false' );
47-
t.equal( isPositiveFinite( -1.0e308 ), false, 'returns false' );
45+
t.equal( isPositiveFinite( -1.0 ), false, 'returns expected value' );
46+
t.equal( isPositiveFinite( -3.14 ), false, 'returns expected value' );
47+
t.equal( isPositiveFinite( -1.0e308 ), false, 'returns expected value' );
4848
t.end();
4949
});
5050

5151
tape( 'the function returns `false` if provided +infinity or -infinity', function test( t ) {
52-
t.equal( isPositiveFinite( PINF ), false, 'returns false' );
53-
t.equal( isPositiveFinite( NINF ), false, 'returns false' );
52+
t.equal( isPositiveFinite( PINF ), false, 'returns expected value' );
53+
t.equal( isPositiveFinite( NINF ), false, 'returns expected value' );
5454
t.end();
5555
});
5656

5757
tape( 'the function returns `false` if provided `NaN`', function test( t ) {
58-
t.equal( isPositiveFinite( NaN ), false, 'returns false' );
58+
t.equal( isPositiveFinite( NaN ), false, 'returns expected value' );
5959
t.end();
6060
});

‎lib/node_modules/@stdlib/math/base/assert/is-positive-finite/test/test.native.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,26 +44,26 @@ tape( 'main export is a function', opts, function test( t ) {
4444
});
4545

4646
tape( 'the function returns `true` if provided a positive finite number', opts, function test( t ) {
47-
t.equal( isPositiveFinite( 1.0 ), true, 'returns true' );
48-
t.equal( isPositiveFinite( 3.14 ), true, 'returns true' );
49-
t.equal( isPositiveFinite( 1.0e308 ), true, 'returns true' );
47+
t.equal( isPositiveFinite( 1.0 ), true, 'returns expected value' );
48+
t.equal( isPositiveFinite( 3.14 ), true, 'returns expected value' );
49+
t.equal( isPositiveFinite( 1.0e308 ), true, 'returns expected value' );
5050
t.end();
5151
});
5252

5353
tape( 'the function returns `false` if provided a negative number', opts, function test( t ) {
54-
t.equal( isPositiveFinite( -1.0 ), false, 'returns false' );
55-
t.equal( isPositiveFinite( -3.14 ), false, 'returns false' );
56-
t.equal( isPositiveFinite( -1.0e308 ), false, 'returns false' );
54+
t.equal( isPositiveFinite( -1.0 ), false, 'returns expected value' );
55+
t.equal( isPositiveFinite( -3.14 ), false, 'returns expected value' );
56+
t.equal( isPositiveFinite( -1.0e308 ), false, 'returns expected value' );
5757
t.end();
5858
});
5959

6060
tape( 'the function returns `false` if provided +infinity or -infinity', opts, function test( t ) {
61-
t.equal( isPositiveFinite( PINF ), false, 'returns false' );
62-
t.equal( isPositiveFinite( NINF ), false, 'returns false' );
61+
t.equal( isPositiveFinite( PINF ), false, 'returns expected value' );
62+
t.equal( isPositiveFinite( NINF ), false, 'returns expected value' );
6363
t.end();
6464
});
6565

6666
tape( 'the function returns `false` if provided `NaN`', opts, function test( t ) {
67-
t.equal( isPositiveFinite( NaN ), false, 'returns false' );
67+
t.equal( isPositiveFinite( NaN ), false, 'returns expected value' );
6868
t.end();
6969
});

‎lib/node_modules/@stdlib/math/base/assert/is-positive-integer/benchmark/benchmark.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
25-
var round = require( '@stdlib/math/base/special/round' );
24+
var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
2625
var isBoolean = require( '@stdlib/assert/is-boolean' ).isPrimitive;
2726
var pkg = require( './../package.json' ).name;
2827
var isPositiveInteger = require( './../lib' );
@@ -31,14 +30,19 @@ var isPositiveInteger = require( './../lib' );
3130
// MAIN //
3231

3332
bench( pkg, function benchmark( b ) {
33+
var opts;
3434
var x;
3535
var y;
3636
var i;
3737

38+
opts = {
39+
'dtype': 'float64'
40+
};
41+
x = discreteUniform( 100, -5.0e6, 5.0e6, opts );
42+
3843
b.tic();
3944
for ( i = 0; i < b.iterations; i++ ) {
40-
x = round( (randu()*1.0e7) - 5.0e6 );
41-
y = isPositiveInteger( x );
45+
y = isPositiveInteger( x[ i%x.length ] );
4246
if ( typeof y !== 'boolean' ) {
4347
b.fail( 'should return a boolean' );
4448
}

‎lib/node_modules/@stdlib/math/base/assert/is-positive-integer/benchmark/benchmark.native.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
26-
var round = require( '@stdlib/math/base/special/round' );
25+
var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
2726
var isBoolean = require( '@stdlib/assert/is-boolean' ).isPrimitive;
2827
var tryRequire = require( '@stdlib/utils/try-require' );
2928
var pkg = require( './../package.json' ).name;
@@ -40,14 +39,19 @@ var opts = {
4039
// MAIN //
4140

4241
bench( pkg+'::native', opts, function benchmark( b ) {
42+
var opts;
4343
var x;
4444
var y;
4545
var i;
4646

47+
opts = {
48+
'dtype': 'float64'
49+
};
50+
x = discreteUniform( 100, -5.0e6, 5.0e6, opts );
51+
4752
b.tic();
4853
for ( i = 0; i < b.iterations; i++ ) {
49-
x = round( (randu()*1.0e7 ) - 5.0e6 );
50-
y = isPositiveInteger( x );
54+
y = isPositiveInteger( x[ i%x.length ] );
5155
if ( typeof y !== 'boolean' ) {
5256
b.fail( 'should return a boolean' );
5357
}

‎lib/node_modules/@stdlib/math/base/assert/is-positive-integer/benchmark/c/native/benchmark.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,15 +92,18 @@ static double rand_double( void ) {
9292
*/
9393
static double benchmark( void ) {
9494
double elapsed;
95-
double x;
95+
double x[ 100 ];
9696
double t;
9797
bool b;
9898
int i;
9999

100+
for ( i = 0; i < 100; i++ ) {
101+
x[ i ] = ( rand_double() * 200.0 ) - 100.0;
102+
}
103+
100104
t = tic();
101105
for ( i = 0; i < ITERATIONS; i++ ) {
102-
x = ( rand_double() * 200.0 ) - 100.0;
103-
b = stdlib_base_is_positive_integer( x );
106+
b = stdlib_base_is_positive_integer( x[ i%100 ] );
104107
if ( b != true && b != false ) {
105108
printf( "should return either true or false\n" );
106109
break;

‎lib/node_modules/@stdlib/math/base/assert/is-positive-integer/test/test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ tape( 'main export is a function', function test( t ) {
3939
tape( 'the function returns `true` if provided a positive integer', function test( t ) {
4040
var i;
4141
for ( i = 1; i < 101; i++ ) {
42-
t.equal( isPositiveInteger( i ), true, 'returns true when provided '+i );
42+
t.equal( isPositiveInteger( i ), true, 'returns expected value when provided '+i );
4343
}
4444
t.end();
4545
});
4646

4747
tape( 'the function returns `false` if not provided a positive integer', function test( t ) {
4848
var i;
4949
for ( i = 0; i > -101; i-- ) {
50-
t.equal( isPositiveInteger( i ), false, 'returns false when provided '+i );
50+
t.equal( isPositiveInteger( i ), false, 'returns expected value when provided '+i );
5151
}
5252
t.end();
5353
});
@@ -58,23 +58,23 @@ tape( 'the function returns `false` if not provided an integer', function test(
5858
for ( i = 0; i < 100; i++ ) {
5959
v = ( randu()*100.0 ) - 50.0;
6060
if ( trunc(v) !== v ) {
61-
t.equal( isPositiveInteger( v ), false, 'returns false when provided '+v );
61+
t.equal( isPositiveInteger( v ), false, 'returns expected value when provided '+v );
6262
}
6363
}
6464
t.end();
6565
});
6666

6767
tape( 'the function returns `false` if provided `NaN`', function test( t ) {
68-
t.equal( isPositiveInteger( NaN ), false, 'returns false' );
68+
t.equal( isPositiveInteger( NaN ), false, 'returns expected value' );
6969
t.end();
7070
});
7171

7272
tape( 'WARNING: the function returns `true` if provided `+infinity`', function test( t ) {
73-
t.equal( isPositiveInteger( PINF ), true, 'returns true' );
73+
t.equal( isPositiveInteger( PINF ), true, 'returns expected value' );
7474
t.end();
7575
});
7676

7777
tape( 'the function returns `false` if provided `-infinity`', function test( t ) {
78-
t.equal( isPositiveInteger( NINF ), false, 'returns false' );
78+
t.equal( isPositiveInteger( NINF ), false, 'returns expected value' );
7979
t.end();
8080
});

‎lib/node_modules/@stdlib/math/base/assert/is-positive-integer/test/test.native.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ tape( 'main export is a function', opts, function test( t ) {
4848
tape( 'the function returns `true` if provided a positive integer', opts, function test( t ) {
4949
var i;
5050
for ( i = 1; i < 101; i++ ) {
51-
t.equal( isPositiveInteger( i ), true, 'returns true when provided '+i );
51+
t.equal( isPositiveInteger( i ), true, 'returns expected value when provided '+i );
5252
}
5353
t.end();
5454
});
5555

5656
tape( 'the function returns `false` if not provided a positive integer', opts, function test( t ) {
5757
var i;
5858
for ( i = 0; i > -101; i-- ) {
59-
t.equal( isPositiveInteger( i ), false, 'returns false when provided '+i );
59+
t.equal( isPositiveInteger( i ), false, 'returns expected value when provided '+i );
6060
}
6161
t.end();
6262
});
@@ -67,23 +67,23 @@ tape( 'the function returns `false` if not provided an integer', opts, function
6767
for ( i = 0; i < 100; i++ ) {
6868
v = ( randu() * 100.0 ) - 50.0;
6969
if ( trunc(v) !== v ) {
70-
t.equal( isPositiveInteger( v ), false, 'returns false when provided '+v );
70+
t.equal( isPositiveInteger( v ), false, 'returns expected value when provided '+v );
7171
}
7272
}
7373
t.end();
7474
});
7575

7676
tape( 'the function returns `false` if provided `NaN`', opts, function test( t ) {
77-
t.equal( isPositiveInteger( NaN ), false, 'returns false' );
77+
t.equal( isPositiveInteger( NaN ), false, 'returns expected value' );
7878
t.end();
7979
});
8080

8181
tape( 'WARNING: the function returns `true` if provided `+infinity`', opts, function test( t ) {
82-
t.equal( isPositiveInteger( PINF ), true, 'returns true' );
82+
t.equal( isPositiveInteger( PINF ), true, 'returns expected value' );
8383
t.end();
8484
});
8585

8686
tape( 'the function returns `false` if provided `-infinity`', opts, function test( t ) {
87-
t.equal( isPositiveInteger( NINF ), false, 'returns false' );
87+
t.equal( isPositiveInteger( NINF ), false, 'returns expected value' );
8888
t.end();
8989
});

0 commit comments

Comments
 (0)