Merge branch 'Add-C-implementations-to-base-special-math-functions' of https://github.com/vivekmaurya001/stdlib into Add-C-implementations-to-base-special-math-functions

Author: vivekmaurya001

.editorconfig

@@ -121,7 +121,7 @@ indent_style = tab
 [*.{md,md.txt}]
 indent_style = space
 indent_size = 4
-trim_trailing_whitespace = false
+trim_trailing_whitespace = true # Note: this disables using two spaces to force a hard line break, which is permitted in Markdown. As we don't typically follow that practice (TMK), we should be safe to automatically trim.
 
 # Set properties for `usage.txt` files:
 [usage.txt]

.github/labeler.yml

@@ -27,3 +27,11 @@ LAPACK:
 Math:
 - changed-files:
   - any-glob-to-all-files: '**/math/**/*'
+
+REPL:
+- changed-files:
+  - any-glob-to-all-files: '**/repl/**/*'
+
+Statistics:
+- changed-files:
+  - any-glob-to-all-files: '**/stats/**/*'

.github/workflows/cleanup_coverage.yml

@@ -59,19 +59,19 @@ jobs:
           script: |
             const prNumber = context.payload.pull_request.number;
             const { data: comments } = await github.rest.issues.listComments({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: prNumber,
+              'owner': context.repo.owner,
+              'repo': context.repo.repo,
+              'issue_number': prNumber
             });
             const coverageComment = comments.find( comment => comment.body && comment.body.includes( '## Coverage Report' ) );
             if ( coverageComment ) {
               // Replace URLs with plain text in the coverage report comment body:
               const updatedBody = coverageComment.body.replace( /<a href="[^"]+">([^<]+)<\/a>/g, '$1' );
               await github.rest.issues.updateComment({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                comment_id: coverageComment.id,
-                body: updatedBody,
+                'owner': context.repo.owner,
+                'repo': context.repo.repo,
+                'comment_id': coverageComment.id,
+                'body': updatedBody
               });
             } else {
               console.log( 'No Coverage Report comment found.' );

.github/workflows/labeler.yml

@@ -31,6 +31,7 @@ on:
       - review_request_removed
       - ready_for_review
       - converted_to_draft
+      - labeled
 
 # Workflow jobs:
 jobs:
@@ -75,12 +76,12 @@ jobs:
               'owner': context.repo.owner,
               'repo': context.repo.repo,
               'issue_number': context.payload.pull_request.number,
-              'labels': ['Needs Review'],
+              'labels': [ 'Needs Review' ]
             })
 
-      # Add "Needs Review" label when PR is marked ready for review:
-      - name: 'Add "Needs Review" label if PR is ready for review'
-        if: ${{ github.event.action == 'ready_for_review' }}
+      # Add "Needs Review" label when PR is marked ready for review or review is requested:
+      - name: 'Add "Needs Review" label if PR is ready for review or review is requested'
+        if: ${{ github.event.action == 'ready_for_review' || github.event.action == 'review_requested' }}
         # Pin action to full length commit SHA
         uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
         with:
@@ -90,7 +91,7 @@ jobs:
               'owner': context.repo.owner,
               'repo': context.repo.repo,
               'issue_number': context.payload.pull_request.number,
-              'labels': ['Needs Review'],
+              'labels': [ 'Needs Review' ]
             })
 
       # Remove "Needs Review" label when PR is converted to draft or closed:
@@ -106,8 +107,29 @@ jobs:
                 'owner': context.repo.owner,
                 'repo': context.repo.repo,
                 'issue_number': context.payload.pull_request.number,
-                'name': 'Needs Review',
+                'name': 'Needs Review'
               })
             } catch ( error ) {
               console.log( 'Error removing label: %s', error.message );
             }
+
+      # Remove "Needs Review" and "Needs Changes" labels when "Ready To Merge" is assigned:
+      - name: 'Remove "Needs Review" and "Needs Changes" labels when "Ready To Merge" is assigned'
+        if: ${{ github.event.action == 'labeled' && github.event.label.name == 'Ready To Merge' }}
+        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
+        with:
+          github-token: ${{ secrets.CHATBOT_GITHUB_TOKEN }}
+          script: |
+            const labelsToRemove = [ 'Needs Review', 'Needs Changes' ];
+            for ( const label of labelsToRemove ) {
+              try {
+                await github.rest.issues.removeLabel({
+                  'owner': context.repo.owner,
+                  'repo': context.repo.repo,
+                  'issue_number': context.payload.pull_request.number,
+                  'name': label
+                })
+              } catch ( error ) {
+                console.log( 'Error removing label %s: %s', label, error.message );
+              }
+            }

.github/workflows/lint_changed_files.yml

@@ -39,7 +39,7 @@ permissions:
 jobs:
 
   # Define a job for linting committed code...
-  process:
+  lint:
 
     # Define a display name:
     name: 'Lint Changed Files'
@@ -104,7 +104,7 @@ jobs:
           files=$(echo "$files" | tr '\n' ' ' | sed 's/ $//')
           echo "files=${files}" >> $GITHUB_OUTPUT
 
-      # Lint file names
+      # Lint file names:
       - name: 'Lint file names'
         run: |
           # Determine root directory:
@@ -116,6 +116,12 @@ jobs:
           # Lint filenames:
           echo "${{ steps.changed-files.outputs.files }}" || "${lint_filenames}"
 
+      # Lint files against EditorConfig:
+      - name: 'Lint against EditorConfig'
+        if: success() || failure()
+        run: |
+          make lint-editorconfig-files FILES="${{ steps.changed-files.outputs.files }}"
+
       # Lint Markdown files:
       - name: 'Lint Markdown files'
         if: success() || failure()
@@ -142,19 +148,7 @@ jobs:
       - name: 'Lint package.json files'
         if: success() || failure()
         run: |
-          # Determine root directory:
-          root=$(git rev-parse --show-toplevel)
-
-          # Define the path to a utility for linting package.json files:
-          lint_package_json="${root}/lib/node_modules/@stdlib/_tools/lint/pkg-json/bin/cli"
-
-          files=$(echo "${{ steps.changed-files.outputs.files }}" | tr ' ' '\n' | grep 'package\.json$' | grep -v 'datapackage\.json$' | tr '\n' ' ' | sed 's/ $//')
-          if [ -n "${files}" ]; then
-            echo "Linting package.json files that have changed..."
-            printf "${files}" | "${lint_package_json}" --split=" "
-          else
-            echo "No package.json files to lint."
-          fi
+          . "$GITHUB_WORKSPACE/.github/workflows/scripts/lint_package_json_files" "${{ steps.changed-files.outputs.files }}"
 
       # Lint REPL help files...
       - name: 'Lint REPL help files'

.github/workflows/lint_random_files.yml

@@ -183,7 +183,7 @@ jobs:
 
           echo "files=$files" >> $GITHUB_OUTPUT
 
-      # Lint file names
+      # Lint file names:
       - name: 'Lint file names'
         run: |
           # Determine root directory:
@@ -195,6 +195,12 @@ jobs:
           # Lint filenames:
           echo "${{ steps.random-files.outputs.files }}" | tr ',' '\n' | "${lint_filenames}"
 
+      # Lint files against EditorConfig:
+      - name: 'Lint against EditorConfig'
+        run: |
+          files=$(echo "${{ steps.random-files.outputs.files }}" | tr ',' ' ')
+          make lint-editorconfig-files FILES="${files}"
+
       # Lint Markdown files:
       - name: 'Lint Markdown files'
         if: ( github.event.inputs.markdown != 'false' ) && ( success() || failure() )
@@ -393,15 +399,30 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.STDLIB_BOT_GITHUB_TOKEN }}
         run: |
-          # Create a temporary file for storing lint error messages:
-          ERROR_LOG=$(mktemp)
-          grep -B 1 -A 2 "style:\|warning:\|error:" <<< "${{ steps.lint-c.outputs.stderr }}" > $ERROR_LOG
-
-          . "$GITHUB_WORKSPACE/.github/workflows/scripts/create_lint_sub_issue" \
-            "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" \
-            "C" \
-            "3235" \ # Number of C lint error tracking issue
-            "$ERROR_LOG"
+          BODY_FILE="$GITHUB_WORKSPACE/lint_issue_body.md"
+
+          cat << EOF > "$BODY_FILE"
+            ## C Linting Failures
+
+            Linting failures were detected in the automated lint workflow run.
+
+            ### Workflow Details
+            -   Run: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+            -   Type: C Linting
+            -   Date: $(date -u +"%Y-%m-%d %H:%M:%S UTC")
+
+            ### Error Details
+            \`\`\`
+            $(grep -B 1 -A 2 "style:\|warning:\|error:" <<< "${{ steps.lint-c.outputs.stderr }}")
+            \`\`\`
+            EOF
+
+          . "$GITHUB_WORKSPACE/.github/workflows/scripts/create_sub_issue" \
+            'Fix C lint errors' \
+            "$BODY_FILE" \
+            "3235"  # Number of C lint error tracking issue
+
+          rm "$BODY_FILE"
 
       # Lint TypeScript declarations files:
       - name: 'Lint TypeScript declarations files'

.github/workflows/run_tests_coverage.yml

@@ -226,25 +226,25 @@ jobs:
           github-token: ${{ secrets.CHATBOT_GITHUB_TOKEN }}
           script: |
             const { data: comments } = await github.rest.issues.listComments({
-              issue_number: context.issue.number,
-              owner: context.repo.owner,
-              repo: context.repo.repo,
+              'issue_number': context.issue.number,
+              'owner': context.repo.owner,
+              'repo': context.repo.repo,
             });
 
             const botComment = comments.find( comment => comment.user.login === 'stdlib-bot' && comment.body.includes( '## Coverage Report' ) );
             if ( botComment ) {
               await github.rest.issues.updateComment({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                comment_id: botComment.id,
-                body: `${{ steps.create-report.outputs.report }}`,
+                'owner': context.repo.owner,
+                'repo': context.repo.repo,
+                'comment_id': botComment.id,
+                'body': `${{ steps.create-report.outputs.report }}`
               });
             } else {
               await github.rest.issues.createComment({
-                issue_number: context.issue.number,
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                body: `${{ steps.create-report.outputs.report }}`,
+                'issue_number': context.issue.number,
+                'owner': context.repo.owner,
+                'repo': context.repo.repo,
+                'body': `${{ steps.create-report.outputs.report }}`
               });
             }
 
@@ -257,10 +257,10 @@ jobs:
           github-token: ${{ secrets.CHATBOT_GITHUB_TOKEN }}
           script: |
             github.rest.repos.createCommitComment({
-              commit_sha: context.sha,
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              body: '${{ steps.create-report.outputs.report }}'
+              'commit_sha': context.sha,
+              'owner': context.repo.owner,
+              'repo': context.repo.repo,
+              'body': '${{ steps.create-report.outputs.report }}'
             })
 
       # Checkout coverage repository: