Skip to content

Commit dddc029

Browse files
committed
chore: apply review changes
1 parent 89b1e9c commit dddc029

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

lib/node_modules/@stdlib/blas/base/idamax-wasm/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ The function has the following additional parameters:
233233

234234
## Notes
235235

236-
- If `N < 1`, both `main` and `ndarray` methods return `-1.0`.
236+
- If `N < 1`, both `main` and `ndarray` methods return `-1`.
237237
- This package implements routines using WebAssembly. When provided arrays which are not allocated on a `idamax` module memory instance, data must be explicitly copied to module memory prior to computation. Data movement may entail a performance cost, and, thus, if you are using arrays external to module memory, you should prefer using [`@stdlib/blas/base/idamax`][@stdlib/blas/base/idamax]. However, if working with arrays which are allocated and explicitly managed on module memory, you can achieve better performance when compared to the pure JavaScript implementations found in [`@stdlib/blas/base/idamax`][@stdlib/blas/base/idamax]. Beware that such performance gains may come at the cost of additional complexity when having to perform manual memory management. Choosing between implementations depends heavily on the particular needs and constraints of your application, with no one choice universally better than the other.
238238
- `idamax()` corresponds to the [BLAS][blas] level 1 function [`idamax`][idamax].
239239

lib/node_modules/@stdlib/blas/base/idamax-wasm/docs/repl.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22
{{alias}}.main( N, x, strideX )
33
Finds the index of the first element having the maximum absolute value.
44

5-
The `N` and stride parameters determine which elements in the strided arrays
5+
The `N` and stride parameters determine which elements in the strided array
66
are accessed at runtime.
77

88
Indexing is relative to the first index. To introduce an offset, use typed
99
array views.
1010

11-
If `N < 1`, both functions return `-1`.
11+
If `N < 1`, the function returns `-1`.
1212

1313
Parameters
1414
----------

lib/node_modules/@stdlib/blas/base/idamax-wasm/docs/types/index.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ interface ModuleConstructor {
100100
* var xptr = 0;
101101
*
102102
* // Write vector values to module memory:
103-
*mod.write( xptr, oneTo( N, dtype ) );
103+
* mod.write( xptr, oneTo( N, dtype ) );
104104
*
105105
* // Perform computation:
106106
* var idx = mod.main( N, xptr, 1 );
@@ -110,7 +110,7 @@ interface ModuleConstructor {
110110
}
111111

112112
/**
113-
* Interface describing a `idamax` WebAssembly module.
113+
* Interface describing an `idamax` WebAssembly module.
114114
*/
115115
interface Module extends ModuleWrapper {
116116
/**

lib/node_modules/@stdlib/blas/base/idamax-wasm/test/test.main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ tape( 'the `main` method supports a `stride` parameter', function test( t ) {
9090
t.end();
9191
});
9292

93-
tape( 'if provided an `N` parameter less than or equal to `1`, the `main` method returns `-1`', function test( t ) {
93+
tape( 'if provided an `N` parameter less than `1`, the `main` method returns `-1`', function test( t ) {
9494
var idx;
9595
var x;
9696

0 commit comments

Comments
 (0)