Skip to content

Commit e1c0fa1

Browse files
headlessNodeheadlessNode
committed
refactor: apply suggestions from code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 0aa9591 commit e1c0fa1

File tree

22 files changed

+337
-69
lines changed

22 files changed

+337
-69
lines changed

‎lib/node_modules/@stdlib/ndarray/base/nullary-strided1d/lib/0d.js

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
* };
7979
*
8080
* // Define a strategy:
81-
* function strategy( x ) {
81+
* function inputStrategy( x ) {
8282
* return {
8383
* 'dtype': x.dtype,
8484
* 'data': x.data,
@@ -89,15 +89,25 @@
8989
* };
9090
* }
9191
*
92+
* function outputStrategy( x ) {
93+
* return x;
94+
* }
95+
*
96+
* var strategy = {
97+
* 'input': inputStrategy,
98+
* 'output': outputStrategy
99+
* }
100+
*
92101
* // Apply strided function:
93102
* nullary0d( wrapper, [ x, sortOrder ], strategy, {} );
94103
*
95104
* var v = x.data;
96105
* // returns [ 1.0, 2.0, 3.0, 4.0 ]
97106
*/
98107
function nullary0d( fcn, arrays, strategyX, opts ) {
99-
arrays[ 0 ] = strategyX( arrays[ 0 ] );
108+
arrays[ 0 ] = strategyX.input( arrays[ 0 ] );
100109
fcn( arrays, opts );
110+
strategyX.output( arrays[ 0 ] );
101111
}
102112

103113

‎lib/node_modules/@stdlib/ndarray/base/nullary-strided1d/lib/10d.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ var offsets = require( './offsets.js' );
111111
* }
112112
* ];
113113
*
114-
* // Define a strategy:
115-
* function strategy( x ) {
114+
* // Define an input strategy:
115+
* function inputStrategy( x ) {
116116
* return {
117117
* 'dtype': x.dtype,
118118
* 'data': x.data,
@@ -123,6 +123,16 @@ var offsets = require( './offsets.js' );
123123
* };
124124
* }
125125
*
126+
* // Define an output strategy:
127+
* function outputStrategy( x ) {
128+
* return x;
129+
* }
130+
*
131+
* var strategy = {
132+
* 'input': inputStrategy,
133+
* 'output': outputStrategy
134+
* }
135+
*
126136
* // Apply strided function:
127137
* nullary10d( wrapper, [ x, sortOrder ], views, [ 1, 1, 1, 1, 1, 1, 1, 1, 1, 3 ], [ 12, 12, 12, 12, 12, 12, 12, 12, 12, 4 ], true, strategy, {} );
128138
*
@@ -297,8 +307,9 @@ function nullary10d( fcn, arrays, views, shape, stridesX, isRowMajor, strategyX,
297307
for ( i1 = 0; i1 < S1; i1++ ) {
298308
for ( i0 = 0; i0 < S0; i0++ ) {
299309
setViewOffsets( views, iv );
300-
v[ 0 ] = strategyX( views[ 0 ] );
310+
v[ 0 ] = strategyX.input( views[ 0 ] );
301311
fcn( v, opts );
312+
strategyX.output( views[ 0 ] );
302313
incrementOffsets( iv, dv0 );
303314
}
304315
incrementOffsets( iv, dv1 );

‎lib/node_modules/@stdlib/ndarray/base/nullary-strided1d/lib/10d_blocked.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ var offsets = require( './offsets.js' );
114114
* }
115115
* ];
116116
*
117-
* // Define a strategy:
118-
* function strategy( x ) {
117+
* // Define an input strategy:
118+
* function inputStrategy( x ) {
119119
* return {
120120
* 'dtype': x.dtype,
121121
* 'data': x.data,
@@ -126,6 +126,16 @@ var offsets = require( './offsets.js' );
126126
* };
127127
* }
128128
*
129+
* // Define an output strategy:
130+
* function outputStrategy( x ) {
131+
* return x;
132+
* }
133+
*
134+
* var strategy = {
135+
* 'input': inputStrategy,
136+
* 'output': outputStrategy
137+
* }
138+
*
129139
* // Apply strided function:
130140
* blockednullary10d( wrapper, [ x, sortOrder ], views, [ 1, 1, 1, 1, 1, 1, 1, 1, 1, 3 ], [ 12, 12, 12, 12, 12, 12, 12, 12, 12, 4 ], strategy, {} );
131141
*
@@ -373,8 +383,9 @@ function blockednullary10d( fcn, arrays, views, shape, stridesX, strategyX, opts
373383
for ( i1 = 0; i1 < s1; i1++ ) {
374384
for ( i0 = 0; i0 < s0; i0++ ) {
375385
setViewOffsets( views, iv );
376-
v[ 0 ] = strategyX( views[ 0 ] );
386+
v[ 0 ] = strategyX.input( views[ 0 ] );
377387
fcn( v, opts );
388+
strategyX.output( views[ 0 ] );
378389
incrementOffsets( iv, dv0 );
379390
}
380391
incrementOffsets( iv, dv1 );

‎lib/node_modules/@stdlib/ndarray/base/nullary-strided1d/lib/1d.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ var offsets = require( './offsets.js' );
108108
* }
109109
* ];
110110
*
111-
* // Define a strategy:
112-
* function strategy( x ) {
111+
* // Define an input strategy:
112+
* function inputStrategy( x ) {
113113
* return {
114114
* 'dtype': x.dtype,
115115
* 'data': x.data,
@@ -120,6 +120,16 @@ var offsets = require( './offsets.js' );
120120
* };
121121
* }
122122
*
123+
* // Define an output strategy:
124+
* function outputStrategy( x ) {
125+
* return x;
126+
* }
127+
*
128+
* var strategy = {
129+
* 'input': inputStrategy,
130+
* 'output': outputStrategy
131+
* }
132+
*
123133
* // Apply strided function:
124134
* nullary1d( wrapper, [ x, sortOrder ], views, [ 3 ], [ 4 ], strategy, {} );
125135
*
@@ -153,8 +163,9 @@ function nullary1d( fcn, arrays, views, shape, stridesX, strategyX, opts ) {
153163
// Iterate over the loop dimensions...
154164
for ( i0 = 0; i0 < S0; i0++ ) {
155165
setViewOffsets( views, iv );
156-
v[ 0 ] = strategyX( views[ 0 ] );
166+
v[ 0 ] = strategyX.input( views[ 0 ] );
157167
fcn( v, opts );
168+
strategyX.output( views[ 0 ] );
158169
incrementOffsets( iv, dv0 );
159170
}
160171
}

‎lib/node_modules/@stdlib/ndarray/base/nullary-strided1d/lib/2d.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ var offsets = require( './offsets.js' );
109109
* }
110110
* ];
111111
*
112-
* // Define a strategy:
113-
* function strategy( x ) {
112+
* // Define an input strategy:
113+
* function inputStrategy( x ) {
114114
* return {
115115
* 'dtype': x.dtype,
116116
* 'data': x.data,
@@ -121,6 +121,16 @@ var offsets = require( './offsets.js' );
121121
* };
122122
* }
123123
*
124+
* // Define an output strategy:
125+
* function outputStrategy( x ) {
126+
* return x;
127+
* }
128+
*
129+
* var strategy = {
130+
* 'input': inputStrategy,
131+
* 'output': outputStrategy
132+
* }
133+
*
124134
* // Apply strided function:
125135
* nullary2d( wrapper, [ x, sortOrder ], views, [ 1, 3 ], [ 12, 4 ], true, strategy, {} );
126136
*
@@ -183,8 +193,9 @@ function nullary2d( fcn, arrays, views, shape, stridesX, isRowMajor, strategyX,
183193
for ( i1 = 0; i1 < S1; i1++ ) {
184194
for ( i0 = 0; i0 < S0; i0++ ) {
185195
setViewOffsets( views, iv );
186-
v[ 0 ] = strategyX( views[ 0 ] );
196+
v[ 0 ] = strategyX.input( views[ 0 ] );
187197
fcn( v, opts );
198+
strategyX.output( views[ 0 ]);
188199
incrementOffsets( iv, dv0 );
189200
}
190201
incrementOffsets( iv, dv1 );

‎lib/node_modules/@stdlib/ndarray/base/nullary-strided1d/lib/2d_blocked.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ var offsets = require( './offsets.js' );
112112
* }
113113
* ];
114114
*
115-
* // Define a strategy:
116-
* function strategy( x ) {
115+
* // Define an input strategy:
116+
* function inputStrategy( x ) {
117117
* return {
118118
* 'dtype': x.dtype,
119119
* 'data': x.data,
@@ -124,6 +124,16 @@ var offsets = require( './offsets.js' );
124124
* };
125125
* }
126126
*
127+
* // Define an output strategy:
128+
* function outputStrategy( x ) {
129+
* return x;
130+
* }
131+
*
132+
* var strategy = {
133+
* 'input': inputStrategy,
134+
* 'output': outputStrategy
135+
* }
136+
*
127137
* // Apply strided function:
128138
* blockednullary2d( wrapper, [ x, sortOrder ], views, [ 1, 3 ], [ 12, 4 ], strategy, {} );
129139
*
@@ -211,8 +221,9 @@ function blockednullary2d( fcn, arrays, views, shape, stridesX, strategyX, opts
211221
for ( i1 = 0; i1 < s1; i1++ ) {
212222
for ( i0 = 0; i0 < s0; i0++ ) {
213223
setViewOffsets( views, iv );
214-
v[ 0 ] = strategyX( views[ 0 ] );
224+
v[ 0 ] = strategyX.input( views[ 0 ] );
215225
fcn( v, opts );
226+
strategyX.output( views[ 0 ] );
216227
incrementOffsets( iv, dv0 );
217228
}
218229
incrementOffsets( iv, dv1 );

‎lib/node_modules/@stdlib/ndarray/base/nullary-strided1d/lib/3d.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ var offsets = require( './offsets.js' );
109109
* }
110110
* ];
111111
*
112-
* // Define a strategy:
113-
* function strategy( x ) {
112+
* // Define an input strategy:
113+
* function inputStrategy( x ) {
114114
* return {
115115
* 'dtype': x.dtype,
116116
* 'data': x.data,
@@ -121,6 +121,16 @@ var offsets = require( './offsets.js' );
121121
* };
122122
* }
123123
*
124+
* // Define an output strategy:
125+
* function outputStrategy( x ) {
126+
* return x;
127+
* }
128+
*
129+
* var strategy = {
130+
* 'input': inputStrategy,
131+
* 'output': outputStrategy
132+
* }
133+
*
124134
* // Apply strided function:
125135
* nullary3d( wrapper, [ x, sortOrder ], views, [ 1, 1, 3 ], [ 12, 12, 4 ], true, strategy, {} );
126136
*
@@ -197,8 +207,9 @@ function nullary3d( fcn, arrays, views, shape, stridesX, isRowMajor, strategyX,
197207
for ( i1 = 0; i1 < S1; i1++ ) {
198208
for ( i0 = 0; i0 < S0; i0++ ) {
199209
setViewOffsets( views, iv );
200-
v[ 0 ] = strategyX( views[ 0 ] );
210+
v[ 0 ] = strategyX.input( views[ 0 ] );
201211
fcn( v, opts );
212+
strategyX.output( views[ 0 ] );
202213
incrementOffsets( iv, dv0 );
203214
}
204215
incrementOffsets( iv, dv1 );

‎lib/node_modules/@stdlib/ndarray/base/nullary-strided1d/lib/3d_blocked.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ var offsets = require( './offsets.js' );
114114
* }
115115
* ];
116116
*
117-
* // Define a strategy:
118-
* function strategy( x ) {
117+
* // Define an input strategy:
118+
* function inputStrategy( x ) {
119119
* return {
120120
* 'dtype': x.dtype,
121121
* 'data': x.data,
@@ -126,6 +126,16 @@ var offsets = require( './offsets.js' );
126126
* };
127127
* }
128128
*
129+
* // Define an output strategy:
130+
* function outputStrategy( x ) {
131+
* return x;
132+
* }
133+
*
134+
* var strategy = {
135+
* 'input': inputStrategy,
136+
* 'output': outputStrategy
137+
* }
138+
*
129139
* // Apply strided function:
130140
* blockednullary3d( wrapper, [ x, sortOrder ], views, [ 1, 1, 3 ], [ 12, 12, 4 ], strategy, {} );
131141
*
@@ -233,8 +243,9 @@ function blockednullary3d( fcn, arrays, views, shape, stridesX, strategyX, opts
233243
for ( i1 = 0; i1 < s1; i1++ ) {
234244
for ( i0 = 0; i0 < s0; i0++ ) {
235245
setViewOffsets( views, iv );
236-
v[ 0 ] = strategyX( views[ 0 ] );
246+
v[ 0 ] = strategyX.input( views[ 0 ] );
237247
fcn( v, opts );
248+
strategyX.output( views[ 0 ] );
238249
incrementOffsets( iv, dv0 );
239250
}
240251
incrementOffsets( iv, dv1 );

‎lib/node_modules/@stdlib/ndarray/base/nullary-strided1d/lib/4d.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ var offsets = require( './offsets.js' );
109109
* }
110110
* ];
111111
*
112-
* // Define a strategy:
113-
* function strategy( x ) {
112+
* // Define an input strategy:
113+
* function inputStrategy( x ) {
114114
* return {
115115
* 'dtype': x.dtype,
116116
* 'data': x.data,
@@ -121,6 +121,16 @@ var offsets = require( './offsets.js' );
121121
* };
122122
* }
123123
*
124+
* // Define an output strategy:
125+
* function outputStrategy( x ) {
126+
* return x;
127+
* }
128+
*
129+
* var strategy = {
130+
* 'input': inputStrategy,
131+
* 'output': outputStrategy
132+
* }
133+
*
124134
* // Apply strided function:
125135
* nullary4d( wrapper, [ x, sortOrder ], views, [ 1, 1, 1, 3 ], [ 12, 12, 12, 4 ], true, strategy, {} );
126136
*
@@ -211,8 +221,9 @@ function nullary4d( fcn, arrays, views, shape, stridesX, isRowMajor, strategyX,
211221
for ( i1 = 0; i1 < S1; i1++ ) {
212222
for ( i0 = 0; i0 < S0; i0++ ) {
213223
setViewOffsets( views, iv );
214-
v[ 0 ] = strategyX( views[ 0 ] );
224+
v[ 0 ] = strategyX.input( views[ 0 ] );
215225
fcn( v, opts );
226+
strategyX.input( views[ 0 ] );
216227
incrementOffsets( iv, dv0 );
217228
}
218229
incrementOffsets( iv, dv1 );

‎lib/node_modules/@stdlib/ndarray/base/nullary-strided1d/lib/4d_blocked.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ var offsets = require( './offsets.js' );
114114
* }
115115
* ];
116116
*
117-
* // Define a strategy:
118-
* function strategy( x ) {
117+
* // Define an input strategy:
118+
* function inputStrategy( x ) {
119119
* return {
120120
* 'dtype': x.dtype,
121121
* 'data': x.data,
@@ -126,6 +126,16 @@ var offsets = require( './offsets.js' );
126126
* };
127127
* }
128128
*
129+
* // Define an output strategy:
130+
* function outputStrategy( x ) {
131+
* return x;
132+
* }
133+
*
134+
* var strategy = {
135+
* 'input': inputStrategy,
136+
* 'output': outputStrategy
137+
* }
138+
*
129139
* // Apply strided function:
130140
* blockednullary4d( wrapper, [ x, sortOrder ], views, [ 1, 1, 1, 3 ], [ 12, 12, 12, 4 ], strategy, {} );
131141
*
@@ -253,8 +263,9 @@ function blockednullary4d( fcn, arrays, views, shape, stridesX, strategyX, opts
253263
for ( i1 = 0; i1 < s1; i1++ ) {
254264
for ( i0 = 0; i0 < s0; i0++ ) {
255265
setViewOffsets( views, iv );
256-
v[ 0 ] = strategyX( views[ 0 ] );
266+
v[ 0 ] = strategyX.input( views[ 0 ] );
257267
fcn( v, opts );
268+
strategyX.output( views[ 0 ] );
258269
incrementOffsets( iv, dv0 );
259270
}
260271
incrementOffsets( iv, dv1 );

0 commit comments

Comments
 (0)