Skip to content

Commit e268004

Browse files
chore: address commit comments for betaprime/mean
PR-URL: #5081 Closes: #5070 Reviewed-by: Philipp Burckhardt <[email protected]>
1 parent 84a04f3 commit e268004

File tree

8 files changed

+10
-36
lines changed

8 files changed

+10
-36
lines changed

lib/node_modules/@stdlib/stats/base/dists/betaprime/mean/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ Returns the expected value for a beta prime distribution with first shape parame
176176

177177
```c
178178
double y = stdlib_base_dists_betaprime_mean( 1.0, 2.0 );
179-
// returns ~1.0
179+
// returns 1.0
180180
```
181181

182182
The function accepts the following arguments:
@@ -228,7 +228,7 @@ int main( void ) {
228228
alpha = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
229229
beta = random_uniform( 1.0 + STDLIB_CONSTANT_FLOAT64_EPS, 11.0 );
230230
y = stdlib_base_dists_betaprime_mean( alpha, beta );
231-
printf( "α: %1f, β: %1f, E(X;α,β): %lf\n", alpha, beta, y );
231+
printf( "α: %lf, β: %lf, E(X;α,β): %lf\n", alpha, beta, y );
232232
}
233233
}
234234
```

lib/node_modules/@stdlib/stats/base/dists/betaprime/mean/benchmark/benchmark.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,9 @@ bench( pkg, function benchmark( b ) {
4040

4141
len = 100;
4242
alpha = new Float64Array( len );
43-
for ( i = 0; i < len; i++ ) {
44-
alpha[ i ] = uniform( EPS, 10.0 );
45-
}
4643
beta = new Float64Array( len );
4744
for ( i = 0; i < len; i++ ) {
45+
alpha[ i ] = uniform( EPS, 10.0 );
4846
beta[ i ] = uniform( 1.0 + EPS, 11.0 );
4947
}
5048

lib/node_modules/@stdlib/stats/base/dists/betaprime/mean/benchmark/benchmark.native.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,9 @@ bench( pkg+'::native', opts, function benchmark( b ) {
4949

5050
len = 100;
5151
alpha = new Float64Array( len );
52-
for ( i = 0; i < len; i++ ) {
53-
alpha[ i ] = uniform( EPS, 10.0 );
54-
}
5552
beta = new Float64Array( len );
5653
for ( i = 0; i < len; i++ ) {
54+
alpha[ i ] = uniform( EPS, 10.0 );
5755
beta[ i ] = uniform( 1.0 + EPS, 11.0 );
5856
}
5957

lib/node_modules/@stdlib/stats/base/dists/betaprime/mean/benchmark/c/benchmark.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,6 @@ static double benchmark( void ) {
102102

103103
for ( i = 0; i < 100; i++ ) {
104104
alpha[ i ] = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
105-
}
106-
for ( i = 0; i < 100; i++ ) {
107105
beta[ i ] = random_uniform( 1.0 + STDLIB_CONSTANT_FLOAT64_EPS, 11.0 );
108106
}
109107

lib/node_modules/@stdlib/stats/base/dists/betaprime/mean/examples/c/example.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,6 @@ int main( void ) {
3636
alpha = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
3737
beta = random_uniform( 1.0 + STDLIB_CONSTANT_FLOAT64_EPS, 11.0 );
3838
y = stdlib_base_dists_betaprime_mean( alpha, beta );
39-
printf( "α: %1f, β: %1f, E(X;α,β): %lf\n", alpha, beta, y );
39+
printf( "α: %lf, β: %lf, E(X;α,β): %lf\n", alpha, beta, y );
4040
}
4141
}

lib/node_modules/@stdlib/stats/base/dists/betaprime/mean/src/main.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@
2424
* @param x input value
2525
* @param alpha first shape parameter
2626
* @param beta second shape parameter
27-
* @returns expected value
27+
* @return expected value
2828
*
2929
* @example
3030
* double y = stdlib_base_dists_betaprime_mean( 1.0, 2.0 );
31-
* // returns ~1.0
31+
* // returns 1.0
3232
*/
33-
double stdlib_base_dists_betaprime_mean( double alpha, const double beta ) {
33+
double stdlib_base_dists_betaprime_mean( const double alpha, const double beta ) {
3434
if ( alpha <= 0.0 || beta <= 1.0 ) {
3535
return 0.0 / 0.0;
3636
}

lib/node_modules/@stdlib/stats/base/dists/betaprime/mean/test/test.js

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,9 @@
2121
// MODULES //
2222

2323
var tape = require( 'tape' );
24-
var abs = require( '@stdlib/math/base/special/abs' );
2524
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2625
var PINF = require( '@stdlib/constants/float64/pinf' );
2726
var NINF = require( '@stdlib/constants/float64/ninf' );
28-
var EPS = require( '@stdlib/constants/float64/eps' );
2927
var mean = require( './../lib' );
3028

3129

@@ -102,10 +100,8 @@ tape( 'if provided `beta <= 1`, the function returns `NaN`', function test( t )
102100

103101
tape( 'the function returns the mean of a beta prime distribution', function test( t ) {
104102
var expected;
105-
var delta;
106103
var alpha;
107104
var beta;
108-
var tol;
109105
var i;
110106
var y;
111107

@@ -114,13 +110,7 @@ tape( 'the function returns the mean of a beta prime distribution', function tes
114110
beta = data.beta;
115111
for ( i = 0; i < expected.length; i++ ) {
116112
y = mean( alpha[i], beta[i] );
117-
if ( y === expected[i] ) {
118-
t.equal( y, expected[i], 'alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] );
119-
} else {
120-
delta = abs( y - expected[ i ] );
121-
tol = 1.0 * EPS * abs( expected[ i ] );
122-
t.ok( delta <= tol, 'within tolerance. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
123-
}
113+
t.equal( y, expected[i], 'alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] );
124114
}
125115
t.end();
126116
});

lib/node_modules/@stdlib/stats/base/dists/betaprime/mean/test/test.native.js

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,10 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var tape = require( 'tape' );
25-
var abs = require( '@stdlib/math/base/special/abs' );
2625
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2726
var tryRequire = require( '@stdlib/utils/try-require' );
2827
var PINF = require( '@stdlib/constants/float64/pinf' );
2928
var NINF = require( '@stdlib/constants/float64/ninf' );
30-
var EPS = require( '@stdlib/constants/float64/eps' );
3129

3230

3331
// FIXTURES //
@@ -111,10 +109,8 @@ tape( 'if provided `beta <= 1`, the function returns `NaN`', opts, function test
111109

112110
tape( 'the function returns the mean of a beta prime distribution', opts, function test( t ) {
113111
var expected;
114-
var delta;
115112
var alpha;
116113
var beta;
117-
var tol;
118114
var i;
119115
var y;
120116

@@ -123,13 +119,7 @@ tape( 'the function returns the mean of a beta prime distribution', opts, functi
123119
beta = data.beta;
124120
for ( i = 0; i < expected.length; i++ ) {
125121
y = mean( alpha[i], beta[i] );
126-
if ( y === expected[i] ) {
127-
t.equal( y, expected[i], 'alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] );
128-
} else {
129-
delta = abs( y - expected[ i ] );
130-
tol = 1.0 * EPS * abs( expected[ i ] );
131-
t.ok( delta <= tol, 'within tolerance. alpha: '+alpha[i]+'. beta: '+beta[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
132-
}
122+
t.equal( y, expected[i], 'alpha: '+alpha[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] );
133123
}
134124
t.end();
135125
});

0 commit comments

Comments
 (0)