Skip to content

Commit e4a2e9c

Browse files
committed
feat: use inbuilt stdlib functions instead of those from math.h
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---
1 parent 75acb98 commit e4a2e9c

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

lib/node_modules/@stdlib/stats/base/dcumaxabs/manifest.json

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
"dependencies": [
4141
"@stdlib/math/base/assert/is-nan",
4242
"@stdlib/blas/base/shared",
43+
"@stdlib/math/base/special/abs",
4344
"@stdlib/strided/base/stride2offset",
4445
"@stdlib/napi/export",
4546
"@stdlib/napi/argv",
@@ -61,7 +62,8 @@
6162
"dependencies": [
6263
"@stdlib/blas/base/shared",
6364
"@stdlib/strided/base/stride2offset",
64-
"@stdlib/math/base/assert/is-nan"
65+
"@stdlib/math/base/assert/is-nan",
66+
"@stdlib/math/base/special/abs"
6567
]
6668
},
6769
{
@@ -78,7 +80,8 @@
7880
"dependencies": [
7981
"@stdlib/blas/base/shared",
8082
"@stdlib/strided/base/stride2offset",
81-
"@stdlib/math/base/assert/is-nan"
83+
"@stdlib/math/base/assert/is-nan",
84+
"@stdlib/math/base/special/abs"
8285
]
8386
},
8487
{
@@ -95,7 +98,8 @@
9598
"dependencies": [
9699
"@stdlib/blas/base/shared",
97100
"@stdlib/strided/base/stride2offset",
98-
"@stdlib/math/base/assert/is-nan"
101+
"@stdlib/math/base/assert/is-nan",
102+
"@stdlib/math/base/special/abs"
99103
]
100104
}
101105
]

lib/node_modules/@stdlib/stats/base/dcumaxabs/src/main.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818

1919
#include "stdlib/stats/base/dcumaxabs.h"
2020
#include "stdlib/math/base/assert/is_nan.h"
21+
#include "stdlib/math/base/special/abs.h"
2122
#include "stdlib/blas/base/shared.h"
2223
#include "stdlib/strided/base/stride2offset.h"
23-
#include <math.h>
2424

2525
/**
2626
* Computes the cumulative maximum absolute value of double-precision floating-point strided array elements.
@@ -61,15 +61,15 @@ void API_SUFFIX(stdlib_strided_dcumaxabs_ndarray)( const CBLAS_INT N, const doub
6161
}
6262
ix = offsetX;
6363
iy = offsetY;
64-
max = fabs( X[ ix ] );
64+
max = stdlib_base_abs( X[ ix ] );
6565
Y[ iy ] = max;
6666

6767
iy += strideY;
6868
i = 1;
6969
if ( !stdlib_base_is_nan( max ) ) {
7070
for (; i < N; i++ ) {
7171
ix += strideX;
72-
v = fabs( X[ ix ] );
72+
v = stdlib_base_abs( X[ ix ] );
7373
if ( stdlib_base_is_nan( v ) ) {
7474
max = v;
7575
break;

0 commit comments

Comments
 (0)