Skip to content

Commit e8fb7dc

Browse files
committed
build: tweak issue body and fix indentation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: passed - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---
1 parent 94152d4 commit e8fb7dc

File tree

1 file changed

+24
-24
lines changed

1 file changed

+24
-24
lines changed

.github/workflows/scripts/create_address_commit_comments_issues

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -237,27 +237,27 @@ is_core_contributor() {
237237
# $1 - Commit SHA (the key)
238238
# $2 - Comment URL (the link)
239239
update_commit_map() {
240-
local key="$1"
241-
local link="$2"
242-
local found=0
243-
local i=0
244-
245-
for existing in "${commit_keys[@]}"; do
246-
if [ "$existing" = "$key" ]; then
247-
commit_counts[i]=$(( commit_counts[i] + 1 ))
248-
# Append the comment URL (on a new bullet) to the existing list:
249-
commit_links[i]="${commit_links[i]}"$'\n'"- ${link}"
250-
found=1
251-
break
252-
fi
253-
i=$(( i + 1 ))
254-
done
255-
256-
if [ "$found" -eq 0 ]; then
257-
commit_keys+=("$key")
258-
commit_counts+=("1")
259-
commit_links+=("- ${link}")
260-
fi
240+
local key="$1"
241+
local link="$2"
242+
local found=0
243+
local i=0
244+
245+
for existing in "${commit_keys[@]}"; do
246+
if [ "$existing" = "$key" ]; then
247+
commit_counts[i]=$(( commit_counts[i] + 1 ))
248+
# Append the comment URL (on a new bullet) to the existing list:
249+
commit_links[i]="${commit_links[i]}"$'\n'"- ${link}"
250+
found=1
251+
break
252+
fi
253+
i=$(( i + 1 ))
254+
done
255+
256+
if [ "$found" -eq 0 ]; then
257+
commit_keys+=("$key")
258+
commit_counts+=("1")
259+
commit_links+=("- ${link}")
260+
fi
261261
}
262262

263263
# Main execution sequence.
@@ -378,7 +378,7 @@ main() {
378378

379379
# Generate a short SHA (first 7 characters):
380380
local short_sha=${commit_sha:0:7}
381-
local issue_title="Address commit comments (commit ${short_sha})"
381+
local issue_title="Address commit comments (commit \`${short_sha}\`)"
382382
local commit_link="https://github.com/${owner}/${repo}/commit/${commit_sha}"
383383
local issue_body="This commit has **${count}** comment(s) from core contributors that require attention.
384384
@@ -391,8 +391,8 @@ Interested in helping improve the project? If you are, the comment linked to abo
391391
392392
What do you need to do?
393393
394-
1. Open the link to the commit above.
395-
2. Find all the comments which mention @stdlib-bot. These comments should describe follow-up tasks or desired changes, such as formatting improvements, small refactorings, or clean-up.
394+
1. Open the above linked comments mentioning @stdlib-bot.
395+
2. Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
396396
3. If you are a first-time contributor, follow the [contributing](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md) and [development](https://github.com/stdlib-js/stdlib/blob/develop/docs/development.md) guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
397397
4. Make all the desired changes and commit those changes to a local branch.
398398
5. Push the changes to GitHub and open a new pull request against the \`develop\` branch of the main stdlib development [repository](https://github.com/stdlib-js/stdlib).

0 commit comments

Comments
 (0)