Skip to content

Commit e9f4e07

Browse files
refactor: update blas/ext/base/dsnansumpw to follow current conventions
PR-URL: #2855 Closes: #1494 --------- Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
1 parent 4bddc16 commit e9f4e07

20 files changed

+221
-306
lines changed

lib/node_modules/@stdlib/blas/ext/base/dsnansumpw/README.md

Lines changed: 13 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,14 @@ The function has the following parameters:
5656
- **x**: input [`Float32Array`][@stdlib/array/float32].
5757
- **stride**: index increment for `x`.
5858

59-
The `N` and `stride` parameters determine which elements in `x` are accessed at runtime. For example, to compute the sum of every other element in `x`,
59+
The `N` and `stride` parameters determine which elements in the strided array are accessed at runtime. For example, to compute the sum of every other element in `x`,
6060

6161
```javascript
6262
var Float32Array = require( '@stdlib/array/float32' );
63-
var floor = require( '@stdlib/math/base/special/floor' );
6463

6564
var x = new Float32Array( [ 1.0, 2.0, NaN, -7.0, NaN, 3.0, 4.0, 2.0 ] );
66-
var N = floor( x.length / 2 );
6765

68-
var v = dsnansumpw( N, x, 2 );
66+
var v = dsnansumpw( 4, x, 2 );
6967
// returns 5.0
7068
```
7169

@@ -75,14 +73,11 @@ Note that indexing is relative to the first index. To introduce an offset, use [
7573

7674
```javascript
7775
var Float32Array = require( '@stdlib/array/float32' );
78-
var floor = require( '@stdlib/math/base/special/floor' );
7976

8077
var x0 = new Float32Array( [ 2.0, 1.0, NaN, -2.0, -2.0, 2.0, 3.0, 4.0 ] );
8178
var x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element
8279

83-
var N = floor( x0.length / 2 );
84-
85-
var v = dsnansumpw( N, x1, 2 );
80+
var v = dsnansumpw( 4, x1, 2 );
8681
// returns 5.0
8782
```
8883

@@ -108,12 +103,10 @@ While [`typed array`][mdn-typed-array] views mandate a view offset based on the
108103

109104
```javascript
110105
var Float32Array = require( '@stdlib/array/float32' );
111-
var floor = require( '@stdlib/math/base/special/floor' );
112106

113107
var x = new Float32Array( [ 2.0, 1.0, NaN, -2.0, -2.0, 2.0, 3.0, 4.0 ] );
114-
var N = floor( x.length / 2 );
115108

116-
var v = dsnansumpw.ndarray( N, x, 2, 1 );
109+
var v = dsnansumpw.ndarray( 4, x, 2, 1 );
117110
// returns 5.0
118111
```
119112

@@ -139,22 +132,19 @@ var v = dsnansumpw.ndarray( N, x, 2, 1 );
139132
<!-- eslint no-undef: "error" -->
140133

141134
```javascript
142-
var randu = require( '@stdlib/random/base/randu' );
143-
var round = require( '@stdlib/math/base/special/round' );
144-
var Float32Array = require( '@stdlib/array/float32' );
135+
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
136+
var bernoulli = require( '@stdlib/random/base/bernoulli' );
137+
var filledarrayBy = require( '@stdlib/array/filled-by' );
145138
var dsnansumpw = require( '@stdlib/blas/ext/base/dsnansumpw' );
146139

147-
var x;
148-
var i;
149-
150-
x = new Float32Array( 10 );
151-
for ( i = 0; i < x.length; i++ ) {
152-
if ( randu() < 0.2 ) {
153-
x[ i ] = NaN;
154-
} else {
155-
x[ i ] = round( randu()*100.0 );
140+
function rand() {
141+
if ( bernoulli( 0.8 ) > 0 ) {
142+
return NaN;
156143
}
144+
return discreteUniform( 0, 100 );
157145
}
146+
147+
var x = filledarrayBy( 10, 'float32', rand );
158148
console.log( x );
159149

160150
var v = dsnansumpw( x.length, x, 1 );

lib/node_modules/@stdlib/blas/ext/base/dsnansumpw/benchmark/benchmark.js

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/base/uniform' );
25+
var bernoulli = require( '@stdlib/random/base/bernoulli' );
26+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2527
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2628
var pow = require( '@stdlib/math/base/special/pow' );
27-
var Float32Array = require( '@stdlib/array/float32' );
2829
var pkg = require( './../package.json' ).name;
2930
var dsnansumpw = require( './../lib/dsnansumpw.js' );
3031

@@ -39,18 +40,15 @@ var dsnansumpw = require( './../lib/dsnansumpw.js' );
3940
* @returns {Function} benchmark function
4041
*/
4142
function createBenchmark( len ) {
42-
var x;
43-
var i;
43+
var x = filledarrayBy( len, 'float32', rand );
44+
return benchmark;
4445

45-
x = new Float32Array( len );
46-
for ( i = 0; i < x.length; i++ ) {
47-
if ( randu() < 0.2 ) {
48-
x[ i ] = NaN;
49-
} else {
50-
x[ i ] = ( randu()*10.0 ) - 20.0;
46+
function rand() {
47+
if ( bernoulli( 0.8 ) > 0 ) {
48+
return NaN;
5149
}
50+
return uniform( -10, 10 );
5251
}
53-
return benchmark;
5452

5553
function benchmark( b ) {
5654
var v;

lib/node_modules/@stdlib/blas/ext/base/dsnansumpw/benchmark/benchmark.native.js

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,11 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/base/uniform' );
26+
var bernoulli = require( '@stdlib/random/base/bernoulli' );
27+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2628
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2729
var pow = require( '@stdlib/math/base/special/pow' );
28-
var Float32Array = require( '@stdlib/array/float32' );
2930
var tryRequire = require( '@stdlib/utils/try-require' );
3031
var pkg = require( './../package.json' ).name;
3132

@@ -48,18 +49,15 @@ var opts = {
4849
* @returns {Function} benchmark function
4950
*/
5051
function createBenchmark( len ) {
51-
var x;
52-
var i;
52+
var x = filledarrayBy( len, 'float32', rand );
53+
return benchmark;
5354

54-
x = new Float32Array( len );
55-
for ( i = 0; i < x.length; i++ ) {
56-
if ( randu() < 0.2 ) {
57-
x[ i ] = NaN;
58-
} else {
59-
x[ i ] = ( randu()*10.0 ) - 20.0;
55+
function rand() {
56+
if ( bernoulli( 0.8 ) > 0 ) {
57+
return NaN;
6058
}
59+
return uniform( -10, 10 );
6160
}
62-
return benchmark;
6361

6462
function benchmark( b ) {
6563
var v;

lib/node_modules/@stdlib/blas/ext/base/dsnansumpw/benchmark/benchmark.ndarray.js

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/base/uniform' );
25+
var bernoulli = require( '@stdlib/random/base/bernoulli' );
26+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2527
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2628
var pow = require( '@stdlib/math/base/special/pow' );
27-
var Float32Array = require( '@stdlib/array/float32' );
2829
var pkg = require( './../package.json' ).name;
2930
var dsnansumpw = require( './../lib/ndarray.js' );
3031

@@ -39,18 +40,15 @@ var dsnansumpw = require( './../lib/ndarray.js' );
3940
* @returns {Function} benchmark function
4041
*/
4142
function createBenchmark( len ) {
42-
var x;
43-
var i;
43+
var x = filledarrayBy( len, 'float32', rand );
44+
return benchmark;
4445

45-
x = new Float32Array( len );
46-
for ( i = 0; i < x.length; i++ ) {
47-
if ( randu() < 0.2 ) {
48-
x[ i ] = NaN;
49-
} else {
50-
x[ i ] = ( randu()*10.0 ) - 20.0;
46+
function rand() {
47+
if ( bernoulli( 0.8 ) > 0 ) {
48+
return NaN;
5149
}
50+
return uniform( -10, 10 );
5251
}
53-
return benchmark;
5452

5553
function benchmark( b ) {
5654
var v;

lib/node_modules/@stdlib/blas/ext/base/dsnansumpw/benchmark/benchmark.ndarray.native.js

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,11 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/base/uniform' );
26+
var bernoulli = require( '@stdlib/random/base/bernoulli' );
27+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2628
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2729
var pow = require( '@stdlib/math/base/special/pow' );
28-
var Float32Array = require( '@stdlib/array/float32' );
2930
var tryRequire = require( '@stdlib/utils/try-require' );
3031
var pkg = require( './../package.json' ).name;
3132

@@ -48,18 +49,15 @@ var opts = {
4849
* @returns {Function} benchmark function
4950
*/
5051
function createBenchmark( len ) {
51-
var x;
52-
var i;
52+
var x = filledarrayBy( len, 'float32', rand );
53+
return benchmark;
5354

54-
x = new Float32Array( len );
55-
for ( i = 0; i < x.length; i++ ) {
56-
if ( randu() < 0.2 ) {
57-
x[ i ] = NaN;
58-
} else {
59-
x[ i ] = ( randu()*10.0 ) - 20.0;
55+
function rand() {
56+
if ( bernoulli( 0.8 ) > 0 ) {
57+
return NaN;
6058
}
59+
return uniform( -10, 10 );
6160
}
62-
return benchmark;
6361

6462
function benchmark( b ) {
6563
var v;

lib/node_modules/@stdlib/blas/ext/base/dsnansumpw/docs/repl.txt

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
ignoring `NaN` values, using pairwise summation with extended accumulation,
55
and returning an extended precision result.
66

7-
The `N` and `stride` parameters determine which elements in `x` are accessed
8-
at runtime.
7+
The `N` and `stride` parameters determine which elements in the strided
8+
array are accessed at runtime.
99

1010
Indexing is relative to the first index. To introduce an offset, use a typed
1111
array view.
@@ -37,19 +37,16 @@
3737

3838
// Using `N` and `stride` parameters:
3939
> x = new {{alias:@stdlib/array/float32}}( [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0, NaN, NaN ] );
40-
> var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
41-
> var stride = 2;
42-
> {{alias}}( N, x, stride )
40+
> {{alias}}( 4, x, 2 )
4341
1.0
4442

4543
// Using view offsets:
4644
> var x0 = new {{alias:@stdlib/array/float32}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0, NaN, NaN ] );
4745
> var x1 = new {{alias:@stdlib/array/float32}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 );
48-
> N = {{alias:@stdlib/math/base/special/floor}}( x0.length / 2 );
49-
> stride = 2;
50-
> {{alias}}( N, x1, stride )
46+
> {{alias}}( 4, x1, 2 )
5147
-1.0
5248

49+
5350
{{alias}}.ndarray( N, x, stride, offset )
5451
Computes the sum of single-precision floating-point strided array elements,
5552
ignoring `NaN` values and using pairwise summation with extended
@@ -87,8 +84,7 @@
8784

8885
// Using offset parameter:
8986
> var x = new {{alias:@stdlib/array/float32}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0, NaN, NaN ] );
90-
> var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
91-
> {{alias}}.ndarray( N, x, 2, 1 )
87+
> {{alias}}.ndarray( 4, x, 2, 1 )
9288
-1.0
9389

9490
See Also

lib/node_modules/@stdlib/blas/ext/base/dsnansumpw/examples/index.js

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,19 @@
1818

1919
'use strict';
2020

21-
var randu = require( '@stdlib/random/base/randu' );
22-
var round = require( '@stdlib/math/base/special/round' );
23-
var Float32Array = require( '@stdlib/array/float32' );
21+
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
22+
var bernoulli = require( '@stdlib/random/base/bernoulli' );
23+
var filledarrayBy = require( '@stdlib/array/filled-by' );
2424
var dsnansumpw = require( './../lib' );
2525

26-
var x;
27-
var i;
28-
29-
x = new Float32Array( 10 );
30-
for ( i = 0; i < x.length; i++ ) {
31-
if ( randu() < 0.2 ) {
32-
x[ i ] = NaN;
33-
} else {
34-
x[ i ] = round( randu()*100.0 );
26+
function rand() {
27+
if ( bernoulli( 0.8 ) > 0 ) {
28+
return NaN;
3529
}
30+
return discreteUniform( 0, 100 );
3631
}
32+
33+
var x = filledarrayBy( 10, 'float32', rand );
3734
console.log( x );
3835

3936
var v = dsnansumpw( x.length, x, 1 );

lib/node_modules/@stdlib/blas/ext/base/dsnansumpw/include.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Source files:
3838
'src_files': [
39-
'<(src_dir)/addon.cpp',
39+
'<(src_dir)/addon.c',
4040
'<!@(node -e "var arr = require(\'@stdlib/utils/library-manifest\')(\'./manifest.json\',{},{\'basedir\':process.cwd(),\'paths\':\'posix\'}).src; for ( var i = 0; i < arr.length; i++ ) { console.log( arr[ i ] ); }")',
4141
],
4242

lib/node_modules/@stdlib/blas/ext/base/dsnansumpw/lib/dsnansumpw.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,8 @@ var sum = require( './ndarray.js' );
4646
* var Float32Array = require( '@stdlib/array/float32' );
4747
*
4848
* var x = new Float32Array( [ 1.0, -2.0, NaN, 2.0 ] );
49-
* var N = x.length;
5049
*
51-
* var v = dsnansumpw( N, x, 1 );
50+
* var v = dsnansumpw( x.length, x, 1 );
5251
* // returns 1.0
5352
*/
5453
function dsnansumpw( N, x, stride ) {

lib/node_modules/@stdlib/blas/ext/base/dsnansumpw/lib/dsnansumpw.native.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,8 @@ var addon = require( './../src/addon.node' );
3737
* var Float32Array = require( '@stdlib/array/float32' );
3838
*
3939
* var x = new Float32Array( [ 1.0, -2.0, NaN, 2.0 ] );
40-
* var N = x.length;
4140
*
42-
* var v = dsnansumpw( N, x, 1 );
41+
* var v = dsnansumpw( x.length, x, 1 );
4342
* // returns 1.0
4443
*/
4544
function dsnansumpw( N, x, stride ) {

0 commit comments

Comments
 (0)