Skip to content

Commit f08e6b0

Browse files
committed
refactor: use early returns
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 895313e commit f08e6b0

File tree

1 file changed

+12
-5
lines changed
  • lib/node_modules/@stdlib/_tools/doctest/compare-values/lib

1 file changed

+12
-5
lines changed

lib/node_modules/@stdlib/_tools/doctest/compare-values/lib/main.js

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,9 @@ function checkForPlaceholders( actual, expected ) {
202202
case '<RangeError>':
203203
return isRangeError( actual );
204204
default:
205-
// Uknown type, let it slide...
205+
// Unknown type, let it slide...
206+
207+
// FIXME: should we compare constructor names here at a minimum?
206208
return true;
207209
}
208210
}
@@ -385,28 +387,32 @@ function compareValues( actual, expected ) {
385387
if ( !checkPrimitive( actual, expected ) ) {
386388
return 'Displayed return value is `'+expected+'`, but expected `'+actual+'` instead';
387389
}
390+
return null;
388391
}
389-
else if ( isTypedArray( actual ) ) {
392+
if ( isTypedArray( actual ) ) {
390393
return checkTypedArrays( actual, expected );
391394
}
392395
if ( isArray( actual ) ) {
393396
if ( !checkArray( actual, expected ) ) {
394397
return 'Displayed return value is `'+expected+'`, but expected `'+createAnnotationValue( actual )+'` instead';
395398
}
399+
return null;
396400
}
397-
else if ( isRegExp( actual ) ) {
401+
if ( isRegExp( actual ) ) {
398402
actual = actual.toString();
399403
if ( actual !== expected ) {
400404
return 'Displayed return value is `'+expected+'`, but expected `'+actual+'` instead';
401405
}
406+
return null;
402407
}
403-
else if ( isFunction( actual ) ) {
408+
if ( isFunction( actual ) ) {
404409
actual = actual.toString();
405410
if ( actual !== expected ) {
406411
return 'Displayed return value is `'+expected+'`, but expected `'+actual+'` instead';
407412
}
413+
return null;
408414
}
409-
else if ( isObjectLike( actual ) ) {
415+
if ( isObjectLike( actual ) ) {
410416
if ( !contains( expected, '...' ) ) {
411417
try {
412418
expectedValue = parse( expected );
@@ -419,6 +425,7 @@ function compareValues( actual, expected ) {
419425
return 'Displayed return value is `'+expected+'`, but expected `'+actualString+'` instead';
420426
}
421427
}
428+
return null;
422429
}
423430
return null;
424431
}

0 commit comments

Comments
 (0)