test(values): add missing test case and improve code style

Author: yuvimittal

lib/node_modules/@stdlib/array/fixed-endian-factory/benchmark/benchmark.values.js

@@ -45,7 +45,6 @@ bench( pkg+':values', function benchmark( b ) {
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {
 		iter = arr.values();
-
 		for ( value of iter ) {
 			if ( isnan( value ) ) {
 				b.fail( 'should not return NaN' );

lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js

@@ -860,22 +860,22 @@ function factory( dtype ) { // eslint-disable-line max-lines-per-function, stdli
  * @throws {TypeError} `this` must be a typed array instance
  * @returns {Object} iterator for array elements
  */
-	setReadOnly(TypedArray.prototype, 'values', function values() {
+	setReadOnly( TypedArray.prototype, 'values', function values() {
 		var iterator;
 		var index = 0;
 		var value;
 		var isLE = this._isLE;
 		var buf = this._buffer;
 		var len = this._length;
 
-		if (!isTypedArray(this)) {
-			throw new TypeError(format('invalid invocation. `this` is not %s %s.', CHAR2ARTICLE[dtype[0]], CTOR_NAME));
+		if ( !isTypedArray( this ) ) {
+			throw new TypeError(format( 'invalid invocation. `this` is not %s %s.', CHAR2ARTICLE[ dtype[0] ], CTOR_NAME ) );
 		}
 
 		iterator = {
 			'next': function next() {
-				if (index < len) {
-					value = buf[GETTER](index * BYTES_PER_ELEMENT, isLE);
+				if ( index < len ) {
+					value = buf[ GETTER ]( index * BYTES_PER_ELEMENT, isLE );
 					index += 1;
 					return {
 						'value': value,
@@ -888,7 +888,7 @@ function factory( dtype ) { // eslint-disable-line max-lines-per-function, stdli
 			}
 		};
 
-		iterator[Symbol.iterator] = function iterator() {
+		iterator[ Symbol.iterator ] = function iterator() {
 			return this;
 		};
 

lib/node_modules/@stdlib/array/fixed-endian-factory/test/test.values.js

@@ -21,6 +21,7 @@
 // MODULES //
 
 var tape = require( 'tape' );
+var hasOwnProp = require( '@stdlib/assert/has-own-property' );
 var isFunction = require( '@stdlib/assert/is-function' );
 var factory = require( './../lib' );
 
@@ -43,11 +44,18 @@ tape( 'the `values` method returns an iterator function', function test( t ) {
 	t.end();
 });
 
+tape( 'attached to the prototype of the returned function is a `values` method', function test( t ) {
+	var ctor = factory( 'float64' );
+	t.strictEqual( hasOwnProp( ctor.prototype, 'values' ), true, 'has `values` method on the prototype' );
+	t.strictEqual( isFunction( ctor.prototype.values ), true, '`values` is a function' );
+	t.end();
+});
+
 tape( 'the `values` iterator stops when all elements are iterated', function test( t ) {
 	var iterator;
 	var result;
 	var ctor = factory( 'float64' );
-	var arr = new ctor( 'little-endian', [1.0, 2.0, 3.0, 4.0, 5.0] );
+	var arr = new ctor( 'little-endian', [ 1.0, 2.0, 3.0, 4.0, 5.0 ] );
 
 	iterator = arr.values();
 
@@ -108,7 +116,7 @@ tape( 'the `values` iterator returns the correct value for typed arrays with dif
 	var iterator;
 	var result;
 	var ctor = factory( 'float64' );
-	var arr = new ctor( 'little-endian', [10.5, 20.5, 30.5] );
+	var arr = new ctor( 'little-endian', [ 10.5, 20.5, 30.5 ] );
 
 	iterator = arr.values();
 
@@ -142,21 +150,21 @@ tape( 'the `values` iterator works with `for...of` loop', function test( t ) {
 	var values = [];
 	var value;
 	var ctor = factory( 'float64' );
-	var arr = new ctor( 'little-endian', [1.0, 2.0, 3.0, 4.0, 5.0] );
+	var arr = new ctor( 'little-endian', [ 1.0, 2.0, 3.0, 4.0, 5.0 ] );
 
 	for ( value of arr.values() ) {
 		values.push( value );
 	}
 
-	t.deepEqual( values, [1.0, 2.0, 3.0, 4.0, 5.0], 'correctly iterates over values' );
+	t.deepEqual( values, [ 1.0, 2.0, 3.0, 4.0, 5.0 ], 'correctly iterates over values' );
 	t.end();
 });
 
 tape( 'the `values` iterator supports providing an execution context', function test( t ) {
 	var iterator;
 	var result;
 	var ctor = factory( 'float64' );
-	var arr = new ctor( 'little-endian', [1.0, 2.0, 3.0, 4.0, 5.0] );
+	var arr = new ctor( 'little-endian', [ 1.0, 2.0, 3.0, 4.0, 5.0 ] );
 	var ctx = {
 		'threshold': 3
 	};
@@ -198,10 +206,10 @@ tape( 'the `values` iterator throws an error when `this` is not a typed array',
 	];
 
 	var ctor = factory( 'float64' );
-	var arr = new ctor( 'little-endian', [1.0, 2.0, 3.0, 4.0] );
+	var arr = new ctor( 'little-endian', [ 1.0, 2.0, 3.0, 4.0 ] );
 	var i;
 
-	for (i = 0; i < values.length; i++ ) {
+	for ( i = 0; i < values.length; i++ ) {
 		t.throws( badValue( values[i] ), TypeError, 'throws an error when provided ' + values[i] );
 	}