Skip to content

Commit f561a3e

Browse files
committed
refactor: apply suggestions from code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---
1 parent f48f437 commit f561a3e

File tree

1 file changed

+6
-8
lines changed
  • lib/node_modules/@stdlib/console/log-each-map/lib

1 file changed

+6
-8
lines changed

lib/node_modules/@stdlib/console/log-each-map/lib/main.js

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ var isString = require( '@stdlib/assert/is-string' ).isPrimitive;
2424
var isFunction = require( '@stdlib/assert/is-function' );
2525
var isCollection = require( '@stdlib/assert/is-collection' );
2626
var resolveGetter = require( '@stdlib/array/base/resolve-getter' );
27-
var slice = require( '@stdlib/array/base/slice' );
2827
var format = require( '@stdlib/string/format' );
2928
var logger = require( '@stdlib/console/log' );
3029

@@ -141,17 +140,16 @@ function logEachMap() {
141140
offsets.push( 0 );
142141
}
143142

143+
cbArgs = [];
144+
cbArgs[ n + 1 ] = args;
144145
for ( i = 0; i < len; i++ ) {
145146
for ( j = 0; j < n; j++ ) {
146-
values[ j+1 ] = getters[ j ]( args[ j ], offsets[ j ] );
147+
cbArgs[ j ] = getters[ j ]( args[ j ], offsets[ j ] );
148+
values[ j + 1 ] = cbArgs[ j ];
147149
offsets[ j ] += strides[ j ];
148150
}
149-
cbArgs = slice( values, 1, n+1 );
150-
cbArgs.push( i );
151-
for ( j = 0; j < args.length; j++ ) {
152-
cbArgs.push( args[j] );
153-
}
154-
values[ n+1 ] = clbk.apply( thisArg, cbArgs );
151+
cbArgs[ n ] = i;
152+
values[ n + 1 ] = clbk.apply( thisArg, cbArgs );
155153
logger( format.apply( null, values ) );
156154
}
157155
}

0 commit comments

Comments
 (0)