Skip to content

Commit f9bd4d6

Browse files
committed
chore: add suggestions
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 641df0f commit f9bd4d6

File tree

1 file changed

+34
-47
lines changed
  • lib/node_modules/@stdlib/array/base/to-inserted-at/lib

1 file changed

+34
-47
lines changed

lib/node_modules/@stdlib/array/base/to-inserted-at/lib/assign.js

Lines changed: 34 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -58,25 +58,22 @@ var format = require( '@stdlib/string/format' );
5858
* // returns true
5959
*/
6060
function indexed( x, index, value, out, stride, offset ) {
61-
var idx1;
62-
var idxo;
63-
var idx;
6461
var io;
6562
var i;
63+
var j;
6664

6765
io = offset;
68-
for ( i = 0; i < x.length; i++ ) {
69-
out[ io ] = x[ i ];
70-
io += stride;
71-
}
72-
for ( i = x.length - 1; i >= index; i-- ) {
73-
idx1 = offset + ( ( i + 1 ) * stride );
74-
idx = offset + ( i * stride );
75-
out[ idx1 ] = out[ idx ];
66+
j = 0;
67+
for ( i = 0; i < x.length + 1; i++ ) {
68+
if ( i === index ) {
69+
out[ io ] = value;
70+
io += stride;
71+
} else {
72+
out[ io ] = x[ j ];
73+
io += stride;
74+
j += 1;
75+
}
7676
}
77-
idxo = offset + ( index * stride );
78-
out[ idxo ] = value;
79-
8077
return out;
8178
}
8279

@@ -107,35 +104,31 @@ function indexed( x, index, value, out, stride, offset ) {
107104
function accessors( x, index, value, out, stride, offset ) {
108105
var xdata;
109106
var odata;
110-
var idx1;
111-
var idxo;
112107
var xget;
113-
var oget;
114108
var oset;
115-
var idx;
116109
var io;
117110
var i;
111+
var j;
118112

119113
xdata = x.data;
120114
odata = out.data;
121115

122116
xget = x.accessors[ 0 ];
123-
oget = out.accessors[ 0 ];
124117
oset = out.accessors[ 1 ];
125118

126119
io = offset;
127-
for ( i = 0; i < xdata.length; i++ ) {
128-
oset( odata, io, xget( xdata, i ) );
129-
io += stride;
130-
}
131-
for ( i = xdata.length - 1; i >= index; i-- ) {
132-
idx1 = offset + ( ( i + 1 ) * stride );
133-
idx = offset + ( i * stride );
134-
oset( odata, idx1, oget( odata, idx ) );
120+
j = 0;
121+
for ( i = 0; i < xdata.length + 1; i++ ) {
122+
if ( i === index ) {
123+
oset( odata, io, value );
124+
io += stride;
125+
} else {
126+
oset( odata, io, xget( xdata, j ) );
127+
io += stride;
128+
j += 1;
129+
}
135130
}
136131

137-
idxo = offset + ( index * stride );
138-
oset( odata, idxo, value );
139132
return odata;
140133
}
141134

@@ -163,32 +156,26 @@ function accessors( x, index, value, out, stride, offset ) {
163156
* // returns <Float64Array>[ 5.0, 6.0, 1.0, 2.0, 3.0, 4.0 ]
164157
*/
165158
function complex( x, index, value, out, stride, offset ) {
166-
var idx1;
167-
var idxo;
168-
var idx;
169159
var so;
170160
var io;
171161
var i;
172162
var j;
173163

174164
so = stride * 2; // multiply by 2, as real-valued array consists of interleaved real and imaginary components
175165
io = offset * 2;
176-
for ( i = 0; i < x.length/2; i++ ) {
177-
idx = io + ( i * so );
178-
j = i * 2;
179-
out[ idx ] = x[ j ];
180-
out[ idx + 1 ] = x[ j + 1 ];
181-
}
182-
for ( i = ( x.length/2 ) - 1; i >= index; i-- ) {
183-
idx1 = io + ( ( i + 1 ) * so );
184-
idx = io + ( i * so );
185-
out[ idx1 ] = out[ idx ];
186-
out[ idx1 + 1 ] = out[ idx + 1 ];
166+
j = 0;
167+
for ( i = 0; i < ( x.length + 1 ) / 2; i++ ) {
168+
if ( i === index ) {
169+
out[ io ] = real( value );
170+
out[ io + 1 ] = imag( value );
171+
io += so;
172+
} else {
173+
out[ io ] = x[ j ];
174+
out[ io + 1 ] = x[ j + 1 ];
175+
io += so;
176+
j += 2;
177+
}
187178
}
188-
idxo = io + ( index * so );
189-
out[ idxo ] = real( value );
190-
out[ idxo + 1 ] = imag( value );
191-
192179
return out;
193180
}
194181

0 commit comments

Comments
 (0)