refactor: optimise loops

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: aayush0325

lib/node_modules/@stdlib/lapack/base/dlange/lib/base.js

@@ -43,31 +43,71 @@ var abs = require( '@stdlib/math/base/special/abs' );
 * @param {integer} strideA1 - stride of the first dimension of `A`
 * @param {integer} strideA2 - stride of the second dimension of `A`
 * @param {NonNegativeInteger} offsetA - starting index of `A`
+* @param {Float64Array} work - work array, should have `N` indexed elements
+* @param {integer} strideWork - stride length of `work`
+* @param {NonNegativeInteger} offsetWork - starting index of `work`
 * @returns {number} required norm value
 *
 * @example
 * var Float64Array = require( '@stdlib/array/float64' );
 *
 * var A = new Float64Array( [ 1.0, 4.0, 7.0, 10.0, 2.0, 5.0, 8.0, 11.0, 3.0, 6.0, 9.0, 12.0 ] );
+* var work = new Float64Array( 4 );
 *
-* var out = oneNorm( 3, 4, A, 4, 1, 0 );
+* var out = oneNorm( 3, 4, A, 4, 1, 0, work, 1, 0 );
 * // returns 33.0
 */
-function oneNorm( M, N, A, strideA1, strideA2, offsetA ) {
+function oneNorm( M, N, A, strideA1, strideA2, offsetA, work, strideWork, offsetWork ) { // eslint-disable-line max-len
 	var value;
+	var temp;
 	var ia1;
+	var ia2;
 	var sum;
+	var iw;
+	var i;
 	var j;
 
-	value = 0.0;
-	ia1 = offsetA;
-	for ( j = 0; j < N; j++ ) {
-		sum = dasum( M, A, strideA1, ia1 );
-		if ( value < sum || isnan( sum ) ) {
-			value = sum;
+	if ( isRowMajor( [ strideA1, strideA2 ] ) ) {
+		iw = offsetWork;
+		for ( i = 0; i < N; i++ ) {
+			work[ iw ] = 0.0;
+			iw += strideWork;
+		}
+
+		ia1 = offsetA;
+		for ( j = 0; j < M; j++ ) {
+			ia2 = 0;
+			iw = offsetWork;
+			for ( i = 0; i < N; i++ ) {
+				work[ iw ] += abs( A[ ia1 + ia2 ] );
+				iw += strideWork;
+				ia2 += strideA2;
+			}
+			ia1 += strideA1;
+		}
+
+		value = 0.0;
+
+		iw = offsetWork;
+		for ( i = 0; i < N; i++ ) {
+			temp = work[ iw ];
+			if ( value < temp || isnan( temp ) ) {
+				value = temp;
+			}
+			iw += strideWork;
+		}
+	} else {
+		value = 0.0;
+		ia1 = offsetA;
+		for ( j = 0; j < N; j++ ) {
+			sum = dasum( M, A, strideA1, ia1 );
+			if ( value < sum || isnan( sum ) ) {
+				value = sum;
+			}
+			ia1 += strideA2;
 		}
-		ia1 += strideA2;
 	}
+
 	return value;
 }
 
@@ -157,31 +197,30 @@ function maxAbs( M, N, A, strideA1, strideA2, offsetA ) {
 function infinityNorm( M, N, A, strideA1, strideA2, offsetA, work, strideWork, offsetWork ) { // eslint-disable-line max-len
 	var value;
 	var temp;
+	var sum;
 	var ia1;
 	var ia2;
 	var iw;
 	var i;
 	var j;
 
-	iw = offsetWork;
-	for ( i = 0; i < M; i++ ) {
-		work[ iw ] = 0.0;
-		iw += strideWork;
-	}
-
 	if ( isRowMajor( [ strideA1, strideA2 ] ) ) {
+		value = 0.0;
 		ia1 = offsetA;
-		iw = offsetWork;
-		for ( i = 0; i < M; i++ ) {
-			ia2 = 0;
-			for ( j = 0; j < N; j++ ) {
-				work[ iw ] += abs( A[ ia1 + ia2 ] );
-				ia2 += strideA2;
+		for ( j = 0; j < M; j++ ) {
+			sum = dasum( N, A, strideA2, ia1 );
+			if ( value < sum || isnan( sum ) ) {
+				value = sum;
 			}
 			ia1 += strideA1;
-			iw += strideWork;
 		}
 	} else {
+		iw = offsetWork;
+		for ( i = 0; i < M; i++ ) {
+			work[ iw ] = 0.0;
+			iw += strideWork;
+		}
+
 		ia1 = offsetA;
 		for ( j = 0; j < N; j++ ) {
 			ia2 = 0;
@@ -193,19 +232,18 @@ function infinityNorm( M, N, A, strideA1, strideA2, offsetA, work, strideWork, o
 			}
 			ia1 += strideA2;
 		}
-	}
 
-	value = 0.0;
+		value = 0.0;
 
-	iw = offsetWork;
-	for ( i = 0; i < M; i++ ) {
-		temp = work[ iw ];
-		if ( value < temp || isnan( temp ) ) {
-			value = temp;
+		iw = offsetWork;
+		for ( i = 0; i < M; i++ ) {
+			temp = work[ iw ];
+			if ( value < temp || isnan( temp ) ) {
+				value = temp;
+			}
+			iw += strideWork;
 		}
-		iw += strideWork;
 	}
-
 	return value;
 }
 
@@ -289,7 +327,7 @@ function dlange( norm, M, N, A, strideA1, strideA2, offsetA, work, strideWork, o
 	}
 
 	if ( norm === 'one' ) {
-		return oneNorm( M, N, A, strideA1, strideA2, offsetA );
+		return oneNorm( M, N, A, strideA1, strideA2, offsetA, work, strideWork, offsetWork ); // eslint-disable-line max-len
 	}
 
 	if ( norm === 'infinity' ) {

lib/node_modules/@stdlib/lapack/base/dlange/test/fixtures/large_strides/one_norm_column_major.json

@@ -44,7 +44,8 @@
     0.0,
     9999.0,
     0.0,
-    9999.0
+    9999.0,
+    0.0
   ],
   "strideWork": 2,
   "offsetWork": 0,

lib/node_modules/@stdlib/lapack/base/dlange/test/fixtures/large_strides/one_norm_row_major.json

@@ -44,7 +44,8 @@
     0.0,
     9999.0,
     0.0,
-    9999.0
+    9999.0,
+    0.0
   ],
   "strideWork": 2,
   "offsetWork": 0,

lib/node_modules/@stdlib/lapack/base/dlange/test/fixtures/mixed_strides/one_norm_column_major.json

@@ -27,6 +27,7 @@
     [ 3.0, 6.0, 9.0, 12.0 ]
   ],
   "work": [
+    0.0,
     0.0,
     0.0,
     0.0

lib/node_modules/@stdlib/lapack/base/dlange/test/fixtures/mixed_strides/one_norm_row_major.json

@@ -27,6 +27,7 @@
     [ 3.0, 6.0, 9.0, 12.0 ]
   ],
   "work": [
+    0.0,
     0.0,
     0.0,
     0.0

lib/node_modules/@stdlib/lapack/base/dlange/test/fixtures/negative_strides/one_norm_column_major.json

@@ -27,11 +27,12 @@
     [ 3.0, 6.0, 9.0, 12.0 ]
   ],
   "work": [
+    0.0,
     0.0,
     0.0,
     0.0
   ],
   "strideWork": -1,
-  "offsetWork": 2,
+  "offsetWork": 3,
   "expected": 33
 }

lib/node_modules/@stdlib/lapack/base/dlange/test/fixtures/negative_strides/one_norm_row_major.json

@@ -27,11 +27,12 @@
     [ 3.0, 6.0, 9.0, 12.0 ]
   ],
   "work": [
+    0.0,
     0.0,
     0.0,
     0.0
   ],
   "strideWork": -1,
-  "offsetWork": 2,
+  "offsetWork": 3,
   "expected": 33
 }

lib/node_modules/@stdlib/lapack/base/dlange/test/fixtures/offsets/one_norm_column_major.json

@@ -31,6 +31,7 @@
     9999.0,
     0.0,
     0.0,
+    0.0,
     0.0
   ],
   "strideWork": 1,

lib/node_modules/@stdlib/lapack/base/dlange/test/fixtures/offsets/one_norm_row_major.json

@@ -31,6 +31,7 @@
     9999.0,
     0.0,
     0.0,
+    0.0,
     0.0
   ],
   "strideWork": 1,

lib/node_modules/@stdlib/lapack/base/dlange/test/fixtures/one_norm_column_major.json

@@ -13,7 +13,7 @@
     [ 2.0, 5.0, 8.0, 11.0 ],
     [ 3.0, 6.0, 9.0, 12.0 ]
   ],
-  "work": [ 0.0, 0.0, 0.0 ],
+  "work": [ 0.0, 0.0, 0.0, 0.0 ],
   "strideWork": 1,
   "offsetWork": 0,
   "expected": 33.0